You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/05/30 08:34:02 UTC
[GitHub] [dubbo-go] codecov-commenter commented on pull request #491: (WIP) ServiceDiscoveryRegistry implementation
codecov-commenter commented on pull request #491:
URL: https://github.com/apache/dubbo-go/pull/491#issuecomment-636299314
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/491?src=pr&el=h1) Report
> Merging [#491](https://codecov.io/gh/apache/dubbo-go/pull/491?src=pr&el=desc) into [feature/dubbo-2.7.5](https://codecov.io/gh/apache/dubbo-go/commit/9578fc0bbc1bbabfa6afc79bad3b5fd89009af3b&el=desc) will **decrease** coverage by `1.52%`.
> The diff coverage is `22.44%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/491?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/dubbo-2.7.5 #491 +/- ##
=======================================================
- Coverage 66.06% 64.53% -1.53%
=======================================================
Files 203 202 -1
Lines 10558 10596 +38
=======================================================
- Hits 6975 6838 -137
- Misses 2909 3103 +194
+ Partials 674 655 -19
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/491?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/directory/base\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/491/diff?src=pr&el=tree#diff-Y2x1c3Rlci9kaXJlY3RvcnkvYmFzZV9kaXJlY3RvcnkuZ28=) | `72.50% <ø> (+6.59%)` | :arrow_up: |
| [common/extension/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/491/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9zZXJ2aWNlX2Rpc2NvdmVyeS5nbw==) | `0.00% <0.00%> (ø)` | |
| [...mon/extension/service\_instance\_selector\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/491/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9zZXJ2aWNlX2luc3RhbmNlX3NlbGVjdG9yX2ZhY3RvcnkuZ28=) | `0.00% <0.00%> (ø)` | |
| [common/extension/service\_name\_mapping.go](https://codecov.io/gh/apache/dubbo-go/pull/491/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9zZXJ2aWNlX25hbWVfbWFwcGluZy5nbw==) | `0.00% <0.00%> (ø)` | |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/491/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `56.25% <ø> (ø)` | |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/491/diff?src=pr&el=tree#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `55.88% <ø> (ø)` | |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/491/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `78.70% <ø> (ø)` | |
| [config/router\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/491/diff?src=pr&el=tree#diff-Y29uZmlnL3JvdXRlcl9jb25maWcuZ28=) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [...try/servicediscovery/service\_discovery\_registry.go](https://codecov.io/gh/apache/dubbo-go/pull/491/diff?src=pr&el=tree#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9zZXJ2aWNlX2Rpc2NvdmVyeV9yZWdpc3RyeS5nbw==) | `0.57% <0.57%> (ø)` | |
| [metadata/mapping/dynamic/service\_name\_mapping.go](https://codecov.io/gh/apache/dubbo-go/pull/491/diff?src=pr&el=tree#diff-bWV0YWRhdGEvbWFwcGluZy9keW5hbWljL3NlcnZpY2VfbmFtZV9tYXBwaW5nLmdv) | `69.23% <40.00%> (-19.01%)` | :arrow_down: |
| ... and [40 more](https://codecov.io/gh/apache/dubbo-go/pull/491/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/491?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/491?src=pr&el=footer). Last update [9578fc0...7e912e7](https://codecov.io/gh/apache/dubbo-go/pull/491?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org