You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/08/16 19:50:27 UTC
Review Request 24772: Fixed libprocess tests due to the new io::read
semantics.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24772/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Timothy Chen, and Vinod Kone.
Bugs: MESOS-1710
https://issues.apache.org/jira/browse/MESOS-1710
Repository: mesos-git
Description
-------
The new io::read semantics is changing (dup + nonblock internally), we need to adjust the test expectations.
Diffs
-----
3rdparty/libprocess/src/tests/io_tests.cpp 1102b1a72959f219fc16de52eee5d4950a48a7d4
3rdparty/libprocess/src/tests/subprocess_tests.cpp 5fec28987a7a833415bab1c7f086841b8647c8b5
Diff: https://reviews.apache.org/r/24772/diff/
Testing
-------
make check
3rdparty/libprocess/tests --gtest_filter=*IO*:*Subprocess* --gtest_repeat=1000
Thanks,
Jie Yu
Re: Review Request 24772: Fixed libprocess tests due to the new
io::read semantics.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24772/#review50828
-----------------------------------------------------------
Ship it!
Thanks Jie. :-/
- Benjamin Hindman
On Aug. 16, 2014, 5:50 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24772/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2014, 5:50 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Timothy Chen, and Vinod Kone.
>
>
> Bugs: MESOS-1710
> https://issues.apache.org/jira/browse/MESOS-1710
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The new io::read semantics is changing (dup + nonblock internally), we need to adjust the test expectations.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/io_tests.cpp 1102b1a72959f219fc16de52eee5d4950a48a7d4
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp 5fec28987a7a833415bab1c7f086841b8647c8b5
>
> Diff: https://reviews.apache.org/r/24772/diff/
>
>
> Testing
> -------
>
> make check
> 3rdparty/libprocess/tests --gtest_filter=*IO*:*Subprocess* --gtest_repeat=1000
>
>
> Thanks,
>
> Jie Yu
>
>