You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Eric Sammer <es...@cloudera.com> on 2011/12/05 17:08:51 UTC
Review Request: FLUME-867: Pollable source and sink runners should reduce
poll interval after several BACKOFFs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2999/
-----------------------------------------------------------
Review request for Flume, Arvind Prabhakar and Prasad Mujumdar.
Summary
-------
Updated to backoff the poll interval by 1 second with a max of 5 seconds if successive BACKOFFs are returned from either a PollableSource or PollableSink.
This addresses bug FLUME-867.
https://issues.apache.org/jira/browse/FLUME-867
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/sink/PollableSinkRunner.java 7bfb589
flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceRunner.java 8b01da0
Diff: https://reviews.apache.org/r/2999/diff
Testing
-------
Unit tests pass, manual testing shows successful data transfer (with added delay in some cases, as expected).
Thanks,
Eric
Re: Review Request: FLUME-867: Pollable source and sink runners should
reduce poll interval after several BACKOFFs
Posted by Eric Sammer <es...@cloudera.com>.
> On 2011-12-05 17:28:25, Prasad Mujumdar wrote:
> > I am wondering if the interval increment should be shorter, 500 or less ...
> > Otherwise looks good to me.
> >
At some point, I think it's useful for these to be configurable. The reason I went for 1000ms is because this impacts things like AvroSink's client retry interval and 500ms seemed too fast. I'm going to leave it for now but let's revisit.
- Eric
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2999/#review3620
-----------------------------------------------------------
On 2011-12-05 16:08:51, Eric Sammer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2999/
> -----------------------------------------------------------
>
> (Updated 2011-12-05 16:08:51)
>
>
> Review request for Flume, Arvind Prabhakar and Prasad Mujumdar.
>
>
> Summary
> -------
>
> Updated to backoff the poll interval by 1 second with a max of 5 seconds if successive BACKOFFs are returned from either a PollableSource or PollableSink.
>
>
> This addresses bug FLUME-867.
> https://issues.apache.org/jira/browse/FLUME-867
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/sink/PollableSinkRunner.java 7bfb589
> flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceRunner.java 8b01da0
>
> Diff: https://reviews.apache.org/r/2999/diff
>
>
> Testing
> -------
>
> Unit tests pass, manual testing shows successful data transfer (with added delay in some cases, as expected).
>
>
> Thanks,
>
> Eric
>
>
Re: Review Request: FLUME-867: Pollable source and sink runners should
reduce poll interval after several BACKOFFs
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2999/#review3620
-----------------------------------------------------------
Ship it!
I am wondering if the interval increment should be shorter, 500 or less ...
Otherwise looks good to me.
- Prasad
On 2011-12-05 16:08:51, Eric Sammer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2999/
> -----------------------------------------------------------
>
> (Updated 2011-12-05 16:08:51)
>
>
> Review request for Flume, Arvind Prabhakar and Prasad Mujumdar.
>
>
> Summary
> -------
>
> Updated to backoff the poll interval by 1 second with a max of 5 seconds if successive BACKOFFs are returned from either a PollableSource or PollableSink.
>
>
> This addresses bug FLUME-867.
> https://issues.apache.org/jira/browse/FLUME-867
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/sink/PollableSinkRunner.java 7bfb589
> flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceRunner.java 8b01da0
>
> Diff: https://reviews.apache.org/r/2999/diff
>
>
> Testing
> -------
>
> Unit tests pass, manual testing shows successful data transfer (with added delay in some cases, as expected).
>
>
> Thanks,
>
> Eric
>
>