You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Paul Lindner (JIRA)" <ji...@apache.org> on 2010/09/08 05:48:32 UTC

[jira] Resolved: (SHINDIG-1422) shindig.uri.ext's resolve() doesn't work on IE 6/7

     [ https://issues.apache.org/jira/browse/SHINDIG-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Lindner resolved SHINDIG-1422.
-----------------------------------

    Resolution: Fixed

fixed in the new 2.0.0

> shindig.uri.ext's resolve() doesn't work on IE 6/7
> --------------------------------------------------
>
>                 Key: SHINDIG-1422
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1422
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: 2.0.0
>            Reporter: Javier Pedemonte
>             Fix For: 2.0.0
>
>
> Array-based accessors to strings don't work in IE 6/7.  So the statement "selfPath[0]" returns "undefined".  Need to use charAt() instead.
> Also, seems like a call to substring() was missing.
> diff --git a/features/src/main/javascript/features/shindig.uri.ext/util.js b/features/src/
> index 5c64e12..c274ad6 100644
> --- a/features/src/main/javascript/features/shindig.uri.ext/util.js
> +++ b/features/src/main/javascript/features/shindig.uri.ext/util.js
> @@ -52,11 +52,11 @@ shindig.uri = (function() {
>        self.setAuthority(base.getAuthority());
>      }
>      var selfPath = self.getPath();
> -    if (selfPath == '' || selfPath[0] != '/') {
> +    if (selfPath == '' || selfPath.charAt(0) != '/') {
>        var basePath = base.getPath(); 
>        var lastSlash = basePath.lastIndexOf('/');
>        if (lastSlash != -1) {
> -        basePath = basePath(0, lastSlash + 1);
> +        basePath = basePath.substring(0, lastSlash + 1);
>        }
>        self.setPath(base.getPath() + selfPath);
>      }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.