You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/01/13 22:08:17 UTC
[GitHub] [incubator-gobblin] jack-moseley opened a new pull request #2865:
[GOBBLIN-1019] Change jcenter url to https
jack-moseley opened a new pull request #2865: [GOBBLIN-1019] Change jcenter url to https
URL: https://github.com/apache/incubator-gobblin/pull/2865
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1019
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
Change jcenter url to https to fix build since http returns 403 as of 01/13/20 (see https://jfrog.com/blog/secure-jcenter-with-https/)
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] asfgit closed pull request #2865:
[GOBBLIN-1019] Change jcenter url to https
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2865: [GOBBLIN-1019] Change jcenter url to https
URL: https://github.com/apache/incubator-gobblin/pull/2865
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2865:
[GOBBLIN-1019] Change jcenter url to https
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #2865: [GOBBLIN-1019] Change jcenter url to https
URL: https://github.com/apache/incubator-gobblin/pull/2865#issuecomment-573915797
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2865?src=pr&el=h1) Report
> Merging [#2865](https://codecov.io/gh/apache/incubator-gobblin/pull/2865?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/64b074182a7bea017a249204c5448ee79a0a28ac?src=pr&el=desc) will **increase** coverage by `41.64%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2865?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2865 +/- ##
=============================================
+ Coverage 4.1% 45.75% +41.64%
- Complexity 747 9104 +8357
=============================================
Files 1917 1917
Lines 72131 72131
Branches 7956 7956
=============================================
+ Hits 2961 33002 +30041
+ Misses 68851 36102 -32749
- Partials 319 3027 +2708
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2865?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...gobblin/service/monitoring/JobStatusRetriever.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2865/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9Kb2JTdGF0dXNSZXRyaWV2ZXIuamF2YQ==) | `0% <0%> (ø)` | `2% <0%> (+2%)` | :arrow_up: |
| [...ata/management/copy/hive/HivePartitionFileSet.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2865/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaGl2ZS9IaXZlUGFydGl0aW9uRmlsZVNldC5qYXZh) | `0.95% <0%> (+0.95%)` | `1% <0%> (+1%)` | :arrow_up: |
| [...ain/java/org/apache/gobblin/runtime/TaskState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2865/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFza1N0YXRlLmphdmE=) | `81.97% <0%> (+1.16%)` | `32% <0%> (ø)` | :arrow_down: |
| [...pache/gobblin/runtime/GobblinMultiTaskAttempt.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2865/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvR29iYmxpbk11bHRpVGFza0F0dGVtcHQuamF2YQ==) | `56.3% <0%> (+1.35%)` | `27% <0%> (+2%)` | :arrow_up: |
| [...ava/org/apache/gobblin/runtime/MultiConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2865/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvTXVsdGlDb252ZXJ0ZXIuamF2YQ==) | `83.6% <0%> (+1.63%)` | `9% <0%> (+1%)` | :arrow_up: |
| [...rg/apache/gobblin/runtime/FsDatasetStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2865/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvRnNEYXRhc2V0U3RhdGVTdG9yZS5qYXZh) | `73.8% <0%> (+1.78%)` | `35% <0%> (+1%)` | :arrow_up: |
| [...a/org/apache/gobblin/cluster/SingleTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2865/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvU2luZ2xlVGFza1J1bm5lci5qYXZh) | `1.85% <0%> (+1.85%)` | `1% <0%> (+1%)` | :arrow_up: |
| [.../java/org/apache/gobblin/runtime/TaskExecutor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2865/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFza0V4ZWN1dG9yLmphdmE=) | `45.35% <0%> (+2.73%)` | `9% <0%> (+1%)` | :arrow_up: |
| [...apache/gobblin/source/jdbc/SqlServerExtractor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2865/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9qZGJjL1NxbFNlcnZlckV4dHJhY3Rvci5qYXZh) | `4.41% <0%> (+4.41%)` | `3% <0%> (+3%)` | :arrow_up: |
| [...ava/org/apache/gobblin/http/ApacheHttpRequest.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2865/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4taHR0cC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9odHRwL0FwYWNoZUh0dHBSZXF1ZXN0LmphdmE=) | `5.55% <0%> (+5.55%)` | `1% <0%> (+1%)` | :arrow_up: |
| ... and [1110 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2865/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2865?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2865?src=pr&el=footer). Last update [64b0741...a1b4ae4](https://codecov.io/gh/apache/incubator-gobblin/pull/2865?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] codecov-io commented on issue #2865:
[GOBBLIN-1019] Change jcenter url to https
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #2865: [GOBBLIN-1019] Change jcenter url to https
URL: https://github.com/apache/incubator-gobblin/pull/2865#issuecomment-573915797
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2865?src=pr&el=h1) Report
> Merging [#2865](https://codecov.io/gh/apache/incubator-gobblin/pull/2865?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/64b074182a7bea017a249204c5448ee79a0a28ac?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2865?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2865 +/- ##
========================================
Coverage 4.1% 4.1%
Complexity 747 747
========================================
Files 1917 1917
Lines 72131 72131
Branches 7956 7956
========================================
Hits 2961 2961
Misses 68851 68851
Partials 319 319
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2865?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2865?src=pr&el=footer). Last update [64b0741...a1b4ae4](https://codecov.io/gh/apache/incubator-gobblin/pull/2865?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services