You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Ian Bacher (JIRA)" <ji...@apache.org> on 2009/02/06 00:07:59 UTC

[jira] Created: (WICKET-2083) NPE when clearing DateTimeField

NPE when clearing DateTimeField 
--------------------------------

                 Key: WICKET-2083
                 URL: https://issues.apache.org/jira/browse/WICKET-2083
             Project: Wicket
          Issue Type: Bug
          Components: wicket-datetime
    Affects Versions: 1.4-RC1, 1.4-RC2
         Environment: Java 5+
            Reporter: Ian Bacher
             Fix For: 1.4-RC3
         Attachments: DateTimeFieldTestCase.java, patch.diff

setDate() doesn't properly handle null values for the date parameter. When date is null the instance date field is properly set to null but the hours and minutes fields remain untouched, so if hours had previously been set, a NPE is thrown by line 239. I'll attach a test case to demonstrate the behavior and a proposed patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-2083) NPE when clearing DateTimeField

Posted by "Ian Bacher (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ian Bacher updated WICKET-2083:
-------------------------------

    Attachment: patch.diff

Proposed patch

> NPE when clearing DateTimeField 
> --------------------------------
>
>                 Key: WICKET-2083
>                 URL: https://issues.apache.org/jira/browse/WICKET-2083
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-datetime
>    Affects Versions: 1.4-RC1, 1.4-RC2
>         Environment: Java 5+
>            Reporter: Ian Bacher
>             Fix For: 1.4-RC3
>
>         Attachments: DateTimeFieldTestCase.java, patch.diff
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> setDate() doesn't properly handle null values for the date parameter. When date is null the instance date field is properly set to null but the hours and minutes fields remain untouched, so if hours had previously been set, a NPE is thrown by line 239. I'll attach a test case to demonstrate the behavior and a proposed patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-2083) NPE when clearing DateTimeField

Posted by "Ian Bacher (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ian Bacher updated WICKET-2083:
-------------------------------

    Attachment: DateTimeFieldTestCase.java

Test case

> NPE when clearing DateTimeField 
> --------------------------------
>
>                 Key: WICKET-2083
>                 URL: https://issues.apache.org/jira/browse/WICKET-2083
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-datetime
>    Affects Versions: 1.4-RC1, 1.4-RC2
>         Environment: Java 5+
>            Reporter: Ian Bacher
>             Fix For: 1.4-RC3
>
>         Attachments: DateTimeFieldTestCase.java, patch.diff
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> setDate() doesn't properly handle null values for the date parameter. When date is null the instance date field is properly set to null but the hours and minutes fields remain untouched, so if hours had previously been set, a NPE is thrown by line 239. I'll attach a test case to demonstrate the behavior and a proposed patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WICKET-2083) NPE when clearing DateTimeField

Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juergen Donnerstag resolved WICKET-2083.
----------------------------------------

    Resolution: Fixed
      Assignee: Juergen Donnerstag

thanks

> NPE when clearing DateTimeField 
> --------------------------------
>
>                 Key: WICKET-2083
>                 URL: https://issues.apache.org/jira/browse/WICKET-2083
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-datetime
>    Affects Versions: 1.4-RC1, 1.4-RC2
>         Environment: Java 5+
>            Reporter: Ian Bacher
>            Assignee: Juergen Donnerstag
>             Fix For: 1.4-RC3
>
>         Attachments: DateTimeFieldTestCase.java, patch.diff
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> setDate() doesn't properly handle null values for the date parameter. When date is null the instance date field is properly set to null but the hours and minutes fields remain untouched, so if hours had previously been set, a NPE is thrown by line 239. I'll attach a test case to demonstrate the behavior and a proposed patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.