You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/08/17 03:03:22 UTC
[GitHub] [incubator-kyuubi] tongwl opened a new pull request, #3250: Init frontend framework
tongwl opened a new pull request, #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
This is a pr about init frontend framework using vue3.
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] tongwl commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
tongwl commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948927017
##########
kyuubi-server/web-ui/README.md:
##########
@@ -0,0 +1,39 @@
+# Kyuubi-ui
+
+### Start Using
+
+For the best experience, we recommend using `node 16.15.1` and `pnpm 7.9.0`.
+You can learn how to install the corresponding version from their official website.
+
+- [node](https://nodejs.org/en/)
+- [pnpm](https://pnpm.io/)
Review Comment:
Hi, you can also use `npm install`, `npm run start`, `npm run build` etc, there is no conflict with pnpm install ...
But my point is front-end technology is always updated and iterative, npm is classic, but has its flaws, so there are many packaging tools that want to replace, there is no doubt that yarn, pnpm have had some success. There are many cases in the market using pnpm, the using of pnpm will not affect business code, building or others, the only role in this project is to improve the efficiency of development. For example, when you changed the code, and need verify on the page, the speed of pnpm refreshing the page on the browser is very fast.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] tongwl commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
tongwl commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948974651
##########
kyuubi-server/web-ui/README.md:
##########
@@ -0,0 +1,39 @@
+# Kyuubi-ui
+
+### Start Using
+
+For the best experience, we recommend using `node 16.15.1` and `pnpm 7.9.0`.
+You can learn how to install the corresponding version from their official website.
+
+- [node](https://nodejs.org/en/)
+- [pnpm](https://pnpm.io/)
Review Comment:
Sure, I originally wrote both npm install and pnpm install in the readme, but I thought it was a bit long-winded later~~ Let's fine, let me add npm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948669104
##########
kyuubi-server/web-ui/README.md:
##########
@@ -0,0 +1,39 @@
+# Kyuubi-ui
+
+### Start Using
+
+For the best experience, we recommend using `node 16.15.1` and `pnpm 7.9.0`.
+You can learn how to install the corresponding version from their official website.
+
+- [node](https://nodejs.org/en/)
+- [pnpm](https://pnpm.io/)
+
+### Install Dependencies
+
+```shell
+pnpm install
+```
+
+### Development Project
+
+To do this you can change the VITE_APP_DEV_WEB_URL parameter variable as the service url in .env.development in the project root directory, such as http://127.0. 0.1:8090
+
+
+```shell
+pnpm dev
+```
+
+### Build Project
+
+```shell
+pnpm run build
+```
+
+### Code Format
+
+Usually after you modify the code, you need to perform code formatting operations to ensure that the code in the project is the same style.
+
+```shell
+pnpm run prettier
Review Comment:
we provded a shell script `dev/reformat` for same purpose on backend codes. would you like to merge it into `dev/format` or provide another one at `kyuubi-server/web-ui/reformat` or in some place?
##########
kyuubi-server/web-ui/README.md:
##########
@@ -0,0 +1,39 @@
+# Kyuubi-ui
+
+### Start Using
+
+For the best experience, we recommend using `node 16.15.1` and `pnpm 7.9.0`.
+You can learn how to install the corresponding version from their official website.
+
+- [node](https://nodejs.org/en/)
+- [pnpm](https://pnpm.io/)
+
+### Install Dependencies
+
+```shell
+pnpm install
+```
+
+### Development Project
+
+To do this you can change the VITE_APP_DEV_WEB_URL parameter variable as the service url in .env.development in the project root directory, such as http://127.0. 0.1:8090
+
+
+```shell
+pnpm dev
+```
+
+### Build Project
+
+```shell
+pnpm run build
+```
+
+### Code Format
+
+Usually after you modify the code, you need to perform code formatting operations to ensure that the code in the project is the same style.
+
+```shell
+pnpm run prettier
Review Comment:
we provded a shell script `dev/reformat` for same purpose on backend codes. would you like to merge it into `dev/reformat` or provide another one at `kyuubi-server/web-ui/reformat` or in some place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948659203
##########
kyuubi-server/web-ui/package.json:
##########
@@ -0,0 +1,50 @@
+{
+ "name": "kyuubi-ui",
+ "private": true,
+ "version": "1.6.0-SNAPSHOT",
Review Comment:
please rebase master and change it to 1.7.0-SNAPSHOT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] tongwl commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
tongwl commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948967222
##########
kyuubi-server/web-ui/src/components.d.ts:
##########
@@ -0,0 +1,24 @@
+// generated by unplugin-vue-components
Review Comment:
No, I tried, I will research if I can hard code it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#issuecomment-1221252908
Thanks @tongwl, I think it's almost there, w/ a fews license issues.
The Apache Rat reports 5 files w/o license header issue.
```
5 Unknown Licenses
*****************************************************
Files with unapproved licenses:
kyuubi-server/web-ui/pnpm-lock.yaml
kyuubi-server/web-ui/src/main.ts
kyuubi-server/web-ui/src/vite-env.d.ts
kyuubi-server/web-ui/src/components.d.ts
kyuubi-server/web-ui/src/auto-imports.d.ts
*****************************************************
```
I think
- `pnpm-lock.yaml` could be excluded in `.rat-excludes`
- `components.d.ts` and `auto-imports.d.ts` should be we removed?
- add license header for `vite-env.d.ts` if possible or exclude it in `.rat-excludes`
- add license header for `main.ts`
After solving above issue, I'm going to merge this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] tongwl commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
tongwl commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948941375
##########
kyuubi-server/web-ui/README.md:
##########
@@ -0,0 +1,39 @@
+# Kyuubi-ui
+
+### Start Using
+
+For the best experience, we recommend using `node 16.15.1` and `pnpm 7.9.0`.
Review Comment:
Generally, when installing node, npm will have a default version to follow, I am not sure if we need point npm version, what I think is no need. In theory, the node16 version can be specified, but I have not tried all the 16 versions. I have encountered in the 12 version that not all the 12 versions can successfully install dependencies in a project, node 16.15.1 is the savest, as I am using 16.15.1 to build this project.
##########
kyuubi-server/web-ui/README.md:
##########
@@ -0,0 +1,39 @@
+# Kyuubi-ui
Review Comment:
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948663459
##########
kyuubi-server/web-ui/package.json:
##########
@@ -0,0 +1,50 @@
+{
+ "name": "kyuubi-ui",
+ "private": true,
+ "version": "1.6.0-SNAPSHOT",
+ "type": "module",
+ "scripts": {
+ "dev": "vite --port 8080",
Review Comment:
let switch to another port like 9090, 9 is the lucky number for kyuubi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#issuecomment-1217432511
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/3250?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3250](https://codecov.io/gh/apache/incubator-kyuubi/pull/3250?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a1aaba0) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/8c2e77465fe13a4a7ef016132cc8cbee698f617d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8c2e774) will **increase** coverage by `0.11%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3250 +/- ##
============================================
+ Coverage 50.94% 51.06% +0.11%
Complexity 13 13
============================================
Files 469 470 +1
Lines 26123 26224 +101
Branches 3612 3626 +14
============================================
+ Hits 13308 13390 +82
- Misses 11544 11555 +11
- Partials 1271 1279 +8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/3250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3250/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `70.00% <0.00%> (-3.69%)` | :arrow_down: |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3250/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `76.81% <0.00%> (-1.13%)` | :arrow_down: |
| [...he/kyuubi/ha/client/etcd/EtcdDiscoveryClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3250/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9ldGNkL0V0Y2REaXNjb3ZlcnlDbGllbnQuc2NhbGE=) | `67.50% <0.00%> (-0.63%)` | :arrow_down: |
| [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3250/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `82.60% <0.00%> (-0.63%)` | :arrow_down: |
| [...g/apache/kyuubi/operation/BatchJobSubmission.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3250/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vQmF0Y2hKb2JTdWJtaXNzaW9uLnNjYWxh) | `74.40% <0.00%> (ø)` | |
| [...uthentication/JdbcAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3250/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0pkYmNBdXRoZW50aWNhdGlvblByb3ZpZGVySW1wbC5zY2FsYQ==) | `79.74% <0.00%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3250/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `97.40% <0.00%> (+0.04%)` | :arrow_up: |
| [...mon/src/main/scala/org/apache/kyuubi/Logging.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3250/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9Mb2dnaW5nLnNjYWxh) | `44.73% <0.00%> (+1.31%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] tongwl commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
tongwl commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948906584
##########
kyuubi-server/web-ui/package.json:
##########
@@ -0,0 +1,50 @@
+{
+ "name": "kyuubi-ui",
+ "private": true,
+ "version": "1.6.0-SNAPSHOT",
Review Comment:
sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r949013785
##########
kyuubi-server/web-ui/package.json:
##########
@@ -0,0 +1,50 @@
+{
+ "name": "kyuubi-ui",
+ "private": true,
+ "version": "1.6.0-SNAPSHOT",
+ "type": "module",
+ "scripts": {
+ "dev": "vite --port 8080",
+ "build": "vue-tsc --noEmit && vite build --mode production",
+ "build-check": "npm run lint && npm run build",
+ "preview": "vite preview",
+ "lint": "eslint --ext .ts,vue --ignore-path .gitignore .",
+ "lint-fix": "eslint --fix --ext .ts,vue --ignore-path .gitignore .",
+ "prettier": "prettier --write \"src/**/*.{vue,ts,tsx}\"",
+ "test": "vitest",
+ "coverage": "vitest run --coverage"
+ },
+ "dependencies": {
+ "@element-plus/icons-vue": "^2.0.9",
+ "axios": "^0.27.2",
+ "element-plus": "^2.2.12",
+ "pinia": "^2.0.18",
+ "pinia-plugin-persistedstate": "^2.1.1",
+ "vue": "^3.2.37",
+ "vue-i18n": "^9.2.2",
+ "vue-router": "^4.1.3"
Review Comment:
I've heard of those things. It recommends using dynamic versions to benefit patches applied automatically, but this causes the dependency tree to become indeterminate, then it recommends using `package.lock.json` to pin versions to restore determinism.
Sounds like it create a problem first, then create a new tool to solve the problem...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#issuecomment-1223610983
Thanks @tongwl, merging to master for 1.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948661922
##########
kyuubi-server/web-ui/README.md:
##########
@@ -0,0 +1,39 @@
+# Kyuubi-ui
+
+### Start Using
+
+For the best experience, we recommend using `node 16.15.1` and `pnpm 7.9.0`.
+You can learn how to install the corresponding version from their official website.
+
+- [node](https://nodejs.org/en/)
+- [pnpm](https://pnpm.io/)
+
+### Install Dependencies
+
+```shell
+pnpm install
+```
+
+### Development Project
+
+To do this you can change the VITE_APP_DEV_WEB_URL parameter variable as the service url in .env.development in the project root directory, such as http://127.0. 0.1:8090
Review Comment:
quote `.env.development` by `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948952797
##########
kyuubi-server/web-ui/README.md:
##########
@@ -0,0 +1,39 @@
+# Kyuubi-ui
+
+### Start Using
+
+For the best experience, we recommend using `node 16.15.1` and `pnpm 7.9.0`.
+You can learn how to install the corresponding version from their official website.
+
+- [node](https://nodejs.org/en/)
+- [pnpm](https://pnpm.io/)
Review Comment:
yarn claims to provide better performance and developer experience as well, I respect your preference of pnpm, I you prefer, we can keep it and mark as recommanded but it's optional, can we doucment how to setup using npm as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948947104
##########
kyuubi-server/web-ui/README.md:
##########
@@ -0,0 +1,39 @@
+# Kyuubi-ui
+
+### Start Using
+
+For the best experience, we recommend using `node 16.15.1` and `pnpm 7.9.0`.
Review Comment:
Sound reasonable, let ponit the requirement of node v16
##########
kyuubi-server/web-ui/README.md:
##########
@@ -0,0 +1,39 @@
+# Kyuubi-ui
+
+### Start Using
+
+For the best experience, we recommend using `node 16.15.1` and `pnpm 7.9.0`.
Review Comment:
Sounds reasonable, let ponit the requirement of node v16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] tongwl commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
tongwl commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r949041096
##########
kyuubi-server/web-ui/src/App.vue:
##########
@@ -0,0 +1,20 @@
+/* * Licensed to the Apache Software Foundation (ASF) under one or more *
+contributor license agreements. See the NOTICE file distributed with * this work
+for additional information regarding copyright ownership. * The ASF licenses
+this file to You under the Apache License, Version 2.0 * (the "License"); you
+may not use this file except in compliance with * the License. You may obtain a
+copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless
+required by applicable law or agreed to in writing, software * distributed under
+the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR
+CONDITIONS OF ANY KIND, either express or implied. * See the License for the
+specific language governing permissions and * limitations under the License. */
Review Comment:
yes, nice example. Vue support \<!-- --\> and \/* *\/ as comment format, \<!-- --\> will not formatted by eslint, will change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948952797
##########
kyuubi-server/web-ui/README.md:
##########
@@ -0,0 +1,39 @@
+# Kyuubi-ui
+
+### Start Using
+
+For the best experience, we recommend using `node 16.15.1` and `pnpm 7.9.0`.
+You can learn how to install the corresponding version from their official website.
+
+- [node](https://nodejs.org/en/)
+- [pnpm](https://pnpm.io/)
Review Comment:
yarn claims to provide better performance and developer experience as well, I respect your preference of pnpm, if you prefer, we can keep it and mark as recommanded but optional, can we doucment how to setup using npm as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] tongwl commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
tongwl commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948967222
##########
kyuubi-server/web-ui/src/components.d.ts:
##########
@@ -0,0 +1,24 @@
+// generated by unplugin-vue-components
Review Comment:
No, I tried, I can try if I can hard code it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948663779
##########
kyuubi-server/web-ui/package.json:
##########
@@ -0,0 +1,50 @@
+{
+ "name": "kyuubi-ui",
+ "private": true,
+ "version": "1.6.0-SNAPSHOT",
+ "type": "module",
+ "scripts": {
+ "dev": "vite --port 8080",
+ "build": "vue-tsc --noEmit && vite build --mode production",
+ "build-check": "npm run lint && npm run build",
+ "preview": "vite preview",
+ "lint": "eslint --ext .ts,vue --ignore-path .gitignore .",
+ "lint-fix": "eslint --fix --ext .ts,vue --ignore-path .gitignore .",
+ "prettier": "prettier --write \"src/**/*.{vue,ts,tsx}\"",
+ "test": "vitest",
+ "coverage": "vitest run --coverage"
+ },
+ "dependencies": {
+ "@element-plus/icons-vue": "^2.0.9",
+ "axios": "^0.27.2",
+ "element-plus": "^2.2.12",
+ "pinia": "^2.0.18",
+ "pinia-plugin-persistedstate": "^2.1.1",
+ "vue": "^3.2.37",
+ "vue-i18n": "^9.2.2",
+ "vue-router": "^4.1.3"
Review Comment:
what if we use the exactly version instead of a "^" at the begining?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948660334
##########
kyuubi-server/web-ui/README.md:
##########
@@ -0,0 +1,39 @@
+# Kyuubi-ui
+
+### Start Using
+
+For the best experience, we recommend using `node 16.15.1` and `pnpm 7.9.0`.
+You can learn how to install the corresponding version from their official website.
+
+- [node](https://nodejs.org/en/)
+- [pnpm](https://pnpm.io/)
Review Comment:
I would rather recommend to use `npm` instead, lots of package management tools claims to replace npm but none of them done. If a developer prefer to use such tech, they should know how to use them even we only provide `npm` usage instructions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948660842
##########
kyuubi-server/web-ui/README.md:
##########
@@ -0,0 +1,39 @@
+# Kyuubi-ui
+
+### Start Using
+
+For the best experience, we recommend using `node 16.15.1` and `pnpm 7.9.0`.
Review Comment:
how about just point that "requires node 16" and "npm <major_version>"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r950664157
##########
kyuubi-server/web-ui/src/vite-env.d.ts:
##########
@@ -0,0 +1,11 @@
+/// <reference types="vite/client" />
Review Comment:
does it allows to add license header?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] tongwl commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
tongwl commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948964817
##########
kyuubi-server/web-ui/package.json:
##########
@@ -0,0 +1,50 @@
+{
+ "name": "kyuubi-ui",
+ "private": true,
+ "version": "1.6.0-SNAPSHOT",
+ "type": "module",
+ "scripts": {
+ "dev": "vite --port 8080",
+ "build": "vue-tsc --noEmit && vite build --mode production",
+ "build-check": "npm run lint && npm run build",
+ "preview": "vite preview",
+ "lint": "eslint --ext .ts,vue --ignore-path .gitignore .",
+ "lint-fix": "eslint --fix --ext .ts,vue --ignore-path .gitignore .",
+ "prettier": "prettier --write \"src/**/*.{vue,ts,tsx}\"",
+ "test": "vitest",
+ "coverage": "vitest run --coverage"
+ },
+ "dependencies": {
+ "@element-plus/icons-vue": "^2.0.9",
+ "axios": "^0.27.2",
+ "element-plus": "^2.2.12",
+ "pinia": "^2.0.18",
+ "pinia-plugin-persistedstate": "^2.1.1",
+ "vue": "^3.2.37",
+ "vue-i18n": "^9.2.2",
+ "vue-router": "^4.1.3"
Review Comment:
My understanding is that using a fixed version is very unprofessional behavior, package.json version has it's rules, such as ’*‘, '~', '^', '^' is a default behavior by we enter npm install vue-router. '^' has it's rules, for exampe "vue": "^3.2.37", if vue team update a new version to 3.2.40, the last number always means fix serveral bugs, so next time we build our project, our project will install 3.2.40. Also if vue team update to 3.3.0, the middle number means add some features / functions, our project also will install 3.3.0, but if vue team publush to 4.0.0, ^ will limit our project to install newest 3.X.X. But to keep save, I refer to the dol project, I also pull the package-lock.json to github, this file will keep only install the fixed version, package-lock.json is more installation and convenient than hard coding version....
Here is my learning of package.json, just a reference:
https://github.com/tongwl/front-end-knowledge/blob/main/node/%E5%85%B3%E4%BA%8Enpm%E7%9A%84package.json%EF%BC%8C%E4%BD%A0%E7%9F%A5%E9%81%93%E5%A4%9A%E5%B0%91%3F.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] tongwl commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
tongwl commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r949032461
##########
kyuubi-server/web-ui/package.json:
##########
@@ -0,0 +1,50 @@
+{
+ "name": "kyuubi-ui",
+ "private": true,
+ "version": "1.6.0-SNAPSHOT",
+ "type": "module",
+ "scripts": {
+ "dev": "vite --port 8080",
+ "build": "vue-tsc --noEmit && vite build --mode production",
+ "build-check": "npm run lint && npm run build",
+ "preview": "vite preview",
+ "lint": "eslint --ext .ts,vue --ignore-path .gitignore .",
+ "lint-fix": "eslint --fix --ext .ts,vue --ignore-path .gitignore .",
+ "prettier": "prettier --write \"src/**/*.{vue,ts,tsx}\"",
+ "test": "vitest",
+ "coverage": "vitest run --coverage"
+ },
+ "dependencies": {
+ "@element-plus/icons-vue": "^2.0.9",
+ "axios": "^0.27.2",
+ "element-plus": "^2.2.12",
+ "pinia": "^2.0.18",
+ "pinia-plugin-persistedstate": "^2.1.1",
+ "vue": "^3.2.37",
+ "vue-i18n": "^9.2.2",
+ "vue-router": "^4.1.3"
Review Comment:
Yes, you are right. 👍 While ensuring that the installation will not go wrong, we can update package-lock.json from time to time to ensure the update of our dependent plug-ins, as plug-ins also have bugs and new features, and the bugs of plug-ins can be repaired themselves, we can also enjoy the new features from the plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r949049003
##########
kyuubi-server/web-ui/package.json:
##########
@@ -0,0 +1,50 @@
+{
+ "name": "kyuubi-ui",
+ "private": true,
+ "version": "1.6.0-SNAPSHOT",
+ "type": "module",
+ "scripts": {
+ "dev": "vite --port 8080",
+ "build": "vue-tsc --noEmit && vite build --mode production",
+ "build-check": "npm run lint && npm run build",
+ "preview": "vite preview",
+ "lint": "eslint --ext .ts,vue --ignore-path .gitignore .",
+ "lint-fix": "eslint --fix --ext .ts,vue --ignore-path .gitignore .",
+ "prettier": "prettier --write \"src/**/*.{vue,ts,tsx}\"",
+ "test": "vitest",
+ "coverage": "vitest run --coverage"
+ },
+ "dependencies": {
+ "@element-plus/icons-vue": "^2.0.9",
+ "axios": "^0.27.2",
+ "element-plus": "^2.2.12",
+ "pinia": "^2.0.18",
+ "pinia-plugin-persistedstate": "^2.1.1",
+ "vue": "^3.2.37",
+ "vue-i18n": "^9.2.2",
+ "vue-router": "^4.1.3"
Review Comment:
The vision is ideal, but the fact is rude, the determinism is much much important for a project. Anyway, let's follow the community common practices to declare the dynamic version and pin dependency tree in `package-lock.json`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948661066
##########
kyuubi-server/web-ui/README.md:
##########
@@ -0,0 +1,39 @@
+# Kyuubi-ui
Review Comment:
Kyuubi Web UI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r949013785
##########
kyuubi-server/web-ui/package.json:
##########
@@ -0,0 +1,50 @@
+{
+ "name": "kyuubi-ui",
+ "private": true,
+ "version": "1.6.0-SNAPSHOT",
+ "type": "module",
+ "scripts": {
+ "dev": "vite --port 8080",
+ "build": "vue-tsc --noEmit && vite build --mode production",
+ "build-check": "npm run lint && npm run build",
+ "preview": "vite preview",
+ "lint": "eslint --ext .ts,vue --ignore-path .gitignore .",
+ "lint-fix": "eslint --fix --ext .ts,vue --ignore-path .gitignore .",
+ "prettier": "prettier --write \"src/**/*.{vue,ts,tsx}\"",
+ "test": "vitest",
+ "coverage": "vitest run --coverage"
+ },
+ "dependencies": {
+ "@element-plus/icons-vue": "^2.0.9",
+ "axios": "^0.27.2",
+ "element-plus": "^2.2.12",
+ "pinia": "^2.0.18",
+ "pinia-plugin-persistedstate": "^2.1.1",
+ "vue": "^3.2.37",
+ "vue-i18n": "^9.2.2",
+ "vue-router": "^4.1.3"
Review Comment:
I've heard about those things. It recommends using dynamic versions to benefit patches applied automatically, but this causes the dependency tree to become indeterminate, then it recommends using `package.lock.json` to pin versions to restore determinism.
Sounds like it creates a problem first, then create a new tool to solve the problem...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r949049003
##########
kyuubi-server/web-ui/package.json:
##########
@@ -0,0 +1,50 @@
+{
+ "name": "kyuubi-ui",
+ "private": true,
+ "version": "1.6.0-SNAPSHOT",
+ "type": "module",
+ "scripts": {
+ "dev": "vite --port 8080",
+ "build": "vue-tsc --noEmit && vite build --mode production",
+ "build-check": "npm run lint && npm run build",
+ "preview": "vite preview",
+ "lint": "eslint --ext .ts,vue --ignore-path .gitignore .",
+ "lint-fix": "eslint --fix --ext .ts,vue --ignore-path .gitignore .",
+ "prettier": "prettier --write \"src/**/*.{vue,ts,tsx}\"",
+ "test": "vitest",
+ "coverage": "vitest run --coverage"
+ },
+ "dependencies": {
+ "@element-plus/icons-vue": "^2.0.9",
+ "axios": "^0.27.2",
+ "element-plus": "^2.2.12",
+ "pinia": "^2.0.18",
+ "pinia-plugin-persistedstate": "^2.1.1",
+ "vue": "^3.2.37",
+ "vue-i18n": "^9.2.2",
+ "vue-router": "^4.1.3"
Review Comment:
The vision is ideal, but the fact is cruel, the determinism is much much important for a project. Anyway, let's follow the community common practices to declare the dynamic version and pin dependency tree in `package-lock.json`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948662747
##########
kyuubi-server/web-ui/.gitignore:
##########
@@ -0,0 +1,38 @@
+ # Licensed to the Apache Software Foundation (ASF) under one or more
+ # contributor license agreements. See the NOTICE file distributed with
+ # this work for additional information regarding copyright ownership.
+ # The ASF licenses this file to You under the Apache License, Version 2.0
+ # (the "License"); you may not use this file except in compliance with
+ # the License. You may obtain a copy of the License at
+ #
+ # http://www.apache.org/licenses/LICENSE-2.0
+ #
+ # Unless required by applicable law or agreed to in writing, software
+ # distributed under the License is distributed on an "AS IS" BASIS,
+ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ # See the License for the specific language governing permissions and
+ # limitations under the License.
+
+.DS_Store
+node_modules
+/dist
+/coverage
+
+# local env files
+.env.local
+.env.*.local
+
+# Log files
+npm-debug.log*
+yarn-debug.log*
+yarn-error.log*
+pnpm-debug.log*
Review Comment:
could we merge them into `*.log*` ?, BTW, why the later `*` is required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948664161
##########
kyuubi-server/web-ui/src/App.vue:
##########
@@ -0,0 +1,20 @@
+/* * Licensed to the Apache Software Foundation (ASF) under one or more *
+contributor license agreements. See the NOTICE file distributed with * this work
+for additional information regarding copyright ownership. * The ASF licenses
+this file to You under the Apache License, Version 2.0 * (the "License"); you
+may not use this file except in compliance with * the License. You may obtain a
+copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless
+required by applicable law or agreed to in writing, software * distributed under
+the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR
+CONDITIONS OF ANY KIND, either express or implied. * See the License for the
+specific language governing permissions and * limitations under the License. */
Review Comment:
this licence header is broken
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] tongwl commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
tongwl commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r949041096
##########
kyuubi-server/web-ui/src/App.vue:
##########
@@ -0,0 +1,20 @@
+/* * Licensed to the Apache Software Foundation (ASF) under one or more *
+contributor license agreements. See the NOTICE file distributed with * this work
+for additional information regarding copyright ownership. * The ASF licenses
+this file to You under the Apache License, Version 2.0 * (the "License"); you
+may not use this file except in compliance with * the License. You may obtain a
+copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless
+required by applicable law or agreed to in writing, software * distributed under
+the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR
+CONDITIONS OF ANY KIND, either express or implied. * See the License for the
+specific language governing permissions and * limitations under the License. */
Review Comment:
yes, nice example. Vue support <!-- --> and \/* *\/ as comment format, <!-- --> will not formatted by eslint, will change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r950664070
##########
kyuubi-server/web-ui/src/auto-imports.d.ts:
##########
@@ -0,0 +1,3 @@
+// Generated by 'unplugin-auto-import'
Review Comment:
I guess this one could be removed since we are using full import mode now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r950664083
##########
kyuubi-server/web-ui/src/components.d.ts:
##########
@@ -0,0 +1,24 @@
+// generated by unplugin-vue-components
Review Comment:
ditto, could it be removed now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948669104
##########
kyuubi-server/web-ui/README.md:
##########
@@ -0,0 +1,39 @@
+# Kyuubi-ui
+
+### Start Using
+
+For the best experience, we recommend using `node 16.15.1` and `pnpm 7.9.0`.
+You can learn how to install the corresponding version from their official website.
+
+- [node](https://nodejs.org/en/)
+- [pnpm](https://pnpm.io/)
+
+### Install Dependencies
+
+```shell
+pnpm install
+```
+
+### Development Project
+
+To do this you can change the VITE_APP_DEV_WEB_URL parameter variable as the service url in .env.development in the project root directory, such as http://127.0. 0.1:8090
+
+
+```shell
+pnpm dev
+```
+
+### Build Project
+
+```shell
+pnpm run build
+```
+
+### Code Format
+
+Usually after you modify the code, you need to perform code formatting operations to ensure that the code in the project is the same style.
+
+```shell
+pnpm run prettier
Review Comment:
we provided a shell script `dev/reformat` for same purpose on backend codes. would you like to merge it into `dev/reformat` or provide another one at `kyuubi-server/web-ui/reformat` or in some place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] tongwl commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
tongwl commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948969841
##########
kyuubi-server/web-ui/tsconfig.json:
##########
@@ -0,0 +1,19 @@
+{
Review Comment:
Oh, really? could you show me how to add? As I researched and find nothing, also checked other repos, but their json also has no comments...
##########
kyuubi-server/web-ui/tsconfig.json:
##########
@@ -0,0 +1,19 @@
+{
Review Comment:
Oh, really? could you show me how to add? As I researched and found nothing, also checked other repos, but their json also has no comments...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] Yikf commented on pull request #3250: Init frontend framework
Posted by "Yikf (via GitHub)" <gi...@apache.org>.
Yikf commented on PR #3250:
URL: https://github.com/apache/kyuubi/pull/3250#issuecomment-1408186966
Hi @tongwl @pan3793 , Any documentation/issue/discussion/Prototype drawing for this change? I want to see what the purpose/function of the UI is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r950664172
##########
kyuubi-server/web-ui/src/main.ts:
##########
@@ -0,0 +1,15 @@
+import { createApp } from 'vue'
Review Comment:
license header
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948666361
##########
kyuubi-server/web-ui/src/views/operation/runningJobs/index.vue:
##########
@@ -0,0 +1,22 @@
+/* * Licensed to the Apache Software Foundation (ASF) under one or more *
+contributor license agreements. See the NOTICE file distributed with * this work
+for additional information regarding copyright ownership. * The ASF licenses
+this file to You under the Apache License, Version 2.0 * (the "License"); you
+may not use this file except in compliance with * the License. You may obtain a
+copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless
+required by applicable law or agreed to in writing, software * distributed under
+the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR
+CONDITIONS OF ANY KIND, either express or implied. * See the License for the
+specific language governing permissions and * limitations under the License. */
Review Comment:
seems all of the `*.vue` files have same issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948954480
##########
kyuubi-server/web-ui/.gitignore:
##########
@@ -0,0 +1,38 @@
+ # Licensed to the Apache Software Foundation (ASF) under one or more
+ # contributor license agreements. See the NOTICE file distributed with
+ # this work for additional information regarding copyright ownership.
+ # The ASF licenses this file to You under the Apache License, Version 2.0
+ # (the "License"); you may not use this file except in compliance with
+ # the License. You may obtain a copy of the License at
+ #
+ # http://www.apache.org/licenses/LICENSE-2.0
+ #
+ # Unless required by applicable law or agreed to in writing, software
+ # distributed under the License is distributed on an "AS IS" BASIS,
+ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ # See the License for the specific language governing permissions and
+ # limitations under the License.
+
+.DS_Store
+node_modules
+/dist
+/coverage
+
+# local env files
+.env.local
+.env.*.local
+
+# Log files
+npm-debug.log*
+yarn-debug.log*
+yarn-error.log*
+pnpm-debug.log*
Review Comment:
thanks for explanation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r949002691
##########
kyuubi-server/web-ui/tsconfig.json:
##########
@@ -0,0 +1,19 @@
+{
Review Comment:
https://github.com/apache/skywalking-booster-ui/blob/main/tsconfig.json
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r949013785
##########
kyuubi-server/web-ui/package.json:
##########
@@ -0,0 +1,50 @@
+{
+ "name": "kyuubi-ui",
+ "private": true,
+ "version": "1.6.0-SNAPSHOT",
+ "type": "module",
+ "scripts": {
+ "dev": "vite --port 8080",
+ "build": "vue-tsc --noEmit && vite build --mode production",
+ "build-check": "npm run lint && npm run build",
+ "preview": "vite preview",
+ "lint": "eslint --ext .ts,vue --ignore-path .gitignore .",
+ "lint-fix": "eslint --fix --ext .ts,vue --ignore-path .gitignore .",
+ "prettier": "prettier --write \"src/**/*.{vue,ts,tsx}\"",
+ "test": "vitest",
+ "coverage": "vitest run --coverage"
+ },
+ "dependencies": {
+ "@element-plus/icons-vue": "^2.0.9",
+ "axios": "^0.27.2",
+ "element-plus": "^2.2.12",
+ "pinia": "^2.0.18",
+ "pinia-plugin-persistedstate": "^2.1.1",
+ "vue": "^3.2.37",
+ "vue-i18n": "^9.2.2",
+ "vue-router": "^4.1.3"
Review Comment:
I've heard about those things. It recommends using dynamic versions to benefit patches applied automatically, but this causes the dependency tree to become indeterminate, then it recommends using `package-lock.json` to pin versions to restore determinism.
Sounds like it creates a problem first, then create a new tool to solve the problem...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 closed pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #3250: Init frontend framework
URL: https://github.com/apache/incubator-kyuubi/pull/3250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948664778
##########
kyuubi-server/web-ui/src/components.d.ts:
##########
@@ -0,0 +1,24 @@
+// generated by unplugin-vue-components
Review Comment:
can we add license header on this file as well? or if it's auto generate by build command, we can exclude it from git
##########
kyuubi-server/web-ui/src/components/card/index.vue:
##########
@@ -0,0 +1,45 @@
+/* * Licensed to the Apache Software Foundation (ASF) under one or more *
+contributor license agreements. See the NOTICE file distributed with * this work
+for additional information regarding copyright ownership. * The ASF licenses
+this file to You under the Apache License, Version 2.0 * (the "License"); you
+may not use this file except in compliance with * the License. You may obtain a
+copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless
+required by applicable law or agreed to in writing, software * distributed under
+the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR
+CONDITIONS OF ANY KIND, either express or implied. * See the License for the
+specific language governing permissions and * limitations under the License. */
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948667411
##########
kyuubi-server/web-ui/tsconfig.json:
##########
@@ -0,0 +1,19 @@
+{
Review Comment:
does this file allow to add header as well? I know there are some json library extend the JSON standard to support comment syntax.
##########
kyuubi-server/web-ui/tsconfig.json:
##########
@@ -0,0 +1,19 @@
+{
Review Comment:
does this file allow to add header as well? I know there are some json libraries extend the JSON standard to support comment syntax.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] tongwl commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
tongwl commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948950158
##########
kyuubi-server/web-ui/.gitignore:
##########
@@ -0,0 +1,38 @@
+ # Licensed to the Apache Software Foundation (ASF) under one or more
+ # contributor license agreements. See the NOTICE file distributed with
+ # this work for additional information regarding copyright ownership.
+ # The ASF licenses this file to You under the Apache License, Version 2.0
+ # (the "License"); you may not use this file except in compliance with
+ # the License. You may obtain a copy of the License at
+ #
+ # http://www.apache.org/licenses/LICENSE-2.0
+ #
+ # Unless required by applicable law or agreed to in writing, software
+ # distributed under the License is distributed on an "AS IS" BASIS,
+ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ # See the License for the specific language governing permissions and
+ # limitations under the License.
+
+.DS_Store
+node_modules
+/dist
+/coverage
+
+# local env files
+.env.local
+.env.*.local
+
+# Log files
+npm-debug.log*
+yarn-debug.log*
+yarn-error.log*
+pnpm-debug.log*
Review Comment:
:) didn't look into it, it's generated by vite automatically, just guess it's the rules of npm/yarn/...'s log file name, but I know here is required, as someone may use node 10 to install our project, it is possible to generate logs for users to check errors, but these logs do not need to be uploaded to github
##########
kyuubi-server/web-ui/package.json:
##########
@@ -0,0 +1,50 @@
+{
+ "name": "kyuubi-ui",
+ "private": true,
+ "version": "1.6.0-SNAPSHOT",
+ "type": "module",
+ "scripts": {
+ "dev": "vite --port 8080",
Review Comment:
sure~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948952797
##########
kyuubi-server/web-ui/README.md:
##########
@@ -0,0 +1,39 @@
+# Kyuubi-ui
+
+### Start Using
+
+For the best experience, we recommend using `node 16.15.1` and `pnpm 7.9.0`.
+You can learn how to install the corresponding version from their official website.
+
+- [node](https://nodejs.org/en/)
+- [pnpm](https://pnpm.io/)
Review Comment:
yarn claims to provide better performance and developer experience as well, I respect your preference of pnpm, if you prefer, we can keep it and mark as recommanded but it's optional, can we doucment how to setup using npm as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] tongwl commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
tongwl commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r948966220
##########
kyuubi-server/web-ui/src/App.vue:
##########
@@ -0,0 +1,20 @@
+/* * Licensed to the Apache Software Foundation (ASF) under one or more *
+contributor license agreements. See the NOTICE file distributed with * this work
+for additional information regarding copyright ownership. * The ASF licenses
+this file to You under the Apache License, Version 2.0 * (the "License"); you
+may not use this file except in compliance with * the License. You may obtain a
+copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless
+required by applicable law or agreed to in writing, software * distributed under
+the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR
+CONDITIONS OF ANY KIND, either express or implied. * See the License for the
+specific language governing permissions and * limitations under the License. */
Review Comment:
emmm.. It's caused by prettier / eslint, I am not sure if it's broken...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r949003575
##########
kyuubi-server/web-ui/src/App.vue:
##########
@@ -0,0 +1,20 @@
+/* * Licensed to the Apache Software Foundation (ASF) under one or more *
+contributor license agreements. See the NOTICE file distributed with * this work
+for additional information regarding copyright ownership. * The ASF licenses
+this file to You under the Apache License, Version 2.0 * (the "License"); you
+may not use this file except in compliance with * the License. You may obtain a
+copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless
+required by applicable law or agreed to in writing, software * distributed under
+the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR
+CONDITIONS OF ANY KIND, either express or implied. * See the License for the
+specific language governing permissions and * limitations under the License. */
Review Comment:
I found a positive example.
https://github.com/apache/skywalking-booster-ui/blob/main/src/App.vue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] tongwl commented on a diff in pull request #3250: Init frontend framework
Posted by GitBox <gi...@apache.org>.
tongwl commented on code in PR #3250:
URL: https://github.com/apache/incubator-kyuubi/pull/3250#discussion_r949041096
##########
kyuubi-server/web-ui/src/App.vue:
##########
@@ -0,0 +1,20 @@
+/* * Licensed to the Apache Software Foundation (ASF) under one or more *
+contributor license agreements. See the NOTICE file distributed with * this work
+for additional information regarding copyright ownership. * The ASF licenses
+this file to You under the Apache License, Version 2.0 * (the "License"); you
+may not use this file except in compliance with * the License. You may obtain a
+copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless
+required by applicable law or agreed to in writing, software * distributed under
+the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR
+CONDITIONS OF ANY KIND, either express or implied. * See the License for the
+specific language governing permissions and * limitations under the License. */
Review Comment:
yes, nice example. Vue support <!-- --> and /* */ as comment format, <!-- --> will not formatted by eslint, will change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org