You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/10/01 07:08:55 UTC

[GitHub] [apisix-ingress-controller] tao12345666333 opened a new pull request #702: fix: CRD v1 preserve unknown fields

tao12345666333 opened a new pull request #702:
URL: https://github.com/apache/apisix-ingress-controller/pull/702


   Signed-off-by: Jintao Zhang <zh...@gmail.com>
   
   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [x] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   - Related issues
   
   ___
   ### Bugfix
   - Description
   
   fix: CRD v1 preserve unknown fields
   
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   
   ___
   ### Backport patches
   - Why need to backport?
   
   - Source branch
   
   - Related commits and pull requests
   
   - Target branch
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #702: fix: CRD v1 preserve unknown fields

Posted by GitBox <gi...@apache.org>.
tao12345666333 merged pull request #702:
URL: https://github.com/apache/apisix-ingress-controller/pull/702


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #702: fix: CRD v1 preserve unknown fields

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #702:
URL: https://github.com/apache/apisix-ingress-controller/pull/702#issuecomment-932325628


   #698 is ready, it already contains this change.
   
   I suggest to merge it directly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #702: fix: CRD v1 preserve unknown fields

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #702:
URL: https://github.com/apache/apisix-ingress-controller/pull/702#issuecomment-932196114


   @moonming  Got it! Since this is a serious bug and many people are on vacation, I hope someone else can help review and quickly complete this fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #702: fix: CRD v1 preserve unknown fields

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #702:
URL: https://github.com/apache/apisix-ingress-controller/pull/702#issuecomment-932036151


   Wait for review @apache/apisix-committers  PTAL!
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] moonming commented on pull request #702: fix: CRD v1 preserve unknown fields

Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #702:
URL: https://github.com/apache/apisix-ingress-controller/pull/702#issuecomment-932191700


   @tao12345666333 please do not ping a group of committer. Someone once pinged all the committers of the Apache Foundation by mistake


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org