You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/22 14:35:14 UTC
[GitHub] [airflow] ashwin153 opened a new issue #16591: Support for Jinja2 3.x
ashwin153 opened a new issue #16591:
URL: https://github.com/apache/airflow/issues/16591
**Description**
Currently, Jinja2 is required to be < 2.12.0.
https://github.com/apache/airflow/blob/7af18ac856b470f91e75d419f27e78bc2a0b215b/setup.cfg#L116
**Use case / motivation**
This causes some build issues in my monorepo, because other libraries depend on Jinja2 3.x but Airflow does not yet support it. I stepped through the git blame, and it doesn't seem like there's a specific reason why Jinja2 3.x is not supported; the upper-bound appears to be there for stability and not incompatibility reasons.
**Are you willing to submit a PR?**
I would be happy to submit a PR, but I would need some guidance on how to test this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #16591: Support for Jinja2 3.x
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #16591:
URL: https://github.com/apache/airflow/issues/16591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #16591: Support for Jinja2 3.x
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #16591:
URL: https://github.com/apache/airflow/issues/16591#issuecomment-866041264
Maybe you can just try it. We run a lot of tests which are using Jinja internally so I think it will be enough to have "Green" PR :).
The only thing you need is to make a PR with limitation for Jinja removed in setup.py/cfg. It will automatically bump Jinja to latest non-conflicting version and run all the tests. If it gets green and other committers will be OK with that we can then merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #16591: Support for Jinja2 3.x
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #16591:
URL: https://github.com/apache/airflow/issues/16591#issuecomment-866038537
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org