You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2018/08/06 20:49:31 UTC
Re: Review Request 67502: Refactored ReviewBoard API functionality
into separate module.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67502/#review206908
-----------------------------------------------------------
support/python3/common.py
Lines 146 (patched)
<https://reviews.apache.org/r/67502/#comment290034>
Pylint complains that there are too many local variables, you can remove `latest_diff_url` to have only 15 vars in the file.
- Armand Grillet
On July 19, 2018, 3:48 p.m., Dragos Schebesch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67502/
> -----------------------------------------------------------
>
> (Updated July 19, 2018, 3:48 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Refactored API functionality into separate module -- this was done to clean up the codebase and put all API calls in single place.
>
>
> Diffs
> -----
>
> support/python3/common.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/67502/diff/4/
>
>
> Testing
> -------
>
> For example, to call the api on a specific review_url, with some data, we would use the following code:
>
> ```
> ReviewBoardHandler().api(review_url, data)
> ```
>
>
> Thanks,
>
> Dragos Schebesch
>
>