[GitHub] [sling-org-apache-sling-scripting-core] paul-bjorkstrand commented on issue #3: SLING-8425 - Fix NPE on GraalVM

[GitBox <gi...@apache.org>]

paul-bjorkstrand commented on issue #3: SLING-8425 - Fix NPE on GraalVM
URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/3#issuecomment-494458462
 
 
   @kwin or @raducotescu , I have a question about the test that failed on the CI server. The test  [SlingScriptEngineManagerTest.testOSGiRegisteredFactoriesDifferentServiceRanking](/apache/sling-org-apache-sling-scripting-core/blob/master/src/test/java/org/apache/sling/scripting/core/impl/jsr223/SlingScriptEngineManagerTest.java#L82) seems to be somewhat non-deterministic.
   
   When I was fixing the issue this ticket addresses, this test would fail occasionally, while I was making changes. I even got to the point where I changed the expected value several times until it started working. I assumed that it was because I made a typo and kept making the same mistake over and over (anyone ever code late at night? ;-) ).
   
   Seeing it fail here, but succeed on my local leads me to believe that the test is not quite correct (and in fact I was not crazy). Do you have any suggestions as to how to fix this test to be deterministic?
   
   Failed CI Build: https://builds.apache.org/blue/organizations/jenkins/Sling%2Fsling-org-apache-sling-scripting-core/detail/PR-3/1/

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services