[jira] [Updated] (MESOS-5331) Some cleanup in filesystem_isolator_tests.cpp

["Guangya Liu (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MESOS-5331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guangya Liu updated MESOS-5331:
-------------------------------
    Description: 
There are some issues in {{filesystem_isolator_tests.cpp}} and need some clean up to make sure when we want to make a reference to this file, we can get the right coding style.

The issues are as following:

1) The filesystem_isolator_tests.cpp was already wrapped in OS_LINUX in the makefile, there is no need to define the "__linux__" marco anymore for this test.
2) Some unused variables, such as {{containerId}} and {{slaveId}}
3) We should avoid using 'using namespace' but include them explicitly.
4) Update indent for some functions.
5) Replace ".get().xxx" with "->xxx".

The file of {{runtime_isolator_tests.cpp}} should also have the {{__linux__}} removed as this file was also wrapped in OS_LINUX in the makefile.

  was:
There are some issues in {{filesystem_isolator_tests.cpp}} and need some clean up to make sure when we want to make a reference to this file, we can get the right coding style.

The issues are as following:

1) The filesystem_isolator_tests.cpp was already wrapped in OS_LINUX in the makefile, there is no need to define the "__linux__" marco anymore for this test.
2) Some unused variables, such as {{containerId}} and {{slaveId}}
3) We should avoid using 'using namespace' but include them explicitly.
4) Update indent for some functions.
5) Replace ".get().xxx" with "->xxx".


> Some cleanup in filesystem_isolator_tests.cpp
> ---------------------------------------------
>
>                 Key: MESOS-5331
>                 URL: https://issues.apache.org/jira/browse/MESOS-5331
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Guangya Liu
>            Assignee: Guangya Liu
>
> There are some issues in {{filesystem_isolator_tests.cpp}} and need some clean up to make sure when we want to make a reference to this file, we can get the right coding style.
> The issues are as following:
> 1) The filesystem_isolator_tests.cpp was already wrapped in OS_LINUX in the makefile, there is no need to define the "__linux__" marco anymore for this test.
> 2) Some unused variables, such as {{containerId}} and {{slaveId}}
> 3) We should avoid using 'using namespace' but include them explicitly.
> 4) Update indent for some functions.
> 5) Replace ".get().xxx" with "->xxx".
> The file of {{runtime_isolator_tests.cpp}} should also have the {{__linux__}} removed as this file was also wrapped in OS_LINUX in the makefile.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)