[jira] [Commented] (AIRFLOW-3852) `airflow worker` fails

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763845#comment-16763845 ] 

ASF GitHub Bot commented on AIRFLOW-3852:
-----------------------------------------

ttanay commented on pull request #4674: [AIRFLOW-3852] Add support for fallback in AirflowConfigParser.getboolean
URL: https://github.com/apache/airflow/pull/4674
 
 
   Support for a fallback kwarg was added in `AirflowConfigParser.get`
   in [AIRFLOW-3742], but, `AirflowConfigParser.getboolean` also needs
   to support it.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3852
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [X] Here are some details about my PR, including screenshots of any UI changes:
   
   On the latest master, when I ran `airflow worker`, I got the following error:
   ```
   [2019-02-09 00:12:25,983] {__init__.py:51} INFO - Using executor SequentialExecutor
   Traceback (most recent call last):
   File "/home/tanay/Coding/airflow/.env/bin/airflow", line 6, in <module>
   exec(compile(open(__file__).read(), __file__, 'exec'))
   File "/home/tanay/Coding/airflow/airflow/bin/airflow", line 32, in <module>
   args.func(args)
   File "/home/tanay/Coding/airflow/airflow/utils/cli.py", line 74, in wrapper
   return f(*args, **kwargs)
   File "/home/tanay/Coding/airflow/airflow/bin/cli.py", line 1058, in worker
   if not settings.validate_session():
   File "/home/tanay/Coding/airflow/airflow/settings.py", line 226, in validate_session
   worker_precheck = conf.getboolean('core', 'worker_precheck', fallback=False)
   TypeError: getboolean() got an unexpected keyword argument 'fallback'
   ```
   Support for a `fallback` kwarg in `AirflowConfigParser.get` was added by @ashb in https://github.com/apache/airflow/pull/4567.
   Support for it also needs to be in `AirflowConfigParser.getboolean`.
   
   
   ### Tests
   
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Not Needed.
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [X] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> `airflow worker` fails
> ----------------------
>
>                 Key: AIRFLOW-3852
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3852
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: cli
>    Affects Versions: 2.0.0
>         Environment: Python 3.6
>            Reporter: Tanay Tummalapalli
>            Assignee: Tanay Tummalapalli
>            Priority: Major
>
> When running `airflow worker`, I get the following exception:
>  
> {code:java}
> [2019-02-09 00:12:25,983] {__init__.py:51} INFO - Using executor SequentialExecutor
> Traceback (most recent call last):
> File "/home/tanay/Coding/airflow/.env/bin/airflow", line 6, in <module>
> exec(compile(open(__file__).read(), __file__, 'exec'))
> File "/home/tanay/Coding/airflow/airflow/bin/airflow", line 32, in <module>
> args.func(args)
> File "/home/tanay/Coding/airflow/airflow/utils/cli.py", line 74, in wrapper
> return f(*args, **kwargs)
> File "/home/tanay/Coding/airflow/airflow/bin/cli.py", line 1058, in worker
> if not settings.validate_session():
> File "/home/tanay/Coding/airflow/airflow/settings.py", line 226, in validate_session
> worker_precheck = conf.getboolean('core', 'worker_precheck', fallback=False)
> TypeError: getboolean() got an unexpected keyword argument 'fallback'
> {code}
>  
> Caused by:
> [https://github.com/apache/airflow/commit/0d64fd8aac7b93f4143d8f1d3baa4a0e239aba55]
> Related Jira issue: https://issues.apache.org/jira/projects/AIRFLOW/issues/AIRFLOW-3742?filter=allissues
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)