You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/11/16 16:13:08 UTC
[GitHub] [pulsar] crossoverJie opened a new pull request, #18505: [refactor][broker] Optimize semantics
crossoverJie opened a new pull request, #18505:
URL: https://github.com/apache/pulsar/pull/18505
### Motivation
Make the code easier to read
### Modifications
`!isPresent()` -> `isEmpty()`
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
### Does this pull request potentially affect one of the following parts:
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] crossoverJie commented on pull request #18505: [refactor][broker] Optimize semantics
Posted by GitBox <gi...@apache.org>.
crossoverJie commented on PR #18505:
URL: https://github.com/apache/pulsar/pull/18505#issuecomment-1318021736
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] crossoverJie commented on pull request #18505: [refactor][broker] Optimize semantics
Posted by GitBox <gi...@apache.org>.
crossoverJie commented on PR #18505:
URL: https://github.com/apache/pulsar/pull/18505#issuecomment-1318037562
> @crossoverJie Please follow the instructions in https://github.com/apache/pulsar/actions/runs/3481081589/attempts/1#summary-9529786678 .
Done, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] crossoverJie commented on pull request #18505: [refactor][broker] Optimize semantics
Posted by GitBox <gi...@apache.org>.
crossoverJie commented on PR #18505:
URL: https://github.com/apache/pulsar/pull/18505#issuecomment-1318021309
PR in forked repository: https://github.com/crossoverJie/pulsar/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #18505: [refactor][broker] Optimize semantics
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #18505:
URL: https://github.com/apache/pulsar/pull/18505#issuecomment-1317515571
@crossoverJie Please follow the instructions in https://github.com/apache/pulsar/actions/runs/3481081589/attempts/1#summary-9529786678 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] crossoverJie commented on pull request #18505: [refactor][broker] Optimize semantics
Posted by GitBox <gi...@apache.org>.
crossoverJie commented on PR #18505:
URL: https://github.com/apache/pulsar/pull/18505#issuecomment-1319823649
@tisonkun PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #18505: [refactor][broker] Optimize semantics
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #18505:
URL: https://github.com/apache/pulsar/pull/18505#issuecomment-1319945012
If you do have ideas on promoting a code style rule for Apache Pulsar, I suggest:
1. either add a checkstyle rule or integrate with other code style automation;
2. or make a proposal on soft code style rule by:
1. Read the Coding Guide: https://pulsar.apache.org/coding-guide/
2. Try to integrate it into the Contribution Guide's Development section: https://pulsar.apache.org/contribute/category/development
3. Discuss and vote on the dev@ mailing list.
Here are how other communities/projects do it:
* Trino: https://github.com/airlift/codestyle
* TiDB: https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/code-style-and-quality-guide.html
* Kubernetes: https://www.kubernetes.dev/docs/guide/coding-convention/
The primary rule here is: such changes must be converged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] crossoverJie commented on pull request #18505: [refactor][broker] Optimize semantics
Posted by GitBox <gi...@apache.org>.
crossoverJie commented on PR #18505:
URL: https://github.com/apache/pulsar/pull/18505#issuecomment-1318467089
@rober
PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun closed pull request #18505: [refactor][broker] Optimize semantics
Posted by GitBox <gi...@apache.org>.
tisonkun closed pull request #18505: [refactor][broker] Optimize semantics
URL: https://github.com/apache/pulsar/pull/18505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RobertIndie commented on pull request #18505: [refactor][broker] Optimize semantics
Posted by GitBox <gi...@apache.org>.
RobertIndie commented on PR #18505:
URL: https://github.com/apache/pulsar/pull/18505#issuecomment-1318140756
@crossoverJie Seems that you haven't enabled the GitHub action in your repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org