Re: svn commit: r719433 - in /hadoop/hbase/trunk: CHANGES.txt src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java

[stack <st...@duboce.net>]

jimk@apache.org wrote:
> ...
>        // Now ask master what it wants us to do and tell it what we have done
>        for (int tries = 0; !stopRequested.get() && isHealthy();) {
> -        // Try to get the root region location from the master. 
> -        if (!haveRootRegion.get()) {
> +        // Try to get the root region location from the master.
>            HServerAddress rootServer = hbaseMaster.getRootRegionLocation();

Every time we want to send the regionserver heartbeat, we first ask for 
the location of the root region?  No caching of the root region and we 
now do two trips to the master on every heartbeat?  Am I reading this right?
St.Ack

RE: svn commit: r719433 - in /hadoop/hbase/trunk: CHANGES.txt src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java

["Jim Kellerman (POWERSET)" <Ji...@microsoft.com>]

Yeah, it's broken.

---
Jim Kellerman, Powerset (Live Search, Microsoft Corporation)


> -----Original Message-----
> From: stack [mailto:stack@duboce.net]
> Sent: Thursday, November 20, 2008 4:49 PM
> To: hbase-dev@hadoop.apache.org
> Subject: Re: svn commit: r719433 - in /hadoop/hbase/trunk: CHANGES.txt
> src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
>
> jimk@apache.org wrote:
> > ...
> >        // Now ask master what it wants us to do and tell it what we have
> done
> >        for (int tries = 0; !stopRequested.get() && isHealthy();) {
> > -        // Try to get the root region location from the master.
> > -        if (!haveRootRegion.get()) {
> > +        // Try to get the root region location from the master.
> >            HServerAddress rootServer =
> hbaseMaster.getRootRegionLocation();
>
> Every time we want to send the regionserver heartbeat, we first ask for
> the location of the root region?  No caching of the root region and we
> now do two trips to the master on every heartbeat?  Am I reading this
> right?
> St.Ack