[GitHub] spark pull request: [SPARK-14639][PYTHON][R] Add `bround` function...

[felixcheung <gi...@git.apache.org>]

Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12509#discussion_r60333723
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -1008,6 +1008,24 @@ setMethod("round",
                 column(jc)
               })
     
    +#' bround
    +#'
    +#' Returns the value of the column `e` rounded to `scale` decimal places using HALF_EVEN rounding
    +#' mode if `scale` >= 0 or at integral part when `scale` < 0.
    +#'
    +#' @rdname bround
    +#' @name bround
    +#' @family math_funcs
    +#' @export
    +#' @examples \dontrun{bround(df$c, 0)}
    +setMethod("bround",
    +          signature(x = "Column", scale = "numeric"),
    --- End diff --
    
    should scale be default to 0 to be consistent with Python?
    to do that, do
    ```
               signature(x = "Column"),
               function(x, scale = 0),
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org