You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "minnguyen27 (via GitHub)" <gi...@apache.org> on 2026/10/15 03:00:28 UTC
[PR] JAME-4236 EmailSubmission/set reject an unknown or missing identityId [james-project]
minnguyen27 opened a new pull request, #3252:
URL: https://github.com/apache/james-project/pull/3252
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-4236 EmailSubmission/set reject an unknown identityId [james-project]
Posted by "minnguyen27 (via GitHub)" <gi...@apache.org>.
minnguyen27 commented on code in PR #3252:
URL: https://github.com/apache/james-project/pull/3252#discussion_r4310291002
##########
third-party/spamassassin/src/test/java/org/apache/james/spamassassin/SpamAssassinContract.java:
##########
@@ -455,6 +455,7 @@ default void bobSendSpamEmailToAlice(UserCredential bobCredential) {
" \"accountId\": \"" + bobCredential.accountId() + "\"," +
" \"create\": {" +
" \"k1490\": {" +
+ " \"identityId\": \"" + bobCredential.identityId() + "\"," +
Review Comment:
Thank you both for noticing this. I changed it so that a missing `identityId` is accepted again, as before. An `identityId` that is unknown, invalid, or belongs to another user is still rejected with `invalidProperties`
i has opened a follow-up issue (https://github.com/linagora/tmail-flutter/issues/5003) for Flutter FE to fix the case where no custom identity exists; the composer falls back to a server-set identity (`mayDelete: false`) for sending, and sends its ID as `identityId`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-4236 EmailSubmission/set reject an unknown or missing identityId [james-project]
Posted by "quantranhong1999 (via GitHub)" <gi...@apache.org>.
quantranhong1999 commented on code in PR #3252:
URL: https://github.com/apache/james-project/pull/3252#discussion_r4310173182
##########
third-party/spamassassin/src/test/java/org/apache/james/spamassassin/SpamAssassinContract.java:
##########
@@ -455,6 +455,7 @@ default void bobSendSpamEmailToAlice(UserCredential bobCredential) {
" \"accountId\": \"" + bobCredential.accountId() + "\"," +
" \"create\": {" +
" \"k1490\": {" +
+ " \"identityId\": \"" + bobCredential.identityId() + "\"," +
Review Comment:
Suggestion for the PR: keep rejecting unknown ids and ids that belong to another user, since Flutter never sends those. Keep accepting a missing identityId until Flutter always sends one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAME-4236 EmailSubmission/set reject an unknown or missing identityId [james-project]
Posted by "minnguyen27 (via GitHub)" <gi...@apache.org>.
minnguyen27 commented on PR #3252:
URL: https://github.com/apache/james-project/pull/3252#issuecomment-6186593750
> Looks good to me. Thanks.
>
> Ps: I did not receive your ICLA - is the process under way?
>
> ICLA would be needed in order to merge this work.
I have sent it to them twice. The first time it was rejected because the address wasn’t detailed enough, and the second time because the email in the ICLA didn’t match the sender’s email. I’ve just sent it a third time :D Hopefully it gets accepted this time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-4236 EmailSubmission/set reject an unknown identityId [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #3252:
URL: https://github.com/apache/james-project/pull/3252#issuecomment-6260285789
Actually I would like to have a way to accept (via a JVM system flag) what https://github.com/linagora/tmail-flutter/issues/5003 client does.
Can you add support for such an option? (Optional retro-compatibility is important).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-4236 EmailSubmission/set reject an unknown identityId [james-project]
Posted by "minnguyen27 (via GitHub)" <gi...@apache.org>.
minnguyen27 commented on code in PR #3252:
URL: https://github.com/apache/james-project/pull/3252#discussion_r4310291002
##########
third-party/spamassassin/src/test/java/org/apache/james/spamassassin/SpamAssassinContract.java:
##########
@@ -455,6 +455,7 @@ default void bobSendSpamEmailToAlice(UserCredential bobCredential) {
" \"accountId\": \"" + bobCredential.accountId() + "\"," +
" \"create\": {" +
" \"k1490\": {" +
+ " \"identityId\": \"" + bobCredential.identityId() + "\"," +
Review Comment:
Thank you both for noticing this. I changed it so that a missing `identityId` is accepted again, as before. An `identityId` that is unknown, invalid, or belongs to another user is still rejected with `invalidProperties`
i has opened a follow-up issue #([url](https://github.com/linagora/tmail-flutter/issues/5003)) for flutter FE to fix the case no custom identity exists; the composer falls back to a server-set identity (`mayDelete: false`) for sending, and sends its ID as `identityId`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-4236 EmailSubmission/set reject an unknown or missing identityId [james-project]
Posted by "quantranhong1999 (via GitHub)" <gi...@apache.org>.
quantranhong1999 commented on code in PR #3252:
URL: https://github.com/apache/james-project/pull/3252#discussion_r4309925381
##########
third-party/spamassassin/src/test/java/org/apache/james/spamassassin/SpamAssassinContract.java:
##########
@@ -455,6 +455,7 @@ default void bobSendSpamEmailToAlice(UserCredential bobCredential) {
" \"accountId\": \"" + bobCredential.accountId() + "\"," +
" \"create\": {" +
" \"k1490\": {" +
+ " \"identityId\": \"" + bobCredential.identityId() + "\"," +
Review Comment:
@minnguyen27 don't you mind checking this? Maybe have a talk with a tmail-flutter's guy if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-4236 EmailSubmission/set reject an unknown or missing identityId [james-project]
Posted by "quantranhong1999 (via GitHub)" <gi...@apache.org>.
quantranhong1999 commented on code in PR #3252:
URL: https://github.com/apache/james-project/pull/3252#discussion_r4311283986
##########
docs/modules/servers/partials/configure/jvm.adoc:
##########
@@ -177,6 +177,20 @@ james.jmap.quota.draft.compatibility=true
----
To enable the compatibility.
+== JMAP EmailSubmission without identityId
+
+RFC 8621 requires `EmailSubmission/set` creations to carry an `identityId`, and James rejects those without one. The
+property `james.jmap.email.submission.missing.identity.compatibility` allows to accept them for clients that omit it.
+An `identityId` that is not one of the user's identities is rejected either way.
+
+Optional. Boolean. Default to false.
Review Comment:
Default to `true` to avoid breaking changes for some existing clients and allow them time to adapt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-4236 EmailSubmission/set reject an unknown or missing identityId [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #3252:
URL: https://github.com/apache/james-project/pull/3252#discussion_r4295070873
##########
third-party/spamassassin/src/test/java/org/apache/james/spamassassin/SpamAssassinContract.java:
##########
@@ -455,6 +455,7 @@ default void bobSendSpamEmailToAlice(UserCredential bobCredential) {
" \"accountId\": \"" + bobCredential.accountId() + "\"," +
" \"create\": {" +
" \"k1490\": {" +
+ " \"identityId\": \"" + bobCredential.identityId() + "\"," +
Review Comment:
Did we make sure we aren't breaking tmail-flutter ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-4236 EmailSubmission/set reject an unknown identityId [james-project]
Posted by "minnguyen27 (via GitHub)" <gi...@apache.org>.
minnguyen27 commented on code in PR #3252:
URL: https://github.com/apache/james-project/pull/3252#discussion_r4311629466
##########
docs/modules/servers/partials/configure/jvm.adoc:
##########
@@ -177,6 +177,20 @@ james.jmap.quota.draft.compatibility=true
----
To enable the compatibility.
+== JMAP EmailSubmission without identityId
+
+RFC 8621 requires `EmailSubmission/set` creations to carry an `identityId`, and James rejects those without one. The
+property `james.jmap.email.submission.missing.identity.compatibility` allows to accept them for clients that omit it.
+An `identityId` that is not one of the user's identities is rejected either way.
+
+Optional. Boolean. Default to false.
Review Comment:
Fixed, i has change default to `true`. Good catch 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-4236 EmailSubmission/set reject an unknown or missing identityId [james-project]
Posted by "minnguyen27 (via GitHub)" <gi...@apache.org>.
minnguyen27 commented on PR #3252:
URL: https://github.com/apache/james-project/pull/3252#issuecomment-6213432956
I just rebased onto the master branch, no logic was changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-4236 EmailSubmission/set reject an unknown identityId [james-project]
Posted by "minnguyen27 (via GitHub)" <gi...@apache.org>.
minnguyen27 commented on code in PR #3252:
URL: https://github.com/apache/james-project/pull/3252#discussion_r4310291002
##########
third-party/spamassassin/src/test/java/org/apache/james/spamassassin/SpamAssassinContract.java:
##########
@@ -455,6 +455,7 @@ default void bobSendSpamEmailToAlice(UserCredential bobCredential) {
" \"accountId\": \"" + bobCredential.accountId() + "\"," +
" \"create\": {" +
" \"k1490\": {" +
+ " \"identityId\": \"" + bobCredential.identityId() + "\"," +
Review Comment:
Thank you both for noticing this. I changed it so that a missing `identityId` is accepted again, as before. An `identityId` that is unknown, invalid, or belongs to another user is still rejected with `invalidProperties`
i has opened a follow-up issue https://github.com/linagora/tmail-flutter/issues/5003 for flutter FE to fix the case no custom identity exists; the composer falls back to a server-set identity (`mayDelete: false`) for sending, and sends its ID as `identityId`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-4236 EmailSubmission/set reject an unknown identityId [james-project]
Posted by "minnguyen27 (via GitHub)" <gi...@apache.org>.
minnguyen27 commented on code in PR #3252:
URL: https://github.com/apache/james-project/pull/3252#discussion_r4310291002
##########
third-party/spamassassin/src/test/java/org/apache/james/spamassassin/SpamAssassinContract.java:
##########
@@ -455,6 +455,7 @@ default void bobSendSpamEmailToAlice(UserCredential bobCredential) {
" \"accountId\": \"" + bobCredential.accountId() + "\"," +
" \"create\": {" +
" \"k1490\": {" +
+ " \"identityId\": \"" + bobCredential.identityId() + "\"," +
Review Comment:
Thank you both for noticing this. I changed it so that a missing `identityId` is accepted again, as before. An `identityId` that is unknown, invalid, or belongs to another user is still rejected with `invalidProperties`
i has opened a follow-up issue [#([url](https://github.com/linagora/tmail-flutter/issues/5003)) ](https://github.com/linagora/tmail-flutter/issues/5003)for Flutter FE to fix the case where no custom identity exists; the composer falls back to a server-set identity (`mayDelete: false`) for sending, and sends its ID as `identityId`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-4236 EmailSubmission/set reject an unknown identityId [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael merged PR #3252:
URL: https://github.com/apache/james-project/pull/3252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org