[GitHub] [iceberg] dilipbiswal commented on a change in pull request #2116: Optimize join types for MERGE INTO

[GitBox <gi...@apache.org>]

dilipbiswal commented on a change in pull request #2116:
URL: https://github.com/apache/iceberg/pull/2116#discussion_r560443000



##########
File path: spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteMergeInto.scala
##########
@@ -58,53 +61,136 @@ case class RewriteMergeInto(conf: SQLConf) extends Rule[LogicalPlan] with Rewrit
 
   override def apply(plan: LogicalPlan): LogicalPlan = {
     plan resolveOperators {
+      case MergeIntoTable(target: DataSourceV2Relation, source: LogicalPlan, cond, matchedActions, notMatchedActions)
+          if matchedActions.isEmpty =>
+
+        val (_, targetTableScan) = buildTargetScan(target, source, cond)

Review comment:
       @rdblue Currently the dynamically pruned target scan does the cardinality check Ryan. I haven't looked at the pr in detail. But just wanted to point out ..




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org