You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/20 06:16:02 UTC

[GitHub] [skywalking] wu-sheng commented on pull request #6003: [WIP]Checkstyle plugin checks test codes

wu-sheng commented on pull request #6003:
URL: https://github.com/apache/skywalking/pull/6003#issuecomment-748569016


   > We execute scenarios in a different order and the content of pom.xml may be different, which breaks idempotence and may cause conflicts when merging.
   
   The changed pom.xml wouldn't be submitted or merged. It is updated in the CI process only.
   
   > Some scenarios may need to be handled separately to check the code style. For example jdk14-with-gson-scenario cannot be checked by adding its name in plugin/pom.xml because of different jdk version.
   
   Could you be more clear about what does this mean? Why does code style relate to JDK version?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org