You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Vladimir Ivanov (JIRA)" <ji...@apache.org> on 2006/07/26 11:35:15 UTC
[jira] Created: (HARMONY-984) [testing] collect modules/bin/tests
directories to one tests.jar
[testing] collect modules/bin/tests directories to one tests.jar
----------------------------------------------------------------
Key: HARMONY-984
URL: http://issues.apache.org/jira/browse/HARMONY-984
Project: Harmony
Issue Type: Improvement
Components: build - test - ci
Reporter: Vladimir Ivanov
To run tests against HDK by simple users Harmony need to collect all tests in one archive.
As the first step the modules/bin/tests directories should be archived to the one tests.jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-984) [testing] collect module test
directories to test jars
Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-984?page=comments#action_12440063 ]
Vladimir Ivanov commented on HARMONY-984:
-----------------------------------------
Patch is OK. I'm going to prepare similar patches for all modules. The next module will be 'security'.
> [testing] collect module test directories to test jars
> ------------------------------------------------------
>
> Key: HARMONY-984
> URL: http://issues.apache.org/jira/browse/HARMONY-984
> Project: Harmony
> Issue Type: Improvement
> Components: build - test - ci
> Reporter: Vladimir Ivanov
> Assigned To: Mark Hindess
> Attachments: accessibility.build.patch, build-test.xml.patch
>
>
> To run tests against HDK by simple users Harmony need to collect all tests in one archive.
> As the first step the modules/bin/tests directories should be archived to the one tests.jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-984) [testing] collect module test
directories to test jars
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-984?page=comments#action_12440820 ]
Mark Hindess commented on HARMONY-984:
--------------------------------------
Vladimir,
A few questions about the updated patch. The line:
<property name="tests-HDK-dir" value="${hy.jdk}/build/test" />
should probably be ${hy.hdk} not ${hy.jdk} ?
Also, previously most of the variables in the security build.xml used dots to separate the words in their names. Your patch introduces variables with both underscores and dashes. Is this intentional? (You've also introduced uppercase letters though I'm less confused about that.)
> [testing] collect module test directories to test jars
> ------------------------------------------------------
>
> Key: HARMONY-984
> URL: http://issues.apache.org/jira/browse/HARMONY-984
> Project: Harmony
> Issue Type: Improvement
> Components: build - test - ci
> Reporter: Vladimir Ivanov
> Assigned To: Mark Hindess
> Attachments: accessibility.build.patch, build-test.xml.patch, security.patch, security.updated.patch
>
>
> To run tests against HDK by simple users Harmony need to collect all tests in one archive.
> As the first step the modules/bin/tests directories should be archived to the one tests.jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-984) [testing] collect module test
directories to test jars
Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-984?page=all ]
Vladimir Ivanov updated HARMONY-984:
------------------------------------
Attachment: awt_auth.patch
patch for awt+auth+archive+accessibility modules.
Note, awt+auth jared to impl_in arhives while have tests in the o.a.h package.
> [testing] collect module test directories to test jars
> ------------------------------------------------------
>
> Key: HARMONY-984
> URL: http://issues.apache.org/jira/browse/HARMONY-984
> Project: Harmony
> Issue Type: Improvement
> Components: build - test - ci
> Reporter: Vladimir Ivanov
> Assigned To: Mark Hindess
> Attachments: accessibility.build.patch, awt_auth.patch, build-test.xml.patch, security.patch, security.updated.patch, security.updated1.patch
>
>
> To run tests against HDK by simple users Harmony need to collect all tests in one archive.
> As the first step the modules/bin/tests directories should be archived to the one tests.jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-984) [testing] collect modules/bin/tests
directories to one tests.jar
Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-984?page=all ]
Vladimir Ivanov updated HARMONY-984:
------------------------------------
Attachment: build-test.xml.patch
patch
> [testing] collect modules/bin/tests directories to one tests.jar
> ----------------------------------------------------------------
>
> Key: HARMONY-984
> URL: http://issues.apache.org/jira/browse/HARMONY-984
> Project: Harmony
> Issue Type: Improvement
> Components: build - test - ci
> Reporter: Vladimir Ivanov
> Attachments: build-test.xml.patch
>
>
> To run tests against HDK by simple users Harmony need to collect all tests in one archive.
> As the first step the modules/bin/tests directories should be archived to the one tests.jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-984) [testing] collect module test
directories to test jars
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-984?page=all ]
Mark Hindess updated HARMONY-984:
---------------------------------
Summary: [testing] collect module test directories to test jars (was: [testing] collect modules/bin/tests directories to one tests.jar)
> [testing] collect module test directories to test jars
> ------------------------------------------------------
>
> Key: HARMONY-984
> URL: http://issues.apache.org/jira/browse/HARMONY-984
> Project: Harmony
> Issue Type: Improvement
> Components: build - test - ci
> Reporter: Vladimir Ivanov
> Assigned To: Mark Hindess
> Attachments: accessibility.build.patch, build-test.xml.patch
>
>
> To run tests against HDK by simple users Harmony need to collect all tests in one archive.
> As the first step the modules/bin/tests directories should be archived to the one tests.jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-984) [testing] collect module test
directories to test jars
Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-984?page=comments#action_12440826 ]
Vladimir Ivanov commented on HARMONY-984:
-----------------------------------------
variable '${hy.jdk}' were defined early I just use it. But agreed, 'hdk' is more preferable here.
I'll prepare the patch with dot-separated names and with small letters in some minutes.
> [testing] collect module test directories to test jars
> ------------------------------------------------------
>
> Key: HARMONY-984
> URL: http://issues.apache.org/jira/browse/HARMONY-984
> Project: Harmony
> Issue Type: Improvement
> Components: build - test - ci
> Reporter: Vladimir Ivanov
> Assigned To: Mark Hindess
> Attachments: accessibility.build.patch, build-test.xml.patch, security.patch, security.updated.patch
>
>
> To run tests against HDK by simple users Harmony need to collect all tests in one archive.
> As the first step the modules/bin/tests directories should be archived to the one tests.jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-984) [testing] collect modules/bin/tests
directories to one tests.jar
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-984?page=all ]
Mark Hindess reassigned HARMONY-984:
------------------------------------
Assignee: Mark Hindess
> [testing] collect modules/bin/tests directories to one tests.jar
> ----------------------------------------------------------------
>
> Key: HARMONY-984
> URL: http://issues.apache.org/jira/browse/HARMONY-984
> Project: Harmony
> Issue Type: Improvement
> Components: build - test - ci
> Reporter: Vladimir Ivanov
> Assigned To: Mark Hindess
> Attachments: accessibility.build.patch, build-test.xml.patch
>
>
> To run tests against HDK by simple users Harmony need to collect all tests in one archive.
> As the first step the modules/bin/tests directories should be archived to the one tests.jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-984) [testing] collect module test
directories to test jars
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-984?page=comments#action_12441474 ]
Mark Hindess commented on HARMONY-984:
--------------------------------------
Thanks Vladimir.
I've applied the security patch in r462825.
I wonder if it might be tidier to put the resources in a jar as well? What do you think?
(I prefer to leave all attachments - the manage attachments view makes it clear which is the latest version so it's not too confusing.)
> [testing] collect module test directories to test jars
> ------------------------------------------------------
>
> Key: HARMONY-984
> URL: http://issues.apache.org/jira/browse/HARMONY-984
> Project: Harmony
> Issue Type: Improvement
> Components: build - test - ci
> Reporter: Vladimir Ivanov
> Assigned To: Mark Hindess
> Attachments: accessibility.build.patch, awt_auth.patch, awt_auth1.patch, build-test.xml.patch, security.patch, security.updated.patch, security.updated1.patch
>
>
> To run tests against HDK by simple users Harmony need to collect all tests in one archive.
> As the first step the modules/bin/tests directories should be archived to the one tests.jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-984) [testing] collect module test
directories to test jars
Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-984?page=all ]
Vladimir Ivanov updated HARMONY-984:
------------------------------------
Attachment: beans.build.patch
beans patch
> [testing] collect module test directories to test jars
> ------------------------------------------------------
>
> Key: HARMONY-984
> URL: http://issues.apache.org/jira/browse/HARMONY-984
> Project: Harmony
> Issue Type: Improvement
> Components: build - test - ci
> Reporter: Vladimir Ivanov
> Assigned To: Mark Hindess
> Attachments: accessibility.build.patch, awt_auth.patch, awt_auth1.patch, beans.build.patch, build-test.xml.patch, security.patch, security.updated.patch, security.updated1.patch
>
>
> To run tests against HDK by simple users Harmony need to collect all tests in one archive.
> As the first step the modules/bin/tests directories should be archived to the one tests.jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-984) [testing] collect module test
directories to test jars
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-984?page=comments#action_12440048 ]
Mark Hindess commented on HARMONY-984:
--------------------------------------
Thanks Vladimir.
I've applied the accessibility patch in r453122. Please confirm it is okay.
Assuming you are planning to carry on with this process, if not let me know and I'll add it to my todo list, my preference would be to do one of the difficult modules next - one with four jars. Then it should be fairly easy to apply the "pattern" to the remaining modules. After that we should think about MANIFEST files but that can wait until we've got all modules working this way.
> [testing] collect module test directories to test jars
> ------------------------------------------------------
>
> Key: HARMONY-984
> URL: http://issues.apache.org/jira/browse/HARMONY-984
> Project: Harmony
> Issue Type: Improvement
> Components: build - test - ci
> Reporter: Vladimir Ivanov
> Assigned To: Mark Hindess
> Attachments: accessibility.build.patch, build-test.xml.patch
>
>
> To run tests against HDK by simple users Harmony need to collect all tests in one archive.
> As the first step the modules/bin/tests directories should be archived to the one tests.jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-984) [testing] collect modules/bin/tests
directories to one tests.jar
Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-984?page=all ]
Vladimir Ivanov updated HARMONY-984:
------------------------------------
Attachment: accessibility.build.patch
According to discussion on the dev-list it should be separated jars (up to 4) for each module.
Could somebody review and integrate changes for accessibility module?
If it is OK I prepare the similar updates for each module.
> [testing] collect modules/bin/tests directories to one tests.jar
> ----------------------------------------------------------------
>
> Key: HARMONY-984
> URL: http://issues.apache.org/jira/browse/HARMONY-984
> Project: Harmony
> Issue Type: Improvement
> Components: build - test - ci
> Reporter: Vladimir Ivanov
> Attachments: accessibility.build.patch, build-test.xml.patch
>
>
> To run tests against HDK by simple users Harmony need to collect all tests in one archive.
> As the first step the modules/bin/tests directories should be archived to the one tests.jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-984) [testing] collect module test
directories to test jars
Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-984?page=all ]
Vladimir Ivanov updated HARMONY-984:
------------------------------------
Attachment: awt_auth1.patch
patch for awt+auth+archive+accessibility modules.
(the last one is outdated)
Mark, could your remove accessibility.build.patch (applied), awt_auth.patch (outdated)
build-test.xml.patch (outdated), security.patch (outdated), security.updated.patch (outdated) files?
> [testing] collect module test directories to test jars
> ------------------------------------------------------
>
> Key: HARMONY-984
> URL: http://issues.apache.org/jira/browse/HARMONY-984
> Project: Harmony
> Issue Type: Improvement
> Components: build - test - ci
> Reporter: Vladimir Ivanov
> Assigned To: Mark Hindess
> Attachments: accessibility.build.patch, awt_auth.patch, awt_auth1.patch, build-test.xml.patch, security.patch, security.updated.patch, security.updated1.patch
>
>
> To run tests against HDK by simple users Harmony need to collect all tests in one archive.
> As the first step the modules/bin/tests directories should be archived to the one tests.jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-984) [testing] collect module test
directories to test jars
Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-984?page=all ]
Vladimir Ivanov updated HARMONY-984:
------------------------------------
Attachment: security.updated1.patch
patch with dot-separated names.
If it is OK I will use it as pattern for other modules
> [testing] collect module test directories to test jars
> ------------------------------------------------------
>
> Key: HARMONY-984
> URL: http://issues.apache.org/jira/browse/HARMONY-984
> Project: Harmony
> Issue Type: Improvement
> Components: build - test - ci
> Reporter: Vladimir Ivanov
> Assigned To: Mark Hindess
> Attachments: accessibility.build.patch, build-test.xml.patch, security.patch, security.updated.patch, security.updated1.patch
>
>
> To run tests against HDK by simple users Harmony need to collect all tests in one archive.
> As the first step the modules/bin/tests directories should be archived to the one tests.jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-984) [testing] collect module test
directories to test jars
Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-984?page=comments#action_12441626 ]
Vladimir Ivanov commented on HARMONY-984:
-----------------------------------------
When I ran tests with security-resource.jar I saw about 30 tests failures. The first half was due to missed key-storage for some security algorithm the second one due to missed serialization data files. Access to serialization data may be easily fixed, but I don't know good solution to fix access problem for 'special' files. I considered two options here:
- the test extract needed files from the archive through the some library function to the temporary location and then use it;
- the resource files stored to separated directory in the HDK without compression.
At present time the second option was selected just because it is:
- easy to implement;
- tests are still simple and more reliable.
> [testing] collect module test directories to test jars
> ------------------------------------------------------
>
> Key: HARMONY-984
> URL: http://issues.apache.org/jira/browse/HARMONY-984
> Project: Harmony
> Issue Type: Improvement
> Components: build - test - ci
> Reporter: Vladimir Ivanov
> Assigned To: Mark Hindess
> Attachments: accessibility.build.patch, awt_auth.patch, awt_auth1.patch, build-test.xml.patch, security.patch, security.updated.patch, security.updated1.patch
>
>
> To run tests against HDK by simple users Harmony need to collect all tests in one archive.
> As the first step the modules/bin/tests directories should be archived to the one tests.jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-984) [testing] collect module test
directories to test jars
Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-984?page=all ]
Vladimir Ivanov updated HARMONY-984:
------------------------------------
Attachment: security.updated.patch
updated patch. The old one is obsolete due to fix of patterns.
> [testing] collect module test directories to test jars
> ------------------------------------------------------
>
> Key: HARMONY-984
> URL: http://issues.apache.org/jira/browse/HARMONY-984
> Project: Harmony
> Issue Type: Improvement
> Components: build - test - ci
> Reporter: Vladimir Ivanov
> Assigned To: Mark Hindess
> Attachments: accessibility.build.patch, build-test.xml.patch, security.patch, security.updated.patch
>
>
> To run tests against HDK by simple users Harmony need to collect all tests in one archive.
> As the first step the modules/bin/tests directories should be archived to the one tests.jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-984) [testing] collect module test
directories to test jars
Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-984?page=all ]
Vladimir Ivanov updated HARMONY-984:
------------------------------------
Attachment: security.patch
tests are placed in 4 archives, resources are copied to the HDK dir while many tests refers to resources as a file on the disk (key storage, serialization data etc) and not for all of them data can be stored in the archive.
If it is OK - I'll prepare patches for other modules.
> [testing] collect module test directories to test jars
> ------------------------------------------------------
>
> Key: HARMONY-984
> URL: http://issues.apache.org/jira/browse/HARMONY-984
> Project: Harmony
> Issue Type: Improvement
> Components: build - test - ci
> Reporter: Vladimir Ivanov
> Assigned To: Mark Hindess
> Attachments: accessibility.build.patch, build-test.xml.patch, security.patch
>
>
> To run tests against HDK by simple users Harmony need to collect all tests in one archive.
> As the first step the modules/bin/tests directories should be archived to the one tests.jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira