You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/02 12:39:41 UTC
[GitHub] [flink] tzulitai opened a new pull request #12443: [FLINK-18069] [scala, docs] Scaladocs 2.12 fails to recognize inner interfaces
tzulitai opened a new pull request #12443:
URL: https://github.com/apache/flink/pull/12443
This is a similar issue as reported here: scala/bug#10509.
This seems to be a problem with Scaladocs 2.12.x. The only workaround, it seems from the issue reports, is to redundantly add the full-length qualifiers for such interfaces.
## Verifying this change
Verified this by doing the following steps
- Build the project: `mvn clean install -DskipTests`
- Build the Javadocs: `mvn javadoc:aggregate -Paggregate-scaladoc`
- Build the Scaladocs: `cd flink-scala/ && mvn scala:doc`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12443: [FLINK-18069] [scala, docs] Scaladocs 2.12 fails to recognize inner interfaces
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12443:
URL: https://github.com/apache/flink/pull/12443#issuecomment-637524746
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bab66f05011294dc42e10e5016f975e4fd9f132f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2570",
"triggerID" : "bab66f05011294dc42e10e5016f975e4fd9f132f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bab66f05011294dc42e10e5016f975e4fd9f132f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2570)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12443: [FLINK-18069] [scala, docs] Scaladocs 2.12 fails to recognize inner interfaces
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12443:
URL: https://github.com/apache/flink/pull/12443#issuecomment-637516266
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit bab66f05011294dc42e10e5016f975e4fd9f132f (Tue Jun 02 12:41:50 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tzulitai commented on pull request #12443: [FLINK-18069] [scala, docs] Scaladocs 2.12 fails to recognize inner interfaces
Posted by GitBox <gi...@apache.org>.
tzulitai commented on pull request #12443:
URL: https://github.com/apache/flink/pull/12443#issuecomment-638601816
Thanks, merging ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12443: [FLINK-18069] [scala, docs] Scaladocs 2.12 fails to recognize inner interfaces
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12443:
URL: https://github.com/apache/flink/pull/12443#issuecomment-637524746
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bab66f05011294dc42e10e5016f975e4fd9f132f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bab66f05011294dc42e10e5016f975e4fd9f132f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bab66f05011294dc42e10e5016f975e4fd9f132f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol closed pull request #12443: [FLINK-18069] [scala, docs] Scaladocs 2.12 fails to recognize inner interfaces
Posted by GitBox <gi...@apache.org>.
zentol closed pull request #12443:
URL: https://github.com/apache/flink/pull/12443
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12443: [FLINK-18069] [scala, docs] Scaladocs 2.12 fails to recognize inner interfaces
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12443:
URL: https://github.com/apache/flink/pull/12443#issuecomment-637524746
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bab66f05011294dc42e10e5016f975e4fd9f132f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2570",
"triggerID" : "bab66f05011294dc42e10e5016f975e4fd9f132f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bab66f05011294dc42e10e5016f975e4fd9f132f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2570)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org