You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/02/15 17:53:41 UTC

[jira] [Commented] (ARTEMIS-969) ReceiveMessage will expand unecessarily on core protocol

    [ https://issues.apache.org/jira/browse/ARTEMIS-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868250#comment-15868250 ] 

ASF GitHub Bot commented on ARTEMIS-969:
----------------------------------------

GitHub user clebertsuconic opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1020

    ARTEMIS-969 Fixing unecessary buffer expansion on message delivery

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/clebertsuconic/activemq-artemis artemis-969

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1020.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1020
    
----
commit 7cafe75e226992318fe8a235f1ed49db19637334
Author: Clebert Suconic <cl...@apache.org>
Date:   2017-02-15T17:51:05Z

    ARTEMIS-969 Fixing unecessary buffer expansion on message delivery

----


> ReceiveMessage will expand unecessarily on core protocol
> --------------------------------------------------------
>
>                 Key: ARTEMIS-969
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-969
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 1.5.3
>            Reporter: clebert suconic
>             Fix For: 2.0.0, 1.5.x
>
>
> SessionReceiveMessage creates the Netty buffer using the message buffer writerIndex, however two additional parameters are written on the wire, causing unecessary expansion of the buffer (Netty will make a copy of the buffer and expand it), which is totally unecessary.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)