You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/02/06 17:16:02 UTC

[GitHub] emacip opened a new pull request #6821: [WIP] User can turn off download - export csv from a dashboard

emacip opened a new pull request #6821: [WIP] User can turn off download - export csv from a dashboard
URL: https://github.com/apache/incubator-superset/pull/6821
 
 
   Adding variable `supersetCanCSV` to check if the user has permission to download CSV in the dashboard. 
   Superset has a permission `can_csv` to check if we are allowed to export CSV or not.
   This commit should fix the issues #6116, #6110  
   
   Screenshots:
   
   Admin user with can_csv permission can export csv.
   ![screenshot 2019-02-06 at 17 03 04](https://user-images.githubusercontent.com/472178/52359347-a1edef80-2a31-11e9-98d7-50ad507a837f.png)
   
   Remove can_csv permission from Gamma role.
   ![screenshot 2019-02-06 at 17 03 39](https://user-images.githubusercontent.com/472178/52359504-f2fde380-2a31-11e9-8238-65c822ca3847.png)
   
   Gamma user access to dashboard options without the export csv option.
   ![screenshot 2019-02-06 at 17 04 21](https://user-images.githubusercontent.com/472178/52359585-1b85dd80-2a32-11e9-9152-4e7d10f90048.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org