You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/08/22 08:47:24 UTC
[GitHub] [incubator-pegasus] empiredan opened a new pull request, #1133: Je dump
empiredan opened a new pull request, #1133:
URL: https://github.com/apache/incubator-pegasus/pull/1133
https://github.com/apache/incubator-pegasus/pull/1050
### What problem does this PR solve? <!--add issue link with summary if exists-->
### What is changed and how does it work?
### Checklist <!--REMOVE the items that are not applicable-->
##### Tests <!-- At least one of them must be included. -->
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
##### Code changes
- Has exported function/method change
- Has exported variable/fields change
- Has interface methods change
- Has persistent data change
##### Side effects
- Possible performance regression
- Increased code complexity
- Breaking backward compatibility
##### Related changes
- Need to cherry-pick to the release branch
- Need to update the documentation
- Need to be included in the release note
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan commented on a diff in pull request #1133: feat(jemalloc): support to dump stats
Posted by GitBox <gi...@apache.org>.
empiredan commented on code in PR #1133:
URL: https://github.com/apache/incubator-pegasus/pull/1133#discussion_r963399629
##########
.github/workflows/lint_and_test_cpp.yaml:
##########
@@ -373,6 +373,90 @@ jobs:
./scripts/config_hdfs.sh
./run.sh test --on_travis -m ${{ matrix.test_module }}
+ build_with_jemalloc:
+ name: Build with jemalloc
+ needs: cpp_clang_format_linter
+ runs-on: ubuntu-latest
+ container:
+ image: apache/pegasus:thirdparties-bin-test-jemallc-ubuntu1804-${{ github.base_ref }}
+ steps:
+ - uses: actions/checkout@v2
+ - name: Setup cache
+ uses: actions/cache@v3
+ with:
+ path: |
+ /github/home/.ccache
+ key: release_ccache
Review Comment:
> Since the cache with the same name will overwrite the other, so it's better to use another name for jemalloc build type cache, such as `jemalloc_ccache`
OK, I'll change the name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan commented on a diff in pull request #1133: feat(jemalloc): support to dump stats
Posted by GitBox <gi...@apache.org>.
empiredan commented on code in PR #1133:
URL: https://github.com/apache/incubator-pegasus/pull/1133#discussion_r956602964
##########
src/rdsn/src/utils/test/je_ctl_test.cpp:
##########
@@ -0,0 +1,108 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#ifdef DSN_USE_JEMALLOC
Review Comment:
> These tests will be built and ran, maybe we have to add another test type in workflows?
Good advice, I'll add workflows of build and unit tests with jemalloc. I'll try to reduce time spent on unit tests, by just adding ones jemalloc refers to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1133: feat(jemalloc): support to dump stats
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #1133:
URL: https://github.com/apache/incubator-pegasus/pull/1133#discussion_r963209655
##########
.github/workflows/lint_and_test_cpp.yaml:
##########
@@ -373,6 +373,90 @@ jobs:
./scripts/config_hdfs.sh
./run.sh test --on_travis -m ${{ matrix.test_module }}
+ build_with_jemalloc:
+ name: Build with jemalloc
+ needs: cpp_clang_format_linter
+ runs-on: ubuntu-latest
+ container:
+ image: apache/pegasus:thirdparties-bin-test-jemallc-ubuntu1804-${{ github.base_ref }}
+ steps:
+ - uses: actions/checkout@v2
+ - name: Setup cache
+ uses: actions/cache@v3
+ with:
+ path: |
+ /github/home/.ccache
+ key: release_ccache
Review Comment:
Since the cache with the same name will overwrite the other, so it's better to use another name for jemalloc build type cache, such as `jemalloc_ccache`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan merged pull request #1133: feat(jemalloc): support to dump stats
Posted by GitBox <gi...@apache.org>.
empiredan merged PR #1133:
URL: https://github.com/apache/incubator-pegasus/pull/1133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1133: feat(jemalloc): support to dump stats
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #1133:
URL: https://github.com/apache/incubator-pegasus/pull/1133#discussion_r956206125
##########
src/rdsn/src/utils/test/je_ctl_test.cpp:
##########
@@ -0,0 +1,108 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#ifdef DSN_USE_JEMALLOC
Review Comment:
These tests will be built and ran, maybe we have to add another test type in workflows?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org