You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/03 02:16:32 UTC
[GitHub] [spark] viirya opened a new pull request, #37386: [SPARK-39958][SQL] Add warning log when unable to load custom metric object
viirya opened a new pull request, #37386:
URL: https://github.com/apache/spark/pull/37386
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Currently when `SQLAppStatusListener` cannot load custom metric object, it silently ignores the error. We better provide a warning log for users.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Improving user experience.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Existing tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #37386: [SPARK-39958][SQL] Add warning log when unable to load custom metric object
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #37386:
URL: https://github.com/apache/spark/pull/37386#issuecomment-1203553149
The known and unrelated sparkr failure:
```
Status: 1 WARNING, 2 NOTEs
See
‘/__w/spark-1/spark-1/R/SparkR.Rcheck/00check.log’
for details.
+ popd
Had CRAN check errors; see logs.
[error] running /__w/spark-1/spark-1/R/run-tests.sh ; received return code 255
```
Unrelated Python linter:
```
Traceback (most recent call last):
File "/usr/lib/python3.9/runpy.py", line 197, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/lib/python3.9/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/usr/local/lib/python3.9/dist-packages/black/__main__.py", line 3, in <module>
patched_main()
File "/usr/local/lib/python3.9/dist-packages/black/__init__.py", line 1372, in patched_main
patch_click()
File "/usr/local/lib/python3.9/dist-packages/black/__init__.py", line 1358, in patch_click
from click import _unicodefun
ImportError: cannot import name '_unicodefun' from 'click' (/usr/local/lib/python3.9/dist-packages/click/__init__.py)
Please run 'dev/reformat-python' script.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pan3793 commented on pull request #37386: [SPARK-39958][SQL] Add warning log when unable to load custom metric object
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #37386:
URL: https://github.com/apache/spark/pull/37386#issuecomment-1203410773
Previous discussion: https://github.com/apache/spark/pull/31451#discussion_r935521681
I think we don't need to construct the instance using reflection, how about removing constructor checks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a diff in pull request #37386: [SPARK-39958][SQL] Add warning log when unable to load custom metric object
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #37386:
URL: https://github.com/apache/spark/pull/37386#discussion_r936210229
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListener.scala:
##########
@@ -220,7 +220,10 @@ class SQLAppStatusListener(
metricAggregationMap.put(className, method)
method
} catch {
- case NonFatal(_) =>
+ case NonFatal(e) =>
+ logWarning(s"Unable to load custom metric object for class `$className`. " +
+ "Please make sure that the custom metric class is in the classpath and " +
+ "it has 0-arg constructor.", e)
Review Comment:
I don't think we should. Actually we don't need the implementing class to implement it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #37386: [SPARK-39958][SQL] Add warning log when unable to load custom metric object
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #37386:
URL: https://github.com/apache/spark/pull/37386#issuecomment-1203440500
> Could you please enhance the comment of CustomMetric to mention the constructor requirements as well?
Okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #37386: [SPARK-39958][SQL] Add warning log when unable to load custom metric object
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #37386:
URL: https://github.com/apache/spark/pull/37386#issuecomment-1203568808
Merged, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #37386: [SPARK-39958][SQL] Add warning log when unable to load custom metric object
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #37386:
URL: https://github.com/apache/spark/pull/37386#issuecomment-1203406086
cc @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #37386: [SPARK-39958][SQL] Add warning log when unable to load custom metric object
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #37386:
URL: https://github.com/apache/spark/pull/37386#issuecomment-1203419884
> I think we don't need to construct the instance using reflection
Then how can we construct the instance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #37386: [SPARK-39958][SQL] Add warning log when unable to load custom metric object
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #37386:
URL: https://github.com/apache/spark/pull/37386#issuecomment-1203420171
Just about to ask same question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pan3793 commented on a diff in pull request #37386: [SPARK-39958][SQL] Add warning log when unable to load custom metric object
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #37386:
URL: https://github.com/apache/spark/pull/37386#discussion_r936208670
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListener.scala:
##########
@@ -220,7 +220,10 @@ class SQLAppStatusListener(
metricAggregationMap.put(className, method)
method
} catch {
- case NonFatal(_) =>
+ case NonFatal(e) =>
+ logWarning(s"Unable to load custom metric object for class `$className`. " +
+ "Please make sure that the custom metric class is in the classpath and " +
+ "it has 0-arg constructor.", e)
Review Comment:
`Utils#loadExtensions` also allows "single-argument constructor that accepts SparkConf", do we need to mention that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya closed pull request #37386: [SPARK-39958][SQL] Add warning log when unable to load custom metric object
Posted by GitBox <gi...@apache.org>.
viirya closed pull request #37386: [SPARK-39958][SQL] Add warning log when unable to load custom metric object
URL: https://github.com/apache/spark/pull/37386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a diff in pull request #37386: [SPARK-39958][SQL] Add warning log when unable to load custom metric object
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #37386:
URL: https://github.com/apache/spark/pull/37386#discussion_r936204451
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListener.scala:
##########
@@ -220,7 +220,10 @@ class SQLAppStatusListener(
metricAggregationMap.put(className, method)
method
} catch {
- case NonFatal(_) =>
+ case NonFatal(e) =>
+ logWarning(s"Unable to load custom metric object for class `$className`. " +
+ "Please make sure that the custom metric class is in the classpath and " +
+ "it has 0-arg constructor", e)
Review Comment:
Added. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #37386: [SPARK-39958][SQL] Add warning log when unable to load custom metric object
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #37386:
URL: https://github.com/apache/spark/pull/37386#discussion_r936202134
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListener.scala:
##########
@@ -220,7 +220,10 @@ class SQLAppStatusListener(
metricAggregationMap.put(className, method)
method
} catch {
- case NonFatal(_) =>
+ case NonFatal(e) =>
+ logWarning(s"Unable to load custom metric object for class `$className`. " +
+ "Please make sure that the custom metric class is in the classpath and " +
+ "it has 0-arg constructor", e)
Review Comment:
nit. `.` at the end of the sentence?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pan3793 commented on pull request #37386: [SPARK-39958][SQL] Add warning log when unable to load custom metric object
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #37386:
URL: https://github.com/apache/spark/pull/37386#issuecomment-1203438797
Oh, I see. `SQLMetrics.createV2CustomMetric` only store the class name instead of the instance itself, then constructing the instance by reflection is necessary.
Previous I misunderstand that instances constructed by `Scan#supportedCustomMetrics` will be passed and reused.
Could you please enhance the comment of `CustomMetric` to mention the constructor requirements as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org