You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by jd...@apache.org on 2008/06/03 10:18:25 UTC
svn commit: r662689 - in /geronimo/gshell/trunk:
gshell-buildsupport/gshell-maven-plugin/src/main/java/org/apache/geronimo/gshell/maven/gshell/CommandGleaner.java
gshell-core/src/main/java/org/apache/geronimo/gshell/DefaultShell.java
Author: jdillon
Date: Tue Jun 3 01:18:25 2008
New Revision: 662689
URL: http://svn.apache.org/viewvc?rev=662689&view=rev
Log:
Tidy up
Modified:
geronimo/gshell/trunk/gshell-buildsupport/gshell-maven-plugin/src/main/java/org/apache/geronimo/gshell/maven/gshell/CommandGleaner.java
geronimo/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/DefaultShell.java
Modified: geronimo/gshell/trunk/gshell-buildsupport/gshell-maven-plugin/src/main/java/org/apache/geronimo/gshell/maven/gshell/CommandGleaner.java
URL: http://svn.apache.org/viewvc/geronimo/gshell/trunk/gshell-buildsupport/gshell-maven-plugin/src/main/java/org/apache/geronimo/gshell/maven/gshell/CommandGleaner.java?rev=662689&r1=662688&r2=662689&view=diff
==============================================================================
--- geronimo/gshell/trunk/gshell-buildsupport/gshell-maven-plugin/src/main/java/org/apache/geronimo/gshell/maven/gshell/CommandGleaner.java (original)
+++ geronimo/gshell/trunk/gshell-buildsupport/gshell-maven-plugin/src/main/java/org/apache/geronimo/gshell/maven/gshell/CommandGleaner.java Tue Jun 3 01:18:25 2008
@@ -99,10 +99,6 @@
Command command = new Command();
- //
- // TODO: Set the source...
- //
-
command.setId(anno.id());
command.setDescription(filterEmptyAsNull(anno.description()));
Modified: geronimo/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/DefaultShell.java
URL: http://svn.apache.org/viewvc/geronimo/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/DefaultShell.java?rev=662689&r1=662688&r2=662689&view=diff
==============================================================================
--- geronimo/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/DefaultShell.java (original)
+++ geronimo/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/DefaultShell.java Tue Jun 3 01:18:25 2008
@@ -114,13 +114,6 @@
this.env = context.getEnvironment();
this.branding = context.getApplication().getBranding();
- //
- // FIXME: This won't work as desired, as this shell instance is not yet registered, so if a profile
- // tries to run something that needs the shell instance... well, loopsvile.
- //
- // This could be a warning sign that some of this class needs to be split up into smaller bits...
- //
-
try {
loadProfileScripts();
}