You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/12 17:21:09 UTC

[GitHub] [spark] huaxingao opened a new pull request #26103: [SPARK-29381][PYTHON][ML] Add _ before the XXXParams classes

huaxingao opened a new pull request #26103: [SPARK-29381][PYTHON][ML] Add _ before the XXXParams classes
URL: https://github.com/apache/spark/pull/26103
 
 
   ### What changes were proposed in this pull request?
   Add _ before XXXParams classes to indicate internal usage
   
   
   ### Why are the changes needed?
   Follow the PEP 8 convention to use _single_leading_underscore to indicate internal use 
   
   
   ### Does this PR introduce any user-facing change?
   No
   
   
   ### How was this patch tested?
   use existing tests
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org