You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/31 04:48:07 UTC
[GitHub] [doris] ChPi opened a new pull request, #13801: [Bug][Vectorized] rapidjson should reset writer when output json
ChPi opened a new pull request, #13801:
URL: https://github.com/apache/doris/pull/13801
# Proposed changes
Issue Number: close #xxx
according to the rapidjson document `https://rapidjson.org/md_doc_sax.html#CompletenessReset`, we should call `reset` when reuse writer to output json.
## Problem summary
pr #13775 on master branch, the p0 check would be failed before using `reset`, and add this `reset` code, it is successful.
but test by myself on previous version(master and 1.1) without this `reset` code would be success
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [x] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [x] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] ChPi commented on pull request #13801: [Bug](Vectorized) rapidjson should reset writer when output json
Posted by GitBox <gi...@apache.org>.
ChPi commented on PR #13801:
URL: https://github.com/apache/doris/pull/13801#issuecomment-1296587232
> Does it need to push to master branch?
it has pushed to master branch in pr #13775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #13801: [Bug](Vectorized) rapidjson should reset writer when output json
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #13801:
URL: https://github.com/apache/doris/pull/13801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #13801: [Bug](Vectorized) rapidjson should reset writer when output json
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #13801:
URL: https://github.com/apache/doris/pull/13801#issuecomment-1296579875
Does it need to push to master branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org