You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2016/09/13 22:41:35 UTC

[kudu-CR] Allow multi-master AlterTable tests in TestKuduTable.java

Will Berkeley has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4406

Change subject: Allow multi-master AlterTable tests in TestKuduTable.java
......................................................................

Allow multi-master AlterTable tests in TestKuduTable.java

Now that AlterTable is supported with AlterTable, and the tests use
multiple masters, we can enable these tests so they run with multiple
masters.

Change-Id: Ieebc0602376be921ec5d7c3f4e5d88b7f4e9356d
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
1 file changed, 0 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/4406/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4406
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieebc0602376be921ec5d7c3f4e5d88b7f4e9356d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>

[kudu-CR] Allow multi-master AlterTable tests in TestKuduTable.java

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.

Change subject: Allow multi-master AlterTable tests in TestKuduTable.java
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4406/1//COMMIT_MSG
Commit Message:

PS1, Line 9: AlterTable is supported with AlterTable
rephrase :)


-- 
To view, visit http://gerrit.cloudera.org:8080/4406
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieebc0602376be921ec5d7c3f4e5d88b7f4e9356d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] Allow multi-master AlterTable tests in TestKuduTable.java

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.

Change subject: Allow multi-master AlterTable tests in TestKuduTable.java
......................................................................


Allow multi-master AlterTable tests in TestKuduTable.java

Now that AlterTable is supported with multimaster, and the tests use
multiple masters, we can enable these tests so they run with multiple
masters.

Change-Id: Ieebc0602376be921ec5d7c3f4e5d88b7f4e9356d
Reviewed-on: http://gerrit.cloudera.org:8080/4406
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
1 file changed, 0 insertions(+), 5 deletions(-)

Approvals:
  Jean-Daniel Cryans: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4406
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieebc0602376be921ec5d7c3f4e5d88b7f4e9356d
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] Allow multi-master AlterTable tests in TestKuduTable.java

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.

Change subject: Allow multi-master AlterTable tests in TestKuduTable.java
......................................................................


Patch Set 2: Code-Review+2

Assuming the test passes.

-- 
To view, visit http://gerrit.cloudera.org:8080/4406
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieebc0602376be921ec5d7c3f4e5d88b7f4e9356d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No

[kudu-CR] Allow multi-master AlterTable tests in TestKuduTable.java

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has uploaded a new patch set (#2).

Change subject: Allow multi-master AlterTable tests in TestKuduTable.java
......................................................................

Allow multi-master AlterTable tests in TestKuduTable.java

Now that AlterTable is supported with multimaster, and the tests use
multiple masters, we can enable these tests so they run with multiple
masters.

Change-Id: Ieebc0602376be921ec5d7c3f4e5d88b7f4e9356d
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
1 file changed, 0 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/4406/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4406
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieebc0602376be921ec5d7c3f4e5d88b7f4e9356d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Allow multi-master AlterTable tests in TestKuduTable.java

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.

Change subject: Allow multi-master AlterTable tests in TestKuduTable.java
......................................................................


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4406
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieebc0602376be921ec5d7c3f4e5d88b7f4e9356d
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No

[kudu-CR] Allow multi-master AlterTable tests in TestKuduTable.java

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Allow multi-master AlterTable tests in TestKuduTable.java
......................................................................


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/3405/

-- 
To view, visit http://gerrit.cloudera.org:8080/4406
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieebc0602376be921ec5d7c3f4e5d88b7f4e9356d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Allow multi-master AlterTable tests in TestKuduTable.java

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Allow multi-master AlterTable tests in TestKuduTable.java
......................................................................


Patch Set 3: -Verified

Build Started http://104.196.14.100/job/kudu-gerrit/3416/

-- 
To view, visit http://gerrit.cloudera.org:8080/4406
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieebc0602376be921ec5d7c3f4e5d88b7f4e9356d
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No

[kudu-CR] Allow multi-master AlterTable tests in TestKuduTable.java

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Allow multi-master AlterTable tests in TestKuduTable.java
......................................................................


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/3407/

-- 
To view, visit http://gerrit.cloudera.org:8080/4406
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieebc0602376be921ec5d7c3f4e5d88b7f4e9356d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Allow multi-master AlterTable tests in TestKuduTable.java

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.

Change subject: Allow multi-master AlterTable tests in TestKuduTable.java
......................................................................


Patch Set 2:

Whoops

-- 
To view, visit http://gerrit.cloudera.org:8080/4406
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieebc0602376be921ec5d7c3f4e5d88b7f4e9356d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No

[kudu-CR] Allow multi-master AlterTable tests in TestKuduTable.java

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Allow multi-master AlterTable tests in TestKuduTable.java
......................................................................


Patch Set 3:

Build Started http://104.196.14.100/job/kudu-gerrit/3410/

-- 
To view, visit http://gerrit.cloudera.org:8080/4406
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieebc0602376be921ec5d7c3f4e5d88b7f4e9356d
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No