You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Taragolis (via GitHub)" <gi...@apache.org> on 2024/04/23 14:41:44 UTC
[PR] Force to use Airflow Deprecation warnings categories on @deprecated decorator [airflow]
Taragolis opened a new pull request, #39205:
URL: https://github.com/apache/airflow/pull/39205
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
By default deprecations decorators use `DeprecationWarning` which might be not what we want to use in core and providers.
This one is a bit more extended version of:
- check-no-airflow-deprecation-in-providers
- check-core-deprecation-classes
However it work only with decorators, from [Deprecation](https://pypi.org/project/Deprecated/) or [PEP-702](https://peps.python.org/pep-0702/)
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Force to use Airflow Deprecation warnings categories on `@deprecated` decorator [airflow]
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on PR #39205:
URL: https://github.com/apache/airflow/pull/39205#issuecomment-2073401368
Personally I more for the `@deprecated` from the warning/typing_extension rather than [Deprecation](https://pypi.org/project/Deprecated/) module even if it not supports `deprecated_since`/`version` by design but it should supported more widely by third-parties tools/IDEs, and also it become in some (most) cases runtime checkable.
In general `warnings.warn` supports provide Warning object instead of message + category:
```python
import warnings
from airflow.exceptions import AirflowProviderDeprecationWarning
wrn = AirflowProviderDeprecationWarning("FooBar")
wrn.deprecated_provider_since = "42.0.1"
warnings.warn(wrn)
```
But this one not supported by the decorators because it is expected to have message a string literal and category as a class, and also there is no point to set `deprecated_provider_since` because it doesn't have any affect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Force to use Airflow Deprecation warnings categories on `@deprecated` decorator [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #39205:
URL: https://github.com/apache/airflow/pull/39205#issuecomment-2072900594
Pityy we do not have a way to specify `deprecated_since` - that was the reason why the warnings were originally introduced. But it's a good thing to keep the way we raise warnings consistent at least for decorators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Force to use Airflow Deprecation warnings categories on `@deprecated` decorator [airflow]
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis merged PR #39205:
URL: https://github.com/apache/airflow/pull/39205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org