You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/04/13 15:09:47 UTC

[GitHub] [incubator-tvm] siju-samuel opened a new pull request #5316: [RELAY][PYTORCH]isNan, isinf, isfinite, ceil, clamp, round ops

siju-samuel opened a new pull request #5316: [RELAY][PYTORCH]isNan, isinf, isfinite, ceil, clamp, round ops
URL: https://github.com/apache/incubator-tvm/pull/5316
 
 
   - rsqrt
   - ceil
   - clamp
   - round
   - isfinite
   - isnan
   - isinf
   
   @masahi Please help to review this pr. Thanks in advance
   
   Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] masahi commented on a change in pull request #5316: [RELAY][PYTORCH]isNan, isinf, isfinite, ceil, clamp, round ops

Posted by GitBox <gi...@apache.org>.
masahi commented on a change in pull request #5316: [RELAY][PYTORCH]isNan, isinf, isfinite, ceil, clamp, round ops
URL: https://github.com/apache/incubator-tvm/pull/5316#discussion_r407592029
 
 

 ##########
 File path: src/target/intrin_rule.cc
 ##########
 @@ -96,6 +96,14 @@ TVM_REGISTER_GLOBAL("tvm.intrin.rule.default.sigmoid")
     *rv = one / (one + exp(-call->args[0]));
   });
 
+TVM_REGISTER_GLOBAL("tvm.intrin.rule.default.nan")
 
 Review comment:
   shouldn't it be `isnan`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] masahi commented on issue #5316: [RELAY][PYTORCH]isNan, isinf, isfinite, ceil, clamp, round ops

Posted by GitBox <gi...@apache.org>.
masahi commented on issue #5316: [RELAY][PYTORCH]isNan, isinf, isfinite, ceil, clamp, round ops
URL: https://github.com/apache/incubator-tvm/pull/5316#issuecomment-613338840
 
 
   Thanks @siju-samuel 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] masahi merged pull request #5316: [RELAY][PYTORCH]isNan, isinf, isfinite, ceil, clamp, round ops

Posted by GitBox <gi...@apache.org>.
masahi merged pull request #5316: [RELAY][PYTORCH]isNan, isinf, isfinite, ceil, clamp, round ops
URL: https://github.com/apache/incubator-tvm/pull/5316
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services