[GitHub] spark pull request #17813: [SPARK-20540][CORE] Fix unstable executor request...

[vanzin <gi...@git.apache.org>]

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17813#discussion_r114164316
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala ---
    @@ -589,8 +605,18 @@ class CoarseGrainedSchedulerBackend(scheduler: TaskSchedulerImpl, val rpcEnv: Rp
           // take into account executors that are pending to be added or removed.
           val adjustTotalExecutors =
             if (!replace) {
    -          doRequestTotalExecutors(
    -            numExistingExecutors + numPendingExecutors - executorsPendingToRemove.size)
    +          requestedTotalExecutors = math.max(requestedTotalExecutors - executorsToKill.size, 0)
    +          if (requestedTotalExecutors !=
    --- End diff --
    
    Won't this cause the message to be logged in the situation you describe in the PR description? Isn't that an "expected" situation? If so I'd demote this message, since users tend to get scared when messages like this one show up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org