[GitHub] brodybits commented on a change in pull request #246: CB-13829 Fix tests that were broken since CB-13237

[GitBox <gi...@apache.org>]

brodybits commented on a change in pull request #246: CB-13829 Fix tests that were broken since CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#discussion_r166685892
 
 

 ##########
 File path: spec/e2e/endtoend.spec.js
 ##########
 @@ -54,34 +71,82 @@ describe('Cordova create and build', function () {
         expect(fs.existsSync(projectFolder)).toBe(true);
     });
 
-    it('spec.2 should build project', function () {
-        shell.exec(buildScriptPath, {silent: true});
-        var packages = shell.ls(appPackagesFolder);
-        expect(packages.filter(function (file) { return file.match(/.*Phone.*\.appx.*/); }).length).toBe(1);
-        expect(packages.filter(function (file) { return file.match(/.*Windows.*\.appx.*/); }).length).toBe(1);
+    // default
+
+    it('spec.2 should build default (win10) project', function () {
 
 Review comment:
   I wonder if this should already be spec.2a?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org