You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@madlib.apache.org by GitBox <gi...@apache.org> on 2021/02/04 01:57:37 UTC

[GitHub] [madlib] fmcquillan99 commented on a change in pull request #534: DL: Various docs changes

fmcquillan99 commented on a change in pull request #534:
URL: https://github.com/apache/madlib/pull/534#discussion_r569888333



##########
File path: src/ports/postgres/modules/deep_learning/keras_model_arch_table.sql_in
##########
@@ -333,7 +333,7 @@ SELECT COUNT(*) FROM model_arch_library;
 <pre class="result">
  count
 -------+
-     1
+     2

Review comment:
       we delete 1 model out of 3 actually, so 2 is correct.
   
   the query just above in step 3 is 
   ```
   SELECT COUNT(*) FROM model_arch_library WHERE model_weights IS NOT NULL;
   ```
   which just counts models that have non-null wts (there are 2), not the total list of models (there are 3 at that point)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org