You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/05/31 21:52:09 UTC

[GitHub] [incubator-druid] Fokko opened a new pull request #7811: Remove explicit snappy-java

Fokko opened a new pull request #7811: Remove explicit snappy-java
URL: https://github.com/apache/incubator-druid/pull/7811
 
 
   I would remove the `snappy-java` dependency from the Parquet project. This dependency is only required if you're using snappy compression, which is just one of the compressions for Parquet.
   
   Besides that, nothing will change because the Parquet plugin requires the Avro plugin, which ships with the library:
   ```
   [INFO] --------< org.apache.druid.extensions:druid-parquet-extensions >--------
   [INFO] Building druid-parquet-extensions 0.16.0-incubating-SNAPSHOT     [34/64]
   [INFO] --------------------------------[ jar ]---------------------------------
   [INFO] 
   [INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ druid-parquet-extensions ---
   [INFO] org.apache.druid.extensions:druid-parquet-extensions:jar:0.16.0-incubating-SNAPSHOT
   [INFO] +- org.apache.druid.extensions:druid-avro-extensions:jar:0.16.0-incubating-SNAPSHOT:provided
   [INFO] |  +- org.apache.avro:avro:jar:1.8.2:provided
   [INFO] |  |  +- com.thoughtworks.paranamer:paranamer:jar:2.7:provided
   [INFO] |  |  \- org.xerial.snappy:snappy-java:jar:1.1.1.3:compile
   ```
   
   However, explicitly adding this to the pom is not correct in my opinion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org