You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Ferenc Szabo (Code Review)" <ge...@cloudera.org> on 2018/09/05 17:24:24 UTC
[kudu-CR] KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.
Ferenc Szabo has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11391
Change subject: KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.
......................................................................
KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations
producer.
Adding new properties for the different parsing error policies.
Deprecating the old ones. Default value constants are not removed as they are
public variables on a public class and it would be an API change.
Adding new test class to test the configuration and behaviour.
Change-Id: I0b352b27583ae9eee6cdbe28a768362bea36e00f
---
M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java
A java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java
2 files changed, 380 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/11391/1
--
To view, visit http://gerrit.cloudera.org:8080/11391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b352b27583ae9eee6cdbe28a768362bea36e00f
Gerrit-Change-Number: 11391
Gerrit-PatchSet: 1
Gerrit-Owner: Ferenc Szabo <fs...@cloudera.com>
[kudu-CR] KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11391 )
Change subject: KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.
......................................................................
Patch Set 4:
(6 comments)
Thanks for the patch - looks great, just some nit feedback from me
http://gerrit.cloudera.org:8080/#/c/11391/4/java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java
File java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java:
http://gerrit.cloudera.org:8080/#/c/11391/4/java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java@138
PS4, Line 138: attempted
s/attempted/produced/ here and elsewhere
http://gerrit.cloudera.org:8080/#/c/11391/4/java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java@148
PS4, Line 148: is still attempted
... is still produced, but does not include the given column
http://gerrit.cloudera.org:8080/#/c/11391/4/java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java@158
PS4, Line 158: operation is still attempted
... and the row is skipped, not producing an operation
http://gerrit.cloudera.org:8080/#/c/11391/4/java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java@159
PS4, Line 159: still attempted
the row is skipped (?)
http://gerrit.cloudera.org:8080/#/c/11391/4/java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java@386
PS4, Line 386: policyString
.toUpperCase() ?
http://gerrit.cloudera.org:8080/#/c/11391/4/java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java
File java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java:
http://gerrit.cloudera.org:8080/#/c/11391/4/java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java@66
PS4, Line 66: public void testMissingColumnThrowsExceptionDeprecated() throws Exception {
: Context additionalContext = new Context();
: additionalContext.put(PATTERN_PROP, TEST_REGEXP_MISSING_COLUMN);
: additionalContext.put(SKIP_MISSING_COLUMN_PROP, String.valueOf(false));
: testThrowsException(additionalContext, ERROR_MSG_MISSING_COLUMN, ROW_MISSING_COLUMN);
: }
:
: @Test
: public void testMissingColumnThrowsException() throws Exception {
: Context additionalContext = new Context();
: additionalContext.put(PATTERN_PROP, TEST_REGEXP_MISSING_COLUMN);
: additionalContext.put(MISSING_COLUMN_POLICY_PROP, POLICY_REJECT);
: testThrowsException(additionalContext, ERROR_MSG_MISSING_COLUMN, ROW_MISSING_COLUMN);
: }
nit: did you consider combining these deprecated tests to cut down on duplication? i.e.
@Test
public void testMissionColumnThrowsException() throws Exception {
for (String prop : {String.valueOf(false), POLICY_REJECT}) {
Context additionalContext = new Context();
additionalContext.put(PATTERN_PROP, TEST_REGEXP_MISSING_COLUMN);
additionalContext.put(MISSING_COLUMN_POLICY_PROP, POLICY_REJECT);
testThrowsException(additionalContext, ERROR_MSG_MISSING_COLUMN, ROW_MISSING_COLUMN);
}
}
Alternatively we could parameterize it with JUnit.
However I'm not sure if it's straightforward or not, and since you probably already thought of it and decided it wasn't worth the effort, I'm fine with not doing that. Just thought I would ask if you think it's worth doing that.
--
To view, visit http://gerrit.cloudera.org:8080/11391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b352b27583ae9eee6cdbe28a768362bea36e00f
Gerrit-Change-Number: 11391
Gerrit-PatchSet: 4
Gerrit-Owner: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 20 Sep 2018 23:56:39 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.
Posted by "Ferenc Szabo (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11391
to look at the new patch set (#5).
Change subject: KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.
......................................................................
KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations
producer.
Adding new properties for the different parsing error policies.
Deprecating the old ones. Default value constants are not removed as they are
public variables on a public class and it would be an API change.
Adding new test class to test the configuration and behaviour.
Change-Id: I0b352b27583ae9eee6cdbe28a768362bea36e00f
---
M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java
A java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java
2 files changed, 393 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/11391/5
--
To view, visit http://gerrit.cloudera.org:8080/11391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0b352b27583ae9eee6cdbe28a768362bea36e00f
Gerrit-Change-Number: 11391
Gerrit-PatchSet: 5
Gerrit-Owner: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.
Posted by "Ferenc Szabo (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11391
to look at the new patch set (#4).
Change subject: KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.
......................................................................
KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations
producer.
Adding new properties for the different parsing error policies.
Deprecating the old ones. Default value constants are not removed as they are
public variables on a public class and it would be an API change.
Adding new test class to test the configuration and behaviour.
Change-Id: I0b352b27583ae9eee6cdbe28a768362bea36e00f
---
M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java
A java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java
2 files changed, 389 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/11391/4
--
To view, visit http://gerrit.cloudera.org:8080/11391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0b352b27583ae9eee6cdbe28a768362bea36e00f
Gerrit-Change-Number: 11391
Gerrit-PatchSet: 4
Gerrit-Owner: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11391 )
Change subject: KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11391/3/java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java
File java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java:
http://gerrit.cloudera.org:8080/#/c/11391/3/java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java@364
PS3, Line 364: default:
Should a runtime exception be thrown if no policy is defined?
http://gerrit.cloudera.org:8080/#/c/11391/3/java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java
File java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java:
http://gerrit.cloudera.org:8080/#/c/11391/3/java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java@50
PS3, Line 50: public ExpectedException thrown= ExpectedException.none();
nit: space before -=
--
To view, visit http://gerrit.cloudera.org:8080/11391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b352b27583ae9eee6cdbe28a768362bea36e00f
Gerrit-Change-Number: 11391
Gerrit-PatchSet: 3
Gerrit-Owner: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 10 Sep 2018 17:35:58 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.
Posted by "Ferenc Szabo (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11391
to look at the new patch set (#3).
Change subject: KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.
......................................................................
KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations
producer.
Adding new properties for the different parsing error policies.
Deprecating the old ones. Default value constants are not removed as they are
public variables on a public class and it would be an API change.
Adding new test class to test the configuration and behaviour.
Change-Id: I0b352b27583ae9eee6cdbe28a768362bea36e00f
---
M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java
A java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java
2 files changed, 380 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/11391/3
--
To view, visit http://gerrit.cloudera.org:8080/11391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0b352b27583ae9eee6cdbe28a768362bea36e00f
Gerrit-Change-Number: 11391
Gerrit-PatchSet: 3
Gerrit-Owner: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11391 )
Change subject: KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b352b27583ae9eee6cdbe28a768362bea36e00f
Gerrit-Change-Number: 11391
Gerrit-PatchSet: 5
Gerrit-Owner: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 25 Sep 2018 21:35:03 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.
Posted by "Ferenc Szabo (Code Review)" <ge...@cloudera.org>.
Ferenc Szabo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11391 )
Change subject: KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.
......................................................................
Patch Set 4:
(2 comments)
Thanks for the reviews!
See my comments below.
http://gerrit.cloudera.org:8080/#/c/11391/3/java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java
File java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java:
http://gerrit.cloudera.org:8080/#/c/11391/3/java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java@364
PS3, Line 364: default:
> Should a runtime exception be thrown if no policy is defined?
only a valid ParseErrorPolicy can come out from getParseErrorPolicyCheckingDeprecatedProperty() so this default case is only for checkstyle
http://gerrit.cloudera.org:8080/#/c/11391/4/java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java
File java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java:
http://gerrit.cloudera.org:8080/#/c/11391/4/java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java@66
PS4, Line 66: public void testMissingColumnThrowsExceptionDeprecated() throws Exception {
: Context additionalContext = new Context();
: additionalContext.put(PATTERN_PROP, TEST_REGEXP_MISSING_COLUMN);
: additionalContext.put(SKIP_MISSING_COLUMN_PROP, String.valueOf(false));
: testThrowsException(additionalContext, ERROR_MSG_MISSING_COLUMN, ROW_MISSING_COLUMN);
: }
:
: @Test
: public void testMissingColumnThrowsException() throws Exception {
: Context additionalContext = new Context();
: additionalContext.put(PATTERN_PROP, TEST_REGEXP_MISSING_COLUMN);
: additionalContext.put(MISSING_COLUMN_POLICY_PROP, POLICY_REJECT);
: testThrowsException(additionalContext, ERROR_MSG_MISSING_COLUMN, ROW_MISSING_COLUMN);
: }
> nit: did you consider combining these deprecated tests to cut down on dupli
Doing multiple assertions in one test case would be a bad practice, as you would have to investigate test failures to see which assertion failed. The other reason why I had the ...Deprecated tests is that they can be deleted with the deprecated parameters.
As this test class has 4 type of tests, the parametrized version would require a test method that is more complex than what we have now and the parameter array would be long and hard to read.
I was considering to make this test parametrized and at the end the way it is now seemed to be the most readable. It is long and has some code repetition in it but the methods are short, simple and have descriptive names. And have only one reason to fail.
--
To view, visit http://gerrit.cloudera.org:8080/11391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b352b27583ae9eee6cdbe28a768362bea36e00f
Gerrit-Change-Number: 11391
Gerrit-PatchSet: 4
Gerrit-Owner: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 25 Sep 2018 09:27:10 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11391 )
Change subject: KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/11391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b352b27583ae9eee6cdbe28a768362bea36e00f
Gerrit-Change-Number: 11391
Gerrit-PatchSet: 4
Gerrit-Owner: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 11 Sep 2018 13:48:41 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.
Posted by "Ferenc Szabo (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11391
to look at the new patch set (#2).
Change subject: KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.
......................................................................
KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations
producer.
Adding new properties for the different parsing error policies.
Deprecating the old ones. Default value constants are not removed as they are
public variables on a public class and it would be an API change.
Adding new test class to test the configuration and behaviour.
Change-Id: I0b352b27583ae9eee6cdbe28a768362bea36e00f
---
M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java
A java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java
2 files changed, 380 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/11391/2
--
To view, visit http://gerrit.cloudera.org:8080/11391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0b352b27583ae9eee6cdbe28a768362bea36e00f
Gerrit-Change-Number: 11391
Gerrit-PatchSet: 2
Gerrit-Owner: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11391 )
Change subject: KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.
......................................................................
KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations
producer.
Adding new properties for the different parsing error policies.
Deprecating the old ones. Default value constants are not removed as they are
public variables on a public class and it would be an API change.
Adding new test class to test the configuration and behaviour.
Change-Id: I0b352b27583ae9eee6cdbe28a768362bea36e00f
Reviewed-on: http://gerrit.cloudera.org:8080/11391
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java
A java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java
2 files changed, 393 insertions(+), 21 deletions(-)
Approvals:
Kudu Jenkins: Verified
Mike Percy: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b352b27583ae9eee6cdbe28a768362bea36e00f
Gerrit-Change-Number: 11391
Gerrit-PatchSet: 6
Gerrit-Owner: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>