You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/14 08:22:31 UTC

[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #11910: Print property loaded from common.properties

caishunfeng commented on code in PR #11910:
URL: https://github.com/apache/dolphinscheduler/pull/11910#discussion_r970483039


##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/PropertyUtils.java:
##########
@@ -48,7 +51,12 @@ private PropertyUtils() {
     public static synchronized void loadPropertyFile(String... propertyFiles) {
         for (String fileName : propertyFiles) {
             try (InputStream fis = PropertyUtils.class.getResourceAsStream(fileName);) {
-                properties.load(fis);
+                Properties subProperties = new Properties();
+                subProperties.load(fis);
+                subProperties.forEach((k, v) -> {
+                    logger.info("Get property from {}: {} -> {}", fileName, k, v);

Review Comment:
   ```suggestion
                       logger.info("Get property {} -> {}",  k, v);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org