You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/03/24 09:52:15 UTC

[GitHub] [arrow-rs] tustvold opened a new issue, #3928: Make ObjectMeta Non Exhaustive

tustvold opened a new issue, #3928:
URL: https://github.com/apache/arrow-rs/issues/3928

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   <!--
   A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] 
   (This section helps Arrow developers understand the context and *why* for this feature, in addition to  the *what*)
   -->
   
   Currently the fields on `ObjectMeta` are public, making a breaking change to add additional metadata, such as in https://github.com/apache/arrow-rs/issues/2240
   
   **Describe the solution you'd like**
   <!--
   A clear and concise description of what you want to happen.
   -->
   
   I would like to make `ObjectMeta` [non_exhaustive](https://doc.rust-lang.org/reference/attributes/type_system.html#the-non_exhaustive-attribute) to allow adding new fields without requiring a breaking change. 
   
   This will require adding a constructor to `ObjectMeta` to allow it to be safely constructed outside of the crate.
   
   **Describe alternatives you've considered**
   <!--
   A clear and concise description of any alternative solutions or features you've considered.
   -->
   
   **Additional context**
   <!--
   Add any other context or screenshots about the feature request here.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold closed issue #3928: Make ObjectMeta Non Exhaustive

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed issue #3928: Make ObjectMeta Non Exhaustive
URL: https://github.com/apache/arrow-rs/issues/3928


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold closed issue #3928: Make ObjectMeta Non Exhaustive

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed issue #3928: Make ObjectMeta Non Exhaustive
URL: https://github.com/apache/arrow-rs/issues/3928


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold commented on issue #3928: Make ObjectMeta Non Exhaustive

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on issue #3928:
URL: https://github.com/apache/arrow-rs/issues/3928#issuecomment-1482548268

   Thinking about this a bit more, this is actually a feature, in that it forces implementations to consistently populate all the fields


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org