You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/08/20 09:27:58 UTC
[GitHub] [echarts-doc] jiawulin001 opened a new pull request, #283: fix: fix default type of axisPointer in doc
jiawulin001 opened a new pull request, #283:
URL: https://github.com/apache/echarts-doc/pull/283
The default type of axisPointer is 'dashed' in [code](https://github.com/apache/echarts/blob/f2e8379c79341419a52cc6f43b669a8fb1d79dfb/src/component/axisPointer/AxisPointerModel.ts#L105)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] plainheart commented on a diff in pull request #283: fix: fix default type of axisPointer in doc
Posted by GitBox <gi...@apache.org>.
plainheart commented on code in PR #283:
URL: https://github.com/apache/echarts-doc/pull/283#discussion_r950795489
##########
zh/option/partial/axisPointer-common.md:
##########
@@ -265,7 +265,7 @@ label 距离轴的距离。
prefix = "#" + ${prefix},
defaultColor = "#555",
defaultWidth = 1,
- defaultType = 'solid'
+ defaultType = 'dashed'
Review Comment:
`defaultColor` looks wrong as well. And the same changes should be applied to the English documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org