You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/10/22 10:58:46 UTC
[GitHub] [apisix] bisakhmondal opened a new pull request #5318: feat: integrating api7/grpc_server_example as git submodule for grpc proxy testing
bisakhmondal opened a new pull request #5318:
URL: https://github.com/apache/apisix/pull/5318
### What this PR does / why we need it:
As proposed in the community maillist - this repository has been added with Apache APISIX as a git submodule inside `t/` directory to facilitate grpc proxy testing at ease.
Info: https://github.com/apache/apisix/issues/3601#issuecomment-946890377
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bisakhmondal commented on a change in pull request #5318: feat: integrating api7/grpc_server_example as git submodule for grpc proxy testing
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on a change in pull request #5318:
URL: https://github.com/apache/apisix/pull/5318#discussion_r734455002
##########
File path: .github/workflows/centos7-ci.yml
##########
@@ -25,6 +25,11 @@ jobs:
with:
submodules: recursive
+ - name: Setup Go
+ uses: actions/setup-go@v2.1.4
+ with:
+ go-version: "1.15"
+
Review comment:
Turns out, this won't work!!
We are running Centos as a container on top of Ubuntu, so go needs to be installed inside the docker container : )
Damn!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bisakhmondal commented on pull request #5318: feat: integrating api7/grpc_server_example as git submodule for grpc proxy testing
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on pull request #5318:
URL: https://github.com/apache/apisix/pull/5318#issuecomment-949627906
> Could you merge this PR into #5319, and close it? So we have less PRs to approve and make the progress faster.
That's a good suggestion. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bisakhmondal removed a comment on pull request #5318: feat: integrating api7/grpc_server_example as git submodule for grpc proxy testing
Posted by GitBox <gi...@apache.org>.
bisakhmondal removed a comment on pull request #5318:
URL: https://github.com/apache/apisix/pull/5318#issuecomment-949616426
cc @spacewander. feel free to review anytime when you are free.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bisakhmondal commented on pull request #5318: feat: integrating api7/grpc_server_example as git submodule for grpc proxy testing
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on pull request #5318:
URL: https://github.com/apache/apisix/pull/5318#issuecomment-949616426
cc @spacewander. feel free to review anytime when you are free.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bisakhmondal commented on a change in pull request #5318: feat: integrating api7/grpc_server_example as git submodule for grpc proxy testing
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on a change in pull request #5318:
URL: https://github.com/apache/apisix/pull/5318#discussion_r734455422
##########
File path: .github/workflows/centos7-ci.yml
##########
@@ -25,6 +25,11 @@ jobs:
with:
submodules: recursive
+ - name: Setup Go
+ uses: actions/setup-go@v2.1.4
+ with:
+ go-version: "1.15"
+
Review comment:
https://github.com/apache/apisix/runs/3974913574?check_suite_focus=true#step:9:2342 the reason it can't find go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bisakhmondal closed pull request #5318: feat: integrating api7/grpc_server_example as git submodule for grpc proxy testing
Posted by GitBox <gi...@apache.org>.
bisakhmondal closed pull request #5318:
URL: https://github.com/apache/apisix/pull/5318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #5318: feat: integrating api7/grpc_server_example as git submodule for grpc proxy testing
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #5318:
URL: https://github.com/apache/apisix/pull/5318#issuecomment-949615156
Could you merge this PR into https://github.com/apache/apisix/pull/5319, and close it?
So we have less PRs to approve and make the progress faster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org