You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Marshall (Code Review)" <ge...@cloudera.org> on 2019/04/12 20:38:29 UTC

[Impala-ASF-CR] IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2 

Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13003


Change subject: IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2
......................................................................

IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2

When impala-shell is used to connect to an impala cluster with
--ssl_minimum_version=tlsv1.2, if the Python version being used is
< 2.7.9 the connection will fail due to a limitation of TSSLSocket.
See IMPALA-6990 for more details.

Currently, when this occurs, the error that gets printed is "EOF
occurred in violation of protocol", which is not very helpful. This
patch detect this situation and prints a more informative warning.

Testing:
- Updated test_tls_v12 so that instead of being skipped on affected
  platforms, it runs and checks for the presence of the warning.

Change-Id: I3feddaccb9be3a15220ce9e59aa7ed41d41b8ab6
---
M shell/impala_shell.py
M tests/custom_cluster/test_client_ssl.py
2 files changed, 10 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/13003/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3feddaccb9be3a15220ce9e59aa7ed41d41b8ab6
Gerrit-Change-Number: 13003
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>

[Impala-ASF-CR] IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13003 )

Change subject: IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4033/


-- 
To view, visit http://gerrit.cloudera.org:8080/13003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3feddaccb9be3a15220ce9e59aa7ed41d41b8ab6
Gerrit-Change-Number: 13003
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Apr 2019 21:53:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13003 )

Change subject: IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/13003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3feddaccb9be3a15220ce9e59aa7ed41d41b8ab6
Gerrit-Change-Number: 13003
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Apr 2019 23:19:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13003 )

Change subject: IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4033/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/13003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3feddaccb9be3a15220ce9e59aa7ed41d41b8ab6
Gerrit-Change-Number: 13003
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Apr 2019 16:51:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13003 )

Change subject: IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3feddaccb9be3a15220ce9e59aa7ed41d41b8ab6
Gerrit-Change-Number: 13003
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Apr 2019 16:51:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13003 )

Change subject: IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13003/1/shell/impala_shell.py
File shell/impala_shell.py:

http://gerrit.cloudera.org:8080/#/c/13003/1/shell/impala_shell.py@844
PS1, Line 844:           and "EOF occurred in violation of protocol" in str(e):
Using pure string matching feels hacky but I can't think of anything concrete that will go wrong, so I guess this is fine :).



-- 
To view, visit http://gerrit.cloudera.org:8080/13003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3feddaccb9be3a15220ce9e59aa7ed41d41b8ab6
Gerrit-Change-Number: 13003
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Apr 2019 15:40:47 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2

Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13003 )

Change subject: IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2
......................................................................


Patch Set 2:

gvo failed due to IMPALA-8430


-- 
To view, visit http://gerrit.cloudera.org:8080/13003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3feddaccb9be3a15220ce9e59aa7ed41d41b8ab6
Gerrit-Change-Number: 13003
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Apr 2019 21:56:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13003 )

Change subject: IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2760/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3feddaccb9be3a15220ce9e59aa7ed41d41b8ab6
Gerrit-Change-Number: 13003
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Apr 2019 21:22:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13003 )

Change subject: IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2
......................................................................

IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2

When impala-shell is used to connect to an impala cluster with
--ssl_minimum_version=tlsv1.2, if the Python version being used is
< 2.7.9 the connection will fail due to a limitation of TSSLSocket.
See IMPALA-6990 for more details.

Currently, when this occurs, the error that gets printed is "EOF
occurred in violation of protocol", which is not very helpful. This
patch detect this situation and prints a more informative warning.

Testing:
- Updated test_tls_v12 so that instead of being skipped on affected
  platforms, it runs and checks for the presence of the warning.

Change-Id: I3feddaccb9be3a15220ce9e59aa7ed41d41b8ab6
Reviewed-on: http://gerrit.cloudera.org:8080/13003
Reviewed-by: Thomas Marshall <tm...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M shell/impala_shell.py
M tests/custom_cluster/test_client_ssl.py
2 files changed, 10 insertions(+), 3 deletions(-)

Approvals:
  Thomas Marshall: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3feddaccb9be3a15220ce9e59aa7ed41d41b8ab6
Gerrit-Change-Number: 13003
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13003 )

Change subject: IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13003/1/shell/impala_shell.py
File shell/impala_shell.py:

http://gerrit.cloudera.org:8080/#/c/13003/1/shell/impala_shell.py@843
PS1, Line 843: ,
flake8: E231 missing whitespace after ','


http://gerrit.cloudera.org:8080/#/c/13003/1/shell/impala_shell.py@843
PS1, Line 843: ,
flake8: E231 missing whitespace after ','



-- 
To view, visit http://gerrit.cloudera.org:8080/13003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3feddaccb9be3a15220ce9e59aa7ed41d41b8ab6
Gerrit-Change-Number: 13003
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Apr 2019 20:39:14 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2

Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13003 )

Change subject: IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2
......................................................................


Patch Set 3: Code-Review+2

carrying forward


-- 
To view, visit http://gerrit.cloudera.org:8080/13003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3feddaccb9be3a15220ce9e59aa7ed41d41b8ab6
Gerrit-Change-Number: 13003
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Apr 2019 18:00:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13003 )

Change subject: IMPALA-8407: Warn when Impala shell fails to connect due to tlsv1.2
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4043/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/13003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3feddaccb9be3a15220ce9e59aa7ed41d41b8ab6
Gerrit-Change-Number: 13003
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Apr 2019 18:01:17 +0000
Gerrit-HasComments: No