TC 3.3: Tabs/Spaces/Indentiation: NOT A CALL FOR DEBATE OR FLAME WAR!

[Bojan Smojver <bo...@binarix.com>]

I've read the thread about tabs/spaces/indentiation in Tomcat code and
it seems that at least TC 4 people are going with 4 spaces instead of
tabs (judging by comments from Craig).

Does that apply to TC 3.3 as well?

Bojan

PS. I've noticed that a lot of TC 3.3 code still uses tabs, so when
patching, I might convert into spaces at the same time and comment
appropriately.

CVS question: Almost off topic

[Bojan Smojver <bo...@binarix.com>]

I've committed a patch to the repository today, expecting an automatic
e-mail to the tomcat-dev list when the commit happens. But it never did,
although the commit went through OK.

After searching the CVS manual for clues, I bumped into -i option for
modules, but that seems like an admin/setup kind of thing.

I must be doing something funny...

Bojan

PS. The commit was done with a simple:

cvs -d userid@cvs.apache.org:/home/cvs commit -m Message File

Re: TC 3.3: Tabs/Spaces/Indentiation: NOT A CALL FOR DEBATE OR FLAMEWAR!

[cm...@yahoo.com]

On Tue, 25 Sep 2001, Bojan Smojver wrote:

> No probs. I can use tabs + 4 spaces for indentation. No need to overhaul
> the whole thing if people aren't complaining.
>
> Bojan
>
> PS. Normally I use spaces in my code and when I produced the last patch,
> I've noticed that things are a bit 'out of whack'. That's why I asked
> the question in the first place...

Well, you can/should use spaces - and avoid beeing flamed by the space
police.

But if you preffer using tabs - make sure you use 8 spaces, and don't
change files just to replace tabs with spaces.


Costin

Re: TC 3.3: Tabs/Spaces/Indentiation: NOT A CALL FOR DEBATE OR FLAMEWAR!

[Bojan Smojver <bo...@binarix.com>]

cmanolache@yahoo.com wrote:
> 
> On Tue, 25 Sep 2001, Bojan Smojver wrote:
> 
> > I've read the thread about tabs/spaces/indentiation in Tomcat code and
> > it seems that at least TC 4 people are going with 4 spaces instead of
> > tabs (judging by comments from Craig).
> >
> > Does that apply to TC 3.3 as well?
> 
> > PS. I've noticed that a lot of TC 3.3 code still uses tabs, so when
> > patching, I might convert into spaces at the same time and comment
> > appropriately.
> 
> TC3.3 is using tabs, with 4 space indentation and tab==8 spaces.
> As long as you convert with tab==8 spaces, it'll be fine.
> 
> AFAIK there is no official rule or vote on this.

No probs. I can use tabs + 4 spaces for indentation. No need to overhaul
the whole thing if people aren't complaining.

Bojan

PS. Normally I use spaces in my code and when I produced the last patch,
I've noticed that things are a bit 'out of whack'. That's why I asked
the question in the first place...

Re: TC 3.3: Tabs/Spaces/Indentiation: NOT A CALL FOR DEBATE OR FLAME WAR!

[cm...@yahoo.com]

On Tue, 25 Sep 2001, Bojan Smojver wrote:

> I've read the thread about tabs/spaces/indentiation in Tomcat code and
> it seems that at least TC 4 people are going with 4 spaces instead of
> tabs (judging by comments from Craig).
>
> Does that apply to TC 3.3 as well?

> PS. I've noticed that a lot of TC 3.3 code still uses tabs, so when
> patching, I might convert into spaces at the same time and comment
> appropriately.

TC3.3 is using tabs, with 4 space indentation and tab==8 spaces.
As long as you convert with tab==8 spaces, it'll be fine.

AFAIK there is no official rule or vote on this.

Costin