You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by timtay-microsoft <gi...@git.apache.org> on 2017/12/13 19:02:01 UTC

[GitHub] qpid-proton-j pull request #13: Added API to Transport interface to allow cu...

GitHub user timtay-microsoft opened a pull request:

    https://github.com/apache/qpid-proton-j/pull/13

    Added API to Transport interface to allow custom sasl implementations…

    … to be provided
    
    Fixed relationship between Sasl interface and SaslImpl such that SaslImpl does not implement more than the interface it should derive from. Made transport layer treat Sasl as an interface instead of the concrete SaslImpl instance

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/timtay-microsoft/qpid-proton-j master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-proton-j/pull/13.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13
    
----
commit 22a016300b40b85c705b31fd23c0900744a7468c
Author: timtay-microsoft <ti...@microsoft.com>
Date:   2017-12-13T18:59:22Z

    Added api to Transport interface to allow custom sasl implementations to be provided
    
    Fixed relationship between Sasl interface and SaslImpl such that SaslImpl does not implement more than the interface it should derive from. Made transport layer treat Sasl as an interface instead of the concrete SaslImpl instance

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] qpid-proton-j pull request #13: Added API to Transport interface to allow cu...

Posted by timtay-microsoft <gi...@git.apache.org>.
Github user timtay-microsoft closed the pull request at:

    https://github.com/apache/qpid-proton-j/pull/13


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] qpid-proton-j issue #13: Added API to Transport interface to allow custom sa...

Posted by gemmellr <gi...@git.apache.org>.
Github user gemmellr commented on the issue:

    https://github.com/apache/qpid-proton-j/pull/13
  
    My immediate reaction is that this isn't acceptable. It exposes various APIs that are considered part of the implementation only, and then further exposes additional implementation detail presumably to subclass it, which it similarly isn't intended for.
    
    Given the general nature of the engines Sasl object/api, would I be right to assume the reason you want this ability is mainly just due to limitations imposed from use within the Reactor? If so perhaps theres a nicer reactor-only approach that can be explored, or alternatively perhaps theres a neat way to tie it in with the existing layering exposed by TransportInternal for similar reactor related layering reasons.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] qpid-proton-j issue #13: Added API to Transport interface to allow custom sa...

Posted by timtay-microsoft <gi...@git.apache.org>.
Github user timtay-microsoft commented on the issue:

    https://github.com/apache/qpid-proton-j/pull/13
  
    https://issues.apache.org/jira/browse/PROTON-1718


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] qpid-proton-j issue #13: Added API to Transport interface to allow custom sa...

Posted by gemmellr <gi...@git.apache.org>.
Github user gemmellr commented on the issue:

    https://github.com/apache/qpid-proton-j/pull/13
  
    For completeness, a different change was made via https://issues.apache.org/jira/browse/PROTON-1736 in commit 17cef9ace9a7c75901d517f951ae1d4610819436. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org