You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/10/23 23:07:05 UTC
[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #1497: HDDS-4345. Replace the deprecated Lock method
xiaoyuyao commented on a change in pull request #1497:
URL: https://github.com/apache/hadoop-ozone/pull/1497#discussion_r511191225
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/PrefixManagerImpl.java
##########
@@ -253,18 +253,18 @@ public boolean checkAccess(OzoneObj ozObject, RequestContext context)
return true;
}
} finally {
- metadataManager.getLock().releaseLock(PREFIX_LOCK, prefixPath);
+ metadataManager.getLock().releaseWriteLock(PREFIX_LOCK, prefixPath);
}
}
@Override
public List<OmPrefixInfo> getLongestPrefixPath(String path) {
String prefixPath = prefixTree.getLongestPrefix(path);
- metadataManager.getLock().acquireLock(PREFIX_LOCK, prefixPath);
+ metadataManager.getLock().acquireWriteLock(PREFIX_LOCK, prefixPath);
Review comment:
Same as above.
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/PrefixManagerImpl.java
##########
@@ -232,7 +232,7 @@ public boolean checkAccess(OzoneObj ozObject, RequestContext context)
Objects.requireNonNull(context);
String prefixPath = ozObject.getPath();
- metadataManager.getLock().acquireLock(PREFIX_LOCK, prefixPath);
+ metadataManager.getLock().acquireWriteLock(PREFIX_LOCK, prefixPath);
Review comment:
Should we use acquireReadLock here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org