[jira] [Commented] (ARROW-14461) [R] write_dataset() allows users to pass invalid compression argument values

["Dragoș Moldovan-Grünfeld (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-14461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477230#comment-17477230 ] 

Dragoș Moldovan-Grünfeld commented on ARROW-14461:
--------------------------------------------------

I think this is more general because {{compression}} in the example above is passed via {{...}} {{dot-dot-dot}}. Therefore we can pass (without any complaint) all sorts of arguments that do not make sense since neither {{write_dataset()}}, nor the downstream functions it passes the {{...}} to seem to check them.

For example, we can run the line below without any complaint. The problematic argument never gets evaluated.
{code:R}
td <- tempfile()
dir.create(td)
write_dataset(iris, td, format = "feather", arg_that_doesnt_make_sense = "blah-blah")
{code}

> [R] write_dataset() allows users to pass invalid compression argument values
> ----------------------------------------------------------------------------
>
>                 Key: ARROW-14461
>                 URL: https://issues.apache.org/jira/browse/ARROW-14461
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: R
>            Reporter: Nicola Crane
>            Assignee: Dragoș Moldovan-Grünfeld
>            Priority: Major
>
> {{write_dataset()}} allows passing of compression types not compatible with file types, e.g. specifying Snappy compression for Feather files.
> {code:r}
> td <- tempfile()
> dir.create(td)
> write_dataset(iris, td, format = "feather", compression = "snappy")
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)