[GitHub] [knox] risdenk commented on a change in pull request #307: KNOX-2304 - CM discovery cluster config monitor needs to be aware of …

[GitBox <gi...@apache.org>]

risdenk commented on a change in pull request #307: KNOX-2304 - CM discovery cluster config monitor needs to be aware of …
URL: https://github.com/apache/knox/pull/307#discussion_r405524259
 
 

 ##########
 File path: gateway-discovery-cm/src/main/java/org/apache/knox/gateway/topology/discovery/cm/monitor/PollingConfigurationAnalyzer.java
 ##########
 @@ -365,12 +375,32 @@ private DiscoveryApiClient getApiClient(final ServiceDiscoveryConfig discoveryCo
                                                clusterName,
                                                lastTimestamp);
     for (ApiEvent event : events) {
-      restartEvents.add(new RestartEvent(event));
+      List<ApiEventAttribute> attributes = event.getAttributes();
+      Map<String,Object> map = getAttributeMap(attributes);
 
 Review comment:
   Why not loop through the ApiEventAttribute list directly? There doesn't seem to be any value in converting to a Map. You break the map apart in the same way you would have to interrogate the ApiEventAttribute anyway.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services