You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/04 13:03:23 UTC
[GitHub] [flink] JingsongLi opened a new pull request #12485: [FLINK-18130][hive][fs-connector] File name conflict for different jobs in filesystem/hive sink
JingsongLi opened a new pull request #12485:
URL: https://github.com/apache/flink/pull/12485
## What is the purpose of the change
The sink of different jobs (or the same SQL runs multiple times) will produce the same file name, the rename will fail, and different file systems will produce different results:
- HadoopFileSystem: ignore new data.
- LocalFileSystem: overwrite old data.
## Brief change log
We can add UUID to prefix, make sure there is no conflict between jobs.
## Verifying this change
- `HiveTableSinkITCase.testBatchAppend`
- `HiveTableSinkITCase.testStreamingAppend`
- `FileSystemITCaseBase.testInsertAppend`
- `FileSystemITCaseBase.testInsertOverwrite`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12485: [FLINK-18130][hive][fs-connector] File name conflict for different jobs in filesystem/hive sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12485:
URL: https://github.com/apache/flink/pull/12485#issuecomment-638848123
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7fe7332d4767bbfb996e86f1b59d99c8c4713192",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2737",
"triggerID" : "7fe7332d4767bbfb996e86f1b59d99c8c4713192",
"triggerType" : "PUSH"
}, {
"hash" : "fa51d430e64af7aa9d18cc5f463218aa91bf0d96",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2775",
"triggerID" : "fa51d430e64af7aa9d18cc5f463218aa91bf0d96",
"triggerType" : "PUSH"
}, {
"hash" : "765ffd5d614376c2fde93440c9c904a80e1eab94",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2801",
"triggerID" : "765ffd5d614376c2fde93440c9c904a80e1eab94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 765ffd5d614376c2fde93440c9c904a80e1eab94 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2801)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12485: [FLINK-18130][hive][fs-connector] File name conflict for different jobs in filesystem/hive sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12485:
URL: https://github.com/apache/flink/pull/12485#issuecomment-638848123
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7fe7332d4767bbfb996e86f1b59d99c8c4713192",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2737",
"triggerID" : "7fe7332d4767bbfb996e86f1b59d99c8c4713192",
"triggerType" : "PUSH"
}, {
"hash" : "fa51d430e64af7aa9d18cc5f463218aa91bf0d96",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2775",
"triggerID" : "fa51d430e64af7aa9d18cc5f463218aa91bf0d96",
"triggerType" : "PUSH"
}, {
"hash" : "765ffd5d614376c2fde93440c9c904a80e1eab94",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2801",
"triggerID" : "765ffd5d614376c2fde93440c9c904a80e1eab94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa51d430e64af7aa9d18cc5f463218aa91bf0d96 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2775)
* 765ffd5d614376c2fde93440c9c904a80e1eab94 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2801)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12485: [FLINK-18130][hive][fs-connector] File name conflict for different jobs in filesystem/hive sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12485:
URL: https://github.com/apache/flink/pull/12485#issuecomment-638848123
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7fe7332d4767bbfb996e86f1b59d99c8c4713192",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2737",
"triggerID" : "7fe7332d4767bbfb996e86f1b59d99c8c4713192",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7fe7332d4767bbfb996e86f1b59d99c8c4713192 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2737)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12485: [FLINK-18130][hive][fs-connector] File name conflict for different jobs in filesystem/hive sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12485:
URL: https://github.com/apache/flink/pull/12485#issuecomment-638848123
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7fe7332d4767bbfb996e86f1b59d99c8c4713192",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2737",
"triggerID" : "7fe7332d4767bbfb996e86f1b59d99c8c4713192",
"triggerType" : "PUSH"
}, {
"hash" : "fa51d430e64af7aa9d18cc5f463218aa91bf0d96",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2775",
"triggerID" : "fa51d430e64af7aa9d18cc5f463218aa91bf0d96",
"triggerType" : "PUSH"
}, {
"hash" : "765ffd5d614376c2fde93440c9c904a80e1eab94",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2801",
"triggerID" : "765ffd5d614376c2fde93440c9c904a80e1eab94",
"triggerType" : "PUSH"
}, {
"hash" : "8f5f67699dfce0b311bf197f3d26df4ac16fa6a0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2892",
"triggerID" : "8f5f67699dfce0b311bf197f3d26df4ac16fa6a0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 765ffd5d614376c2fde93440c9c904a80e1eab94 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2801)
* 8f5f67699dfce0b311bf197f3d26df4ac16fa6a0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2892)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12485: [FLINK-18130][hive][fs-connector] File name conflict for different jobs in filesystem/hive sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12485:
URL: https://github.com/apache/flink/pull/12485#issuecomment-638848123
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7fe7332d4767bbfb996e86f1b59d99c8c4713192",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2737",
"triggerID" : "7fe7332d4767bbfb996e86f1b59d99c8c4713192",
"triggerType" : "PUSH"
}, {
"hash" : "fa51d430e64af7aa9d18cc5f463218aa91bf0d96",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2775",
"triggerID" : "fa51d430e64af7aa9d18cc5f463218aa91bf0d96",
"triggerType" : "PUSH"
}, {
"hash" : "765ffd5d614376c2fde93440c9c904a80e1eab94",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2801",
"triggerID" : "765ffd5d614376c2fde93440c9c904a80e1eab94",
"triggerType" : "PUSH"
}, {
"hash" : "8f5f67699dfce0b311bf197f3d26df4ac16fa6a0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8f5f67699dfce0b311bf197f3d26df4ac16fa6a0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 765ffd5d614376c2fde93440c9c904a80e1eab94 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2801)
* 8f5f67699dfce0b311bf197f3d26df4ac16fa6a0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on pull request #12485: [FLINK-18130][hive][fs-connector] File name conflict for different jobs in filesystem/hive sink
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on pull request #12485:
URL: https://github.com/apache/flink/pull/12485#issuecomment-641043960
Thanks @gaoyunhaii for review, merging...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #12485: [FLINK-18130][hive][fs-connector] File name conflict for different jobs in filesystem/hive sink
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #12485:
URL: https://github.com/apache/flink/pull/12485#discussion_r436445157
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/PartitionLoader.java
##########
@@ -113,12 +113,7 @@ private void renameFiles(List<Path> srcDirs, Path destDir) throws Exception {
for (FileStatus srcFile : srcFiles) {
Path srcPath = srcFile.getPath();
Path destPath = new Path(destDir, srcPath.getName());
- int count = 1;
- while (!fs.rename(srcPath, destPath)) {
- String name = srcPath.getName() + "_copy_" + count;
- destPath = new Path(destDir, name);
- count++;
- }
+ fs.rename(srcPath, destPath);
Review comment:
The comment is out of date, the overwrite is occurred in `overwrite(Path)` method instead of here.
Now it is consistent with `HadoopRecoverableFsDataOutputStream.commit`.
I will update comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12485: [FLINK-18130][hive][fs-connector] File name conflict for different jobs in filesystem/hive sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12485:
URL: https://github.com/apache/flink/pull/12485#issuecomment-638848123
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7fe7332d4767bbfb996e86f1b59d99c8c4713192",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2737",
"triggerID" : "7fe7332d4767bbfb996e86f1b59d99c8c4713192",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7fe7332d4767bbfb996e86f1b59d99c8c4713192 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2737)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on pull request #12485: [FLINK-18130][hive][fs-connector] File name conflict for different jobs in filesystem/hive sink
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on pull request #12485:
URL: https://github.com/apache/flink/pull/12485#issuecomment-639241037
CC: @gaoyunhaii @lirui-apache
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12485: [FLINK-18130][hive][fs-connector] File name conflict for different jobs in filesystem/hive sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12485:
URL: https://github.com/apache/flink/pull/12485#issuecomment-638848123
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7fe7332d4767bbfb996e86f1b59d99c8c4713192",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2737",
"triggerID" : "7fe7332d4767bbfb996e86f1b59d99c8c4713192",
"triggerType" : "PUSH"
}, {
"hash" : "fa51d430e64af7aa9d18cc5f463218aa91bf0d96",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2775",
"triggerID" : "fa51d430e64af7aa9d18cc5f463218aa91bf0d96",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7fe7332d4767bbfb996e86f1b59d99c8c4713192 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2737)
* fa51d430e64af7aa9d18cc5f463218aa91bf0d96 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2775)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12485: [FLINK-18130][hive][fs-connector] File name conflict for different jobs in filesystem/hive sink
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12485:
URL: https://github.com/apache/flink/pull/12485#issuecomment-638835443
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 7fe7332d4767bbfb996e86f1b59d99c8c4713192 (Thu Jun 04 13:07:13 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12485: [FLINK-18130][hive][fs-connector] File name conflict for different jobs in filesystem/hive sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12485:
URL: https://github.com/apache/flink/pull/12485#issuecomment-638848123
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7fe7332d4767bbfb996e86f1b59d99c8c4713192",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2737",
"triggerID" : "7fe7332d4767bbfb996e86f1b59d99c8c4713192",
"triggerType" : "PUSH"
}, {
"hash" : "fa51d430e64af7aa9d18cc5f463218aa91bf0d96",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2775",
"triggerID" : "fa51d430e64af7aa9d18cc5f463218aa91bf0d96",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa51d430e64af7aa9d18cc5f463218aa91bf0d96 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2775)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi merged pull request #12485: [FLINK-18130][hive][fs-connector] File name conflict for different jobs in filesystem/hive sink
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #12485:
URL: https://github.com/apache/flink/pull/12485
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12485: [FLINK-18130][hive][fs-connector] File name conflict for different jobs in filesystem/hive sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12485:
URL: https://github.com/apache/flink/pull/12485#issuecomment-638848123
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7fe7332d4767bbfb996e86f1b59d99c8c4713192",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2737",
"triggerID" : "7fe7332d4767bbfb996e86f1b59d99c8c4713192",
"triggerType" : "PUSH"
}, {
"hash" : "fa51d430e64af7aa9d18cc5f463218aa91bf0d96",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa51d430e64af7aa9d18cc5f463218aa91bf0d96",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7fe7332d4767bbfb996e86f1b59d99c8c4713192 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2737)
* fa51d430e64af7aa9d18cc5f463218aa91bf0d96 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12485: [FLINK-18130][hive][fs-connector] File name conflict for different jobs in filesystem/hive sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12485:
URL: https://github.com/apache/flink/pull/12485#issuecomment-638848123
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7fe7332d4767bbfb996e86f1b59d99c8c4713192",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2737",
"triggerID" : "7fe7332d4767bbfb996e86f1b59d99c8c4713192",
"triggerType" : "PUSH"
}, {
"hash" : "fa51d430e64af7aa9d18cc5f463218aa91bf0d96",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2775",
"triggerID" : "fa51d430e64af7aa9d18cc5f463218aa91bf0d96",
"triggerType" : "PUSH"
}, {
"hash" : "765ffd5d614376c2fde93440c9c904a80e1eab94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2801",
"triggerID" : "765ffd5d614376c2fde93440c9c904a80e1eab94",
"triggerType" : "PUSH"
}, {
"hash" : "8f5f67699dfce0b311bf197f3d26df4ac16fa6a0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2892",
"triggerID" : "8f5f67699dfce0b311bf197f3d26df4ac16fa6a0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8f5f67699dfce0b311bf197f3d26df4ac16fa6a0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2892)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on a change in pull request #12485: [FLINK-18130][hive][fs-connector] File name conflict for different jobs in filesystem/hive sink
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on a change in pull request #12485:
URL: https://github.com/apache/flink/pull/12485#discussion_r436443457
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/PartitionLoader.java
##########
@@ -113,12 +113,7 @@ private void renameFiles(List<Path> srcDirs, Path destDir) throws Exception {
for (FileStatus srcFile : srcFiles) {
Path srcPath = srcFile.getPath();
Path destPath = new Path(destDir, srcPath.getName());
- int count = 1;
- while (!fs.rename(srcPath, destPath)) {
- String name = srcPath.getName() + "_copy_" + count;
- destPath = new Path(destDir, name);
- count++;
- }
+ fs.rename(srcPath, destPath);
Review comment:
Here seems inconsistent with this method's comment: rename does not delete the dest path if it exists on HDFS. Instead, it will keep the srcPath and dest Path unchanged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12485: [FLINK-18130][hive][fs-connector] File name conflict for different jobs in filesystem/hive sink
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12485:
URL: https://github.com/apache/flink/pull/12485#issuecomment-638848123
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7fe7332d4767bbfb996e86f1b59d99c8c4713192",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7fe7332d4767bbfb996e86f1b59d99c8c4713192",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7fe7332d4767bbfb996e86f1b59d99c8c4713192 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12485: [FLINK-18130][hive][fs-connector] File name conflict for different jobs in filesystem/hive sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12485:
URL: https://github.com/apache/flink/pull/12485#issuecomment-638848123
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7fe7332d4767bbfb996e86f1b59d99c8c4713192",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2737",
"triggerID" : "7fe7332d4767bbfb996e86f1b59d99c8c4713192",
"triggerType" : "PUSH"
}, {
"hash" : "fa51d430e64af7aa9d18cc5f463218aa91bf0d96",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2775",
"triggerID" : "fa51d430e64af7aa9d18cc5f463218aa91bf0d96",
"triggerType" : "PUSH"
}, {
"hash" : "765ffd5d614376c2fde93440c9c904a80e1eab94",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "765ffd5d614376c2fde93440c9c904a80e1eab94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa51d430e64af7aa9d18cc5f463218aa91bf0d96 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2775)
* 765ffd5d614376c2fde93440c9c904a80e1eab94 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org