You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/21 02:59:24 UTC

[GitHub] [beam] yifanmai opened a new pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

yifanmai opened a new pull request #12655:
URL: https://github.com/apache/beam/pull/12655


   Currently, `PTransformOverride` only supports overriding `PTransform` s that have a single input. This change adds support for multiple main inputs and side inputs.
   
   The change introduces a new method `PTransformOverride.get_replacement_inputs(self, applied_ptransform)` that can be overridden by end users. This method will be called to get the inputs for the replacement `PTransform.` The default implementation will return a tuple of all the main inputs in order, concatenated with the all the side inputs `PValue` s in order.
   
   Post-Commit Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   
   Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
   --- | --- | --- | --- | --- | --- | ---
   Go | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
   Java | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/badge/i
 con)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[![Build Status](htt
 ps://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
   Python | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_
 Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_P
 ostCommit_Python_VR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
   XLang | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
   
   Pre-Commit Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   
   --- |Java | Python | Go | Website
   --- | --- | --- | --- | ---
   Non-portable | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/be
 am_PreCommit_Go_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
   Portable | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
   
   See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
   
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   ![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg)
   ![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/aa345dbeb9f6bdb36f5acf0fb8958777253acd51?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `12.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   40.22%   40.22%   -0.01%     
   ==========================================
     Files         454      454              
     Lines       53669    53672       +3     
   ==========================================
   + Hits        21587    21588       +1     
   - Misses      32082    32084       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `24.27% <12.50%> (+0.04%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [aa345db...b998e25](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] chamikaramj commented on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-688929571


   Run Python 3.5 PostCommit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] chamikaramj commented on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-686667049


   Run PythonDocker PreCommit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/aa345dbeb9f6bdb36f5acf0fb8958777253acd51?el=desc) will **decrease** coverage by `0.14%`.
   > The diff coverage is `12.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   40.22%   40.07%   -0.15%     
   ==========================================
     Files         454      454              
     Lines       53669    53980     +311     
   ==========================================
   + Hits        21587    21634      +47     
   - Misses      32082    32346     +264     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `24.27% <12.50%> (+0.04%)` | :arrow_up: |
   | [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `14.00% <0.00%> (+0.22%)` | :arrow_up: |
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.92% <0.00%> (+0.68%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [aa345db...b998e25](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/2f8ea18341ba602b6c0c776bf253f605acfdd4dd?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `12.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   40.23%   40.23%   -0.01%     
   ==========================================
     Files         455      455              
     Lines       53726    53729       +3     
   ==========================================
   + Hits        21619    21620       +1     
   - Misses      32107    32109       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `24.27% <12.50%> (+0.04%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [2f8ea18...f923da1](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/2f8ea18341ba602b6c0c776bf253f605acfdd4dd?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `12.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   40.23%   40.23%   -0.01%     
   ==========================================
     Files         455      455              
     Lines       53726    53729       +3     
   ==========================================
   + Hits        21619    21620       +1     
   - Misses      32107    32109       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `24.27% <12.50%> (+0.04%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [2f8ea18...f923da1](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/cfa448d121297398312d09c531258a72b413488b?el=desc) will **increase** coverage by `2.27%`.
   > The diff coverage is `22.22%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   + Coverage   34.47%   36.74%   +2.27%     
   ==========================================
     Files         684     1138     +454     
     Lines       81483   135219   +53736     
     Branches     9180     9182       +2     
   ==========================================
   + Hits        28090    49692   +21602     
   - Misses      52965    85106   +32141     
   + Partials      428      421       -7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `24.27% <22.22%> (ø)` | |
   | [pipeline\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cGlwZWxpbmVfdGVzdC5weQ==) | `24.44% <0.00%> (-0.35%)` | :arrow_down: |
   | [io/mongodbio\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-aW8vbW9uZ29kYmlvX3Rlc3QucHk=) | `34.95% <0.00%> (ø)` | |
   | [runners/direct/direct\_runner.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy9kaXJlY3QvZGlyZWN0X3J1bm5lci5weQ==) | `32.88% <0.00%> (ø)` | |
   | [io/gcp/experimental/spannerio.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-aW8vZ2NwL2V4cGVyaW1lbnRhbC9zcGFubmVyaW8ucHk=) | `34.49% <0.00%> (ø)` | |
   | [typehints/typed\_pipeline\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL3R5cGVkX3BpcGVsaW5lX3Rlc3QucHk=) | `21.98% <0.00%> (ø)` | |
   | [runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `28.45% <0.00%> (ø)` | |
   | [runners/dataflow/dataflow\_runner\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19ydW5uZXJfdGVzdC5weQ==) | `25.49% <0.00%> (ø)` | |
   | [runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==) | `18.11% <0.00%> (ø)` | |
   | [sdks/python/apache\_beam/dataframe/expressions.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2V4cHJlc3Npb25zLnB5) | `49.54% <0.00%> (ø)` | |
   | ... and [454 more](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [cfa448d...34348a0](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] commented on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/cfa448d121297398312d09c531258a72b413488b?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   34.47%   34.46%   -0.01%     
   ==========================================
     Files         684      684              
     Lines       81483    81547      +64     
     Branches     9180     9182       +2     
   ==========================================
   + Hits        28090    28104      +14     
   - Misses      52965    53022      +57     
   + Partials      428      421       -7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pipeline\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cGlwZWxpbmVfdGVzdC5weQ==) | `24.44% <0.00%> (-0.35%)` | :arrow_down: |
   | [io/mongodbio\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-aW8vbW9uZ29kYmlvX3Rlc3QucHk=) | `34.95% <0.00%> (ø)` | |
   | [runners/direct/direct\_runner.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy9kaXJlY3QvZGlyZWN0X3J1bm5lci5weQ==) | `32.88% <0.00%> (ø)` | |
   | [io/gcp/experimental/spannerio.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-aW8vZ2NwL2V4cGVyaW1lbnRhbC9zcGFubmVyaW8ucHk=) | `34.49% <0.00%> (ø)` | |
   | [typehints/typed\_pipeline\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL3R5cGVkX3BpcGVsaW5lX3Rlc3QucHk=) | `21.98% <0.00%> (ø)` | |
   | [runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `28.45% <0.00%> (ø)` | |
   | [runners/dataflow/dataflow\_runner\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19ydW5uZXJfdGVzdC5weQ==) | `25.49% <0.00%> (ø)` | |
   | [runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==) | `18.11% <0.00%> (ø)` | |
   | [pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cGlwZWxpbmUucHk=) | `22.33% <0.00%> (+0.01%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [cfa448d...34348a0](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/2f8ea18341ba602b6c0c776bf253f605acfdd4dd?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `12.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   40.23%   40.23%   -0.01%     
   ==========================================
     Files         455      455              
     Lines       53726    53729       +3     
   ==========================================
   + Hits        21619    21620       +1     
   - Misses      32107    32109       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `24.27% <12.50%> (+0.04%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [2f8ea18...f923da1](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/aa345dbeb9f6bdb36f5acf0fb8958777253acd51?el=desc) will **decrease** coverage by `0.14%`.
   > The diff coverage is `12.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   40.22%   40.07%   -0.15%     
   ==========================================
     Files         454      454              
     Lines       53669    53980     +311     
   ==========================================
   + Hits        21587    21634      +47     
   - Misses      32082    32346     +264     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `24.27% <12.50%> (+0.04%)` | :arrow_up: |
   | [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `14.00% <0.00%> (+0.22%)` | :arrow_up: |
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.92% <0.00%> (+0.68%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [aa345db...b998e25](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/12711bbdaadb41b37b9c16f59f63adc8f2d59ae6?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `12.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   40.22%   40.22%   -0.01%     
   ==========================================
     Files         454      454              
     Lines       53669    53672       +3     
   ==========================================
   + Hits        21587    21588       +1     
   - Misses      32082    32084       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `24.27% <12.50%> (+0.04%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [aa345db...b998e25](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] yifanmai commented on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
yifanmai commented on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-685956078


   Run PythonDocker PreCommit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/2f8ea18341ba602b6c0c776bf253f605acfdd4dd?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `12.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   40.23%   40.23%   -0.01%     
   ==========================================
     Files         455      455              
     Lines       53726    53729       +3     
   ==========================================
   + Hits        21619    21620       +1     
   - Misses      32107    32109       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `24.27% <12.50%> (+0.04%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [2f8ea18...f923da1](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] chamikaramj commented on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683894280


   Please address test failures. You should be able to rerun test suites by adding the trigger (mention in quotes) as a comment.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] yifanmai commented on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
yifanmai commented on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-678010764


   R: @chamikaramj


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] yifanmai commented on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
yifanmai commented on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-685964258


   Now I'm running into:
   
   > Traceback (most recent call last):
   >  File "/tmp/license_scripts/pull_licenses_py.py", line 146, in <module>
       raise RuntimeError(
   >RuntimeError: Could not retrieve licences for packages ['pbr'] in Python3.8 environment. 
   > These licenses were not able to be pulled automatically. Please search code source of the dependencies on the internet and add urls to RAW license file at sdks/python/container/license_scripts/dep_urls_py.yaml for each missing license and rerun the test. If no such urls can be found, you need to manually add LICENSE and NOTICE (if available) files at sdks/python/container/license_scripts/manual_licenses/{dep}/ and add entries to sdks/python/container/license_scripts/dep_urls_py.yaml.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/aa345dbeb9f6bdb36f5acf0fb8958777253acd51?el=desc) will **decrease** coverage by `0.14%`.
   > The diff coverage is `12.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   40.22%   40.07%   -0.15%     
   ==========================================
     Files         454      454              
     Lines       53669    53980     +311     
   ==========================================
   + Hits        21587    21634      +47     
   - Misses      32082    32346     +264     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `24.27% <12.50%> (+0.04%)` | :arrow_up: |
   | [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `14.00% <0.00%> (+0.22%)` | :arrow_up: |
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.92% <0.00%> (+0.68%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [aa345db...b998e25](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] chamikaramj commented on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-684008972


   Thanks Kyle.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/aa345dbeb9f6bdb36f5acf0fb8958777253acd51?el=desc) will **decrease** coverage by `0.12%`.
   > The diff coverage is `12.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   40.22%   40.10%   -0.13%     
   ==========================================
     Files         454      455       +1     
     Lines       53669    54028     +359     
   ==========================================
   + Hits        21587    21666      +79     
   - Misses      32082    32362     +280     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `24.27% <12.50%> (+0.04%)` | :arrow_up: |
   | [sdks/python/apache\_beam/io/kinesis.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8va2luZXNpcy5weQ==) | `66.66% <0.00%> (ø)` | |
   | [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `14.00% <0.00%> (+0.22%)` | :arrow_up: |
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.92% <0.00%> (+0.68%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [aa345db...b998e25](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] chamikaramj commented on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-688928947


   Run Python 3.8 PostCommit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] yifanmai commented on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
yifanmai commented on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683999886


   The remaining failing tests seem unrelated and non-spurious. How should I resolve this?
   
   **Portable_Python**
   > docker: Error response from daemon: Conflict. The container name "/license-container-python" is already in use by container "a52b4fd35d9c5c813b2318e1ca5d4da3c8649f2756a78890f61648f1f450c6c0". You have to remove (or rename) that container to be able to reuse that name.
   
   **Python**
   
   Tasks :sdks:python:test-suites:tox:py35:testPy35Cloud and :sdks:python:test-suites:tox:py35:testPy35Cython both fail with:
   
   > SystemError: Parent module 'setuptools' not loaded, cannot perform relative import


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/2f8ea18341ba602b6c0c776bf253f605acfdd4dd?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `12.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   40.23%   40.23%   -0.01%     
   ==========================================
     Files         455      455              
     Lines       53726    53729       +3     
   ==========================================
   + Hits        21619    21620       +1     
   - Misses      32107    32109       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `24.27% <12.50%> (+0.04%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [2f8ea18...f923da1](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/2f8ea18341ba602b6c0c776bf253f605acfdd4dd?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `12.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   40.23%   40.23%   -0.01%     
   ==========================================
     Files         455      455              
     Lines       53726    53729       +3     
   ==========================================
   + Hits        21619    21620       +1     
   - Misses      32107    32109       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `24.27% <12.50%> (+0.04%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [2f8ea18...f923da1](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/cfa448d121297398312d09c531258a72b413488b?el=desc) will **increase** coverage by `2.27%`.
   > The diff coverage is `22.22%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   + Coverage   34.47%   36.74%   +2.27%     
   ==========================================
     Files         684     1138     +454     
     Lines       81483   135219   +53736     
     Branches     9180     9182       +2     
   ==========================================
   + Hits        28090    49692   +21602     
   - Misses      52965    85106   +32141     
   + Partials      428      421       -7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `24.27% <22.22%> (ø)` | |
   | [pipeline\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cGlwZWxpbmVfdGVzdC5weQ==) | `24.44% <0.00%> (-0.35%)` | :arrow_down: |
   | [io/mongodbio\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-aW8vbW9uZ29kYmlvX3Rlc3QucHk=) | `34.95% <0.00%> (ø)` | |
   | [runners/direct/direct\_runner.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy9kaXJlY3QvZGlyZWN0X3J1bm5lci5weQ==) | `32.88% <0.00%> (ø)` | |
   | [io/gcp/experimental/spannerio.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-aW8vZ2NwL2V4cGVyaW1lbnRhbC9zcGFubmVyaW8ucHk=) | `34.49% <0.00%> (ø)` | |
   | [typehints/typed\_pipeline\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL3R5cGVkX3BpcGVsaW5lX3Rlc3QucHk=) | `21.98% <0.00%> (ø)` | |
   | [runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `28.45% <0.00%> (ø)` | |
   | [runners/dataflow/dataflow\_runner\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19ydW5uZXJfdGVzdC5weQ==) | `25.49% <0.00%> (ø)` | |
   | [runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==) | `18.11% <0.00%> (ø)` | |
   | [sdks/python/apache\_beam/dataframe/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL19faW5pdF9fLnB5) | `100.00% <0.00%> (ø)` | |
   | ... and [454 more](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [cfa448d...34348a0](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/cfa448d121297398312d09c531258a72b413488b?el=desc) will **increase** coverage by `2.27%`.
   > The diff coverage is `22.22%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   + Coverage   34.47%   36.74%   +2.27%     
   ==========================================
     Files         684     1138     +454     
     Lines       81483   135219   +53736     
     Branches     9180     9182       +2     
   ==========================================
   + Hits        28090    49692   +21602     
   - Misses      52965    85106   +32141     
   + Partials      428      421       -7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `24.27% <22.22%> (ø)` | |
   | [pipeline\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cGlwZWxpbmVfdGVzdC5weQ==) | `24.44% <0.00%> (-0.35%)` | :arrow_down: |
   | [io/mongodbio\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-aW8vbW9uZ29kYmlvX3Rlc3QucHk=) | `34.95% <0.00%> (ø)` | |
   | [runners/direct/direct\_runner.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy9kaXJlY3QvZGlyZWN0X3J1bm5lci5weQ==) | `32.88% <0.00%> (ø)` | |
   | [io/gcp/experimental/spannerio.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-aW8vZ2NwL2V4cGVyaW1lbnRhbC9zcGFubmVyaW8ucHk=) | `34.49% <0.00%> (ø)` | |
   | [typehints/typed\_pipeline\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL3R5cGVkX3BpcGVsaW5lX3Rlc3QucHk=) | `21.98% <0.00%> (ø)` | |
   | [runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `28.45% <0.00%> (ø)` | |
   | [runners/dataflow/dataflow\_runner\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19ydW5uZXJfdGVzdC5weQ==) | `25.49% <0.00%> (ø)` | |
   | [runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==) | `18.11% <0.00%> (ø)` | |
   | [...amples/snippets/transforms/elementwise/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9lbGVtZW50d2lzZS9fX2luaXRfXy5weQ==) | `100.00% <0.00%> (ø)` | |
   | ... and [454 more](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [cfa448d...34348a0](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] ibzib commented on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
ibzib commented on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-685120733


   Run Python PreCommit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/12711bbdaadb41b37b9c16f59f63adc8f2d59ae6?el=desc) will **decrease** coverage by `3.47%`.
   > The diff coverage is `22.22%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   40.22%   36.74%   -3.48%     
   ==========================================
     Files         454     1138     +684     
     Lines       53669   135219   +81550     
     Branches        0     9182    +9182     
   ==========================================
   + Hits        21587    49692   +28105     
   - Misses      32082    85106   +53024     
   - Partials        0      421     +421     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `24.27% <22.22%> (+0.04%)` | :arrow_up: |
   | [examples/complete/distribopt\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvY29tcGxldGUvZGlzdHJpYm9wdF90ZXN0LnB5) | `43.24% <0.00%> (ø)` | |
   | [utils/windowed\_value.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-dXRpbHMvd2luZG93ZWRfdmFsdWUucHk=) | `81.29% <0.00%> (ø)` | |
   | [examples/streaming\_wordcount\_debugging.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvc3RyZWFtaW5nX3dvcmRjb3VudF9kZWJ1Z2dpbmcucHk=) | `33.84% <0.00%> (ø)` | |
   | [coders/typecoders\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-Y29kZXJzL3R5cGVjb2RlcnNfdGVzdC5weQ==) | `36.47% <0.00%> (ø)` | |
   | [runners/direct/bundle\_factory.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy9kaXJlY3QvYnVuZGxlX2ZhY3RvcnkucHk=) | `41.93% <0.00%> (ø)` | |
   | [testing/benchmarks/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-dGVzdGluZy9iZW5jaG1hcmtzL19faW5pdF9fLnB5) | `0.00% <0.00%> (ø)` | |
   | [testing/extra\_assertions.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-dGVzdGluZy9leHRyYV9hc3NlcnRpb25zLnB5) | `20.00% <0.00%> (ø)` | |
   | [runners/dataflow/dataflow\_runner.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19ydW5uZXIucHk=) | `18.73% <0.00%> (ø)` | |
   | ... and [676 more](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [aa345db...b998e25](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/aa345dbeb9f6bdb36f5acf0fb8958777253acd51?el=desc) will **decrease** coverage by `0.12%`.
   > The diff coverage is `12.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   40.22%   40.10%   -0.13%     
   ==========================================
     Files         454      455       +1     
     Lines       53669    54028     +359     
   ==========================================
   + Hits        21587    21666      +79     
   - Misses      32082    32362     +280     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `24.27% <12.50%> (+0.04%)` | :arrow_up: |
   | [sdks/python/apache\_beam/io/kinesis.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8va2luZXNpcy5weQ==) | `66.66% <0.00%> (ø)` | |
   | [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `14.00% <0.00%> (+0.22%)` | :arrow_up: |
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.92% <0.00%> (+0.68%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [aa345db...b998e25](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/2f8ea18341ba602b6c0c776bf253f605acfdd4dd?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `12.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   40.23%   40.23%   -0.01%     
   ==========================================
     Files         455      455              
     Lines       53726    53729       +3     
   ==========================================
   + Hits        21619    21620       +1     
   - Misses      32107    32109       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `24.27% <12.50%> (+0.04%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [2f8ea18...f923da1](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/cfa448d121297398312d09c531258a72b413488b?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   34.47%   34.46%   -0.01%     
   ==========================================
     Files         684      684              
     Lines       81483    81547      +64     
     Branches     9180     9182       +2     
   ==========================================
   + Hits        28090    28104      +14     
   - Misses      52965    53022      +57     
   + Partials      428      421       -7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pipeline\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cGlwZWxpbmVfdGVzdC5weQ==) | `24.44% <0.00%> (-0.35%)` | :arrow_down: |
   | [io/mongodbio\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-aW8vbW9uZ29kYmlvX3Rlc3QucHk=) | `34.95% <0.00%> (ø)` | |
   | [runners/direct/direct\_runner.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy9kaXJlY3QvZGlyZWN0X3J1bm5lci5weQ==) | `32.88% <0.00%> (ø)` | |
   | [io/gcp/experimental/spannerio.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-aW8vZ2NwL2V4cGVyaW1lbnRhbC9zcGFubmVyaW8ucHk=) | `34.49% <0.00%> (ø)` | |
   | [typehints/typed\_pipeline\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL3R5cGVkX3BpcGVsaW5lX3Rlc3QucHk=) | `21.98% <0.00%> (ø)` | |
   | [runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `28.45% <0.00%> (ø)` | |
   | [runners/dataflow/dataflow\_runner\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19ydW5uZXJfdGVzdC5weQ==) | `25.49% <0.00%> (ø)` | |
   | [runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==) | `18.11% <0.00%> (ø)` | |
   | [pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cGlwZWxpbmUucHk=) | `22.33% <0.00%> (+0.01%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [cfa448d...34348a0](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] chamikaramj commented on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-685844986


   Retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/472faa197ba9fc46c7c437d4064a2021221fcb60?el=desc) will **decrease** coverage by `0.13%`.
   > The diff coverage is `12.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   40.23%   40.10%   -0.14%     
   ==========================================
     Files         455      455              
     Lines       53726    54028     +302     
   ==========================================
   + Hits        21619    21666      +47     
   - Misses      32107    32362     +255     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `24.27% <12.50%> (+0.04%)` | :arrow_up: |
   | [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `14.00% <0.00%> (+0.37%)` | :arrow_up: |
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.92% <0.00%> (+0.92%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [2f8ea18...f923da1](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] yifanmai commented on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
yifanmai commented on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-686006013


   Run Portable_Python PreCommit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/aa345dbeb9f6bdb36f5acf0fb8958777253acd51?el=desc) will **decrease** coverage by `0.12%`.
   > The diff coverage is `12.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   40.22%   40.10%   -0.13%     
   ==========================================
     Files         454      455       +1     
     Lines       53669    54028     +359     
   ==========================================
   + Hits        21587    21666      +79     
   - Misses      32082    32362     +280     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `24.27% <12.50%> (+0.04%)` | :arrow_up: |
   | [sdks/python/apache\_beam/io/kinesis.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8va2luZXNpcy5weQ==) | `66.66% <0.00%> (ø)` | |
   | [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `14.00% <0.00%> (+0.22%)` | :arrow_up: |
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.92% <0.00%> (+0.68%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [aa345db...b998e25](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/12711bbdaadb41b37b9c16f59f63adc8f2d59ae6?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `12.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   40.22%   40.22%   -0.01%     
   ==========================================
     Files         454      454              
     Lines       53669    53672       +3     
   ==========================================
   + Hits        21587    21588       +1     
   - Misses      32082    32084       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `24.27% <12.50%> (+0.04%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [aa345db...b998e25](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/aa345dbeb9f6bdb36f5acf0fb8958777253acd51?el=desc) will **decrease** coverage by `0.14%`.
   > The diff coverage is `12.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   40.22%   40.07%   -0.15%     
   ==========================================
     Files         454      454              
     Lines       53669    53980     +311     
   ==========================================
   + Hits        21587    21634      +47     
   - Misses      32082    32346     +264     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `24.27% <12.50%> (+0.04%)` | :arrow_up: |
   | [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `14.00% <0.00%> (+0.22%)` | :arrow_up: |
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.92% <0.00%> (+0.68%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [aa345db...b998e25](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/aa345dbeb9f6bdb36f5acf0fb8958777253acd51?el=desc) will **decrease** coverage by `0.14%`.
   > The diff coverage is `12.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   40.22%   40.07%   -0.15%     
   ==========================================
     Files         454      454              
     Lines       53669    53980     +311     
   ==========================================
   + Hits        21587    21634      +47     
   - Misses      32082    32346     +264     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `24.27% <12.50%> (+0.04%)` | :arrow_up: |
   | [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `14.00% <0.00%> (+0.22%)` | :arrow_up: |
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.92% <0.00%> (+0.68%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [aa345db...b998e25](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] yifanmai commented on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
yifanmai commented on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-689157858


   Precommits (besides codecov) look good.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/12711bbdaadb41b37b9c16f59f63adc8f2d59ae6?el=desc) will **decrease** coverage by `3.47%`.
   > The diff coverage is `22.22%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   40.22%   36.74%   -3.48%     
   ==========================================
     Files         454     1138     +684     
     Lines       53669   135219   +81550     
     Branches        0     9182    +9182     
   ==========================================
   + Hits        21587    49692   +28105     
   - Misses      32082    85106   +53024     
   - Partials        0      421     +421     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `24.27% <22.22%> (+0.04%)` | :arrow_up: |
   | [io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-aW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `16.21% <0.00%> (ø)` | |
   | [examples/complete/game/leader\_board.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvY29tcGxldGUvZ2FtZS9sZWFkZXJfYm9hcmQucHk=) | `38.94% <0.00%> (ø)` | |
   | [testing/load\_tests/combine\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-dGVzdGluZy9sb2FkX3Rlc3RzL2NvbWJpbmVfdGVzdC5weQ==) | `54.16% <0.00%> (ø)` | |
   | [io/kafka.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-aW8va2Fma2EucHk=) | `85.71% <0.00%> (ø)` | |
   | [internal/gcp/json\_value.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-aW50ZXJuYWwvZ2NwL2pzb25fdmFsdWUucHk=) | `16.66% <0.00%> (ø)` | |
   | [...mples/snippets/transforms/aggregation/mean\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9tZWFuX3Rlc3QucHk=) | `70.00% <0.00%> (ø)` | |
   | [runners/portability/local\_job\_service\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy9wb3J0YWJpbGl0eS9sb2NhbF9qb2Jfc2VydmljZV90ZXN0LnB5) | `36.84% <0.00%> (ø)` | |
   | [runners/interactive/testing/pipeline\_assertion.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS90ZXN0aW5nL3BpcGVsaW5lX2Fzc2VydGlvbi5weQ==) | `25.92% <0.00%> (ø)` | |
   | ... and [676 more](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [aa345db...2b951cb](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/cfa448d121297398312d09c531258a72b413488b?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   34.47%   34.46%   -0.01%     
   ==========================================
     Files         684      684              
     Lines       81483    81547      +64     
     Branches     9180     9182       +2     
   ==========================================
   + Hits        28090    28104      +14     
   - Misses      52965    53022      +57     
   + Partials      428      421       -7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pipeline\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cGlwZWxpbmVfdGVzdC5weQ==) | `24.44% <0.00%> (-0.35%)` | :arrow_down: |
   | [io/mongodbio\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-aW8vbW9uZ29kYmlvX3Rlc3QucHk=) | `34.95% <0.00%> (ø)` | |
   | [runners/direct/direct\_runner.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy9kaXJlY3QvZGlyZWN0X3J1bm5lci5weQ==) | `32.88% <0.00%> (ø)` | |
   | [io/gcp/experimental/spannerio.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-aW8vZ2NwL2V4cGVyaW1lbnRhbC9zcGFubmVyaW8ucHk=) | `34.49% <0.00%> (ø)` | |
   | [typehints/typed\_pipeline\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL3R5cGVkX3BpcGVsaW5lX3Rlc3QucHk=) | `21.98% <0.00%> (ø)` | |
   | [runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `28.45% <0.00%> (ø)` | |
   | [runners/dataflow/dataflow\_runner\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19ydW5uZXJfdGVzdC5weQ==) | `25.49% <0.00%> (ø)` | |
   | [runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==) | `18.11% <0.00%> (ø)` | |
   | [pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cGlwZWxpbmUucHk=) | `22.33% <0.00%> (+0.01%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [cfa448d...34348a0](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] chamikaramj commented on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610025


   Retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] chamikaramj commented on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-686666971


   Run Portable_Python PreCommit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] yifanmai commented on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
yifanmai commented on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-684000921


   Run Portable_Python PreCommit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/cfa448d121297398312d09c531258a72b413488b?el=desc) will **increase** coverage by `2.27%`.
   > The diff coverage is `22.22%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   + Coverage   34.47%   36.74%   +2.27%     
   ==========================================
     Files         684     1138     +454     
     Lines       81483   135219   +53736     
     Branches     9180     9182       +2     
   ==========================================
   + Hits        28090    49692   +21602     
   - Misses      52965    85106   +32141     
   + Partials      428      421       -7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `24.27% <22.22%> (ø)` | |
   | [pipeline\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cGlwZWxpbmVfdGVzdC5weQ==) | `24.44% <0.00%> (-0.35%)` | :arrow_down: |
   | [io/mongodbio\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-aW8vbW9uZ29kYmlvX3Rlc3QucHk=) | `34.95% <0.00%> (ø)` | |
   | [runners/direct/direct\_runner.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy9kaXJlY3QvZGlyZWN0X3J1bm5lci5weQ==) | `32.88% <0.00%> (ø)` | |
   | [io/gcp/experimental/spannerio.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-aW8vZ2NwL2V4cGVyaW1lbnRhbC9zcGFubmVyaW8ucHk=) | `34.49% <0.00%> (ø)` | |
   | [typehints/typed\_pipeline\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL3R5cGVkX3BpcGVsaW5lX3Rlc3QucHk=) | `21.98% <0.00%> (ø)` | |
   | [runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `28.45% <0.00%> (ø)` | |
   | [runners/dataflow/dataflow\_runner\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19ydW5uZXJfdGVzdC5weQ==) | `25.49% <0.00%> (ø)` | |
   | [runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==) | `18.11% <0.00%> (ø)` | |
   | [sdks/python/apache\_beam/dataframe/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL19faW5pdF9fLnB5) | `100.00% <0.00%> (ø)` | |
   | ... and [454 more](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [cfa448d...34348a0](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] ibzib commented on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
ibzib commented on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-684008360


   > Yeah, seems like Python PreCommit is broken currently. We'll have to wait till HEAD is fixed to retry tests.
   
   Thanks for the notification, I filed and am triaging BEAM-10841


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] yifanmai commented on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
yifanmai commented on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-689120923


   Run Python 3.8 PostCommit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] chamikaramj merged pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
chamikaramj merged pull request #12655:
URL: https://github.com/apache/beam/pull/12655


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] chamikaramj commented on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-684003860


   Yeah, seems like Python PreCommit is broken currently. We'll have to wait till HEAD is fixed to retry tests.
   
   cc: @ibzib 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/2f8ea18341ba602b6c0c776bf253f605acfdd4dd?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `12.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   40.23%   40.23%   -0.01%     
   ==========================================
     Files         455      455              
     Lines       53726    53729       +3     
   ==========================================
   + Hits        21619    21620       +1     
   - Misses      32107    32109       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `24.27% <12.50%> (+0.04%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [2f8ea18...f923da1](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/2f8ea18341ba602b6c0c776bf253f605acfdd4dd?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `12.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   40.23%   40.23%   -0.01%     
   ==========================================
     Files         455      455              
     Lines       53726    53729       +3     
   ==========================================
   + Hits        21619    21620       +1     
   - Misses      32107    32109       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `24.27% <12.50%> (+0.04%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last update [2f8ea18...f923da1](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org