You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/07 08:23:25 UTC
[GitHub] [incubator-mxnet] samskalicky opened a new issue #17236: [RFC]
Custom subgraph property part2
samskalicky opened a new issue #17236: [RFC] Custom subgraph property part2
URL: https://github.com/apache/incubator-mxnet/issues/17236
## Description
Request for comments on the next PR for enhancing custom subgraph property support
Heres some suggestions from the initial PR (Part 1):
Heres some suggestions from the initial PR (Part 1):
- docs, readme, tutorial
- dynamic graph passes
## References
- initial PR (Part 1): #17034
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] samskalicky commented on issue #17236: [RFC]
Custom subgraph property enhancements
Posted by GitBox <gi...@apache.org>.
samskalicky commented on issue #17236: [RFC] Custom subgraph property enhancements
URL: https://github.com/apache/incubator-mxnet/issues/17236#issuecomment-600786482
Current implementation (as of 3/18/2020) only supports combining ops into subgraphs generically. does not allow for fine grained control to say which ops should go into which subgraphs. Need to modify `supportedOps` API to change the `ids` vector from bool (supported or not) to integer (to say which subgraph this node should go in to). This will allow for coloring and fine grained control of ops in a subgraph.
https://github.com/apache/incubator-mxnet/blob/07d0b738384cba011ce519bcc41aeeaaafcd22c1/example/extensions/lib_subgraph/subgraph_lib.cc#L179-L181
Will also need to modify custom_subgraph_property.h selector to use these int values to define the subgraph instead of just looking for existence of the operator name.
https://github.com/apache/incubator-mxnet/blob/41d534be3ffd7b45846f555366230f4e811d8751/src/operator/subgraph/partitioner/custom_subgraph_property.h#L47-L54
Open question:
How do we handle the cases where we want to remove args/aux from the top level of the model, migrating those into the subgraph? If we compile a subgraph with Args/Aux then those tensor values are effectively frozen in the compiled binary so we need to be clear with users that they can no longer be changed in the top level model
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] samskalicky edited a comment on issue #17236:
[RFC] Custom subgraph property part2
Posted by GitBox <gi...@apache.org>.
samskalicky edited a comment on issue #17236: [RFC] Custom subgraph property part2
URL: https://github.com/apache/incubator-mxnet/issues/17236#issuecomment-571485061
@mxnet-label-bot add [RFC]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] samskalicky commented on issue #17236: [RFC]
Custom subgraph property part2
Posted by GitBox <gi...@apache.org>.
samskalicky commented on issue #17236: [RFC] Custom subgraph property part2
URL: https://github.com/apache/incubator-mxnet/issues/17236#issuecomment-571485061
@mxnet-label-bot add RFC
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] samskalicky commented on issue #17236: [RFC] Custom subgraph property enhancements
Posted by GitBox <gi...@apache.org>.
samskalicky commented on issue #17236:
URL: https://github.com/apache/incubator-mxnet/issues/17236#issuecomment-618531217
Need to support removing args/aux from custom graph pass, re-using the optimized symbol when calling optimize_for in Gluon repeatedly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org