You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uima.apache.org by sc...@apache.org on 2006/12/22 20:18:39 UTC

svn commit: r489731 - in /incubator/uima/uimaj/trunk/uimaj-ep-configurator/src/main/java/org/apache/uima/taeconfigurator: editors/MultiPageEditor.java editors/ui/dialogs/AbstractDialog.java model/FlowNodes.java

Author: schor
Date: Fri Dec 22 11:18:38 2006
New Revision: 489731

URL: http://svn.apache.org/viewvc?view=rev&rev=489731
Log:
UIMA-2 findbugs cleanup (minor)

Modified:
    incubator/uima/uimaj/trunk/uimaj-ep-configurator/src/main/java/org/apache/uima/taeconfigurator/editors/MultiPageEditor.java
    incubator/uima/uimaj/trunk/uimaj-ep-configurator/src/main/java/org/apache/uima/taeconfigurator/editors/ui/dialogs/AbstractDialog.java
    incubator/uima/uimaj/trunk/uimaj-ep-configurator/src/main/java/org/apache/uima/taeconfigurator/model/FlowNodes.java

Modified: incubator/uima/uimaj/trunk/uimaj-ep-configurator/src/main/java/org/apache/uima/taeconfigurator/editors/MultiPageEditor.java
URL: http://svn.apache.org/viewvc/incubator/uima/uimaj/trunk/uimaj-ep-configurator/src/main/java/org/apache/uima/taeconfigurator/editors/MultiPageEditor.java?view=diff&rev=489731&r1=489730&r2=489731
==============================================================================
--- incubator/uima/uimaj/trunk/uimaj-ep-configurator/src/main/java/org/apache/uima/taeconfigurator/editors/MultiPageEditor.java (original)
+++ incubator/uima/uimaj/trunk/uimaj-ep-configurator/src/main/java/org/apache/uima/taeconfigurator/editors/MultiPageEditor.java Fri Dec 22 11:18:38 2006
@@ -1877,8 +1877,8 @@
     if (null == project || !project.isNatureEnabled("org.eclipse.jdt.core.javanature")) { //$NON-NLS-1$
       return ""; //$NON-NLS-1$
     }
-    IJavaProject javaProject = JavaCore.create(project);
-    IProject projectRoot = javaProject.getProject();
+    IJavaProject javaProj = JavaCore.create(project);
+    IProject projectRoot = javaProj.getProject();
 
     IResource classFileResource = projectRoot.findMember(".classpath"); //$NON-NLS-1$
     long stamp = classFileResource.getModificationStamp();
@@ -1888,7 +1888,7 @@
 
     StringBuffer result = new StringBuffer(1000);
 
-    String[] classPaths = JavaRuntime.computeDefaultRuntimeClassPath(javaProject);
+    String[] classPaths = JavaRuntime.computeDefaultRuntimeClassPath(javaProj);
 
     for (int i = 0; i < classPaths.length; i++) {
       String classPath = classPaths[i];
@@ -1921,8 +1921,8 @@
       if (!project.isNatureEnabled("org.eclipse.jdt.core.javanature")) { //$NON-NLS-1$
         return null;
       }
-      IJavaProject javaProject = JavaCore.create(project);
-      IPackageFragmentRoot[] frs = javaProject.getPackageFragmentRoots();
+      IJavaProject javaProj = JavaCore.create(project);
+      IPackageFragmentRoot[] frs = javaProj.getPackageFragmentRoots();
       for (int i = 0; i < frs.length; i++) {
         frs[i].open(null);
         IResource resource = frs[i].getResource(); // first folder resource will always be first

Modified: incubator/uima/uimaj/trunk/uimaj-ep-configurator/src/main/java/org/apache/uima/taeconfigurator/editors/ui/dialogs/AbstractDialog.java
URL: http://svn.apache.org/viewvc/incubator/uima/uimaj/trunk/uimaj-ep-configurator/src/main/java/org/apache/uima/taeconfigurator/editors/ui/dialogs/AbstractDialog.java?view=diff&rev=489731&r1=489730&r2=489731
==============================================================================
--- incubator/uima/uimaj/trunk/uimaj-ep-configurator/src/main/java/org/apache/uima/taeconfigurator/editors/ui/dialogs/AbstractDialog.java (original)
+++ incubator/uima/uimaj/trunk/uimaj-ep-configurator/src/main/java/org/apache/uima/taeconfigurator/editors/ui/dialogs/AbstractDialog.java Fri Dec 22 11:18:38 2006
@@ -27,8 +27,6 @@
 import org.apache.uima.taeconfigurator.editors.MultiPageEditor;
 import org.apache.uima.taeconfigurator.editors.MultiPageEditorContributor;
 import org.apache.uima.taeconfigurator.editors.ui.AbstractSection;
-import org.eclipse.jface.bindings.keys.KeyStroke;
-import org.eclipse.jface.bindings.keys.ParseException;
 import org.eclipse.jface.dialogs.Dialog;
 import org.eclipse.jface.dialogs.IDialogConstants;
 import org.eclipse.swt.SWT;

Modified: incubator/uima/uimaj/trunk/uimaj-ep-configurator/src/main/java/org/apache/uima/taeconfigurator/model/FlowNodes.java
URL: http://svn.apache.org/viewvc/incubator/uima/uimaj/trunk/uimaj-ep-configurator/src/main/java/org/apache/uima/taeconfigurator/model/FlowNodes.java?view=diff&rev=489731&r1=489730&r2=489731
==============================================================================
--- incubator/uima/uimaj/trunk/uimaj-ep-configurator/src/main/java/org/apache/uima/taeconfigurator/model/FlowNodes.java (original)
+++ incubator/uima/uimaj/trunk/uimaj-ep-configurator/src/main/java/org/apache/uima/taeconfigurator/model/FlowNodes.java Fri Dec 22 11:18:38 2006
@@ -38,8 +38,7 @@
       fixedFlow = (FixedFlow) flow;
     else if (flow instanceof CapabilityLanguageFlow)
       capabilityLanguageFlow = (CapabilityLanguageFlow) flow;
-    else
-      ;// can be null if omitted
+      // can be null if omitted
   }
 
   public String[] getFlow() {